CABPI-465:Add new Default Role for imported Users with no Permissions by default Test coverage added

Author: abhattGlo

app/code/Magento/AdminAdobeIms/Console/Command/AdminAdobeImsEnableCommand.php

@@ -184,7 +184,7 @@ protected function execute(InputInterface $input, OutputInterface $output): ?int
             if ($clientId && $clientSecret && $organizationId && $isTwoFactorAuthEnabled) {
                 $enabled = $this->enableModule($clientId, $clientSecret, $organizationId, $isTwoFactorAuthEnabled);
                 if ($enabled) {
-                    $this->saveIMSAuthorizationRole();
+                    $this->saveImsAuthorizationRole();
                     $output->writeln(__('Admin Adobe IMS integration is enabled'));
                     return Cli::RETURN_SUCCESS;
                 }
@@ -203,19 +203,24 @@ protected function execute(InputInterface $input, OutputInterface $output): ?int
         }
     }
 
-    private function saveIMSAuthorizationRole(): bool
+    /**
+     * Save new Adobe IMS role
+     *
+     * @return void
+     * @throws \Exception
+     */
+    private function saveImsAuthorizationRole(): bool
     {
-        $roleCollection = $this->roleCollection->create()->addFieldToFilter('role_name', 'AdobeImsRole');
-
+        $roleCollection = $this->roleCollection->create()->addFieldToFilter('role_name', 'Adobe Ims');
         if (!$roleCollection->getSize()) {
-            $this->role->setRoleName('AdobeImsRole')
+            $this->role->setRoleName('Adobe Ims')
                 ->setUserType((string)UserContextInterface::USER_TYPE_ADMIN)
                 ->setUserId(0)
                 ->setRoleType(\Magento\Authorization\Model\Acl\Role\Group::ROLE_TYPE)
                 ->setParentId(0)
                 ->save();
-            return true;
         }
+
         return true;
     }
 

app/code/Magento/AdminAdobeIms/Test/Unit/Command/AdminAdobeImsEnableCommandTest.php

@@ -14,6 +14,9 @@
 use Magento\AdminAdobeIms\Service\UpdateTokensService;
 use Magento\AdminAdobeIms\Service\ImsCommandOptionService;
 use Magento\AdminAdobeIms\Service\ImsConfig;
+use Magento\Authorization\Model\ResourceModel\Role\Collection as RoleCollection;
+use Magento\Authorization\Model\ResourceModel\Role\CollectionFactory;
+use Magento\Authorization\Model\Role;
 use Magento\Framework\App\Cache\Type\Config;
 use Magento\Framework\App\Cache\TypeListInterface;
 use Magento\Framework\TestFramework\Unit\Helper\ObjectManager as ObjectManagerHelper;
@@ -64,6 +67,16 @@ class AdminAdobeImsEnableCommandTest extends TestCase
      */
     private $questionHelperMock;
 
+    /**
+     * @var Role
+     */
+    private $role;
+
+    /**
+     * @var CollectionFactory
+     */
+    private $roleCollection;
+
     /**
      * @var AdminAdobeImsEnableCommand
      */
@@ -78,6 +91,28 @@ protected function setUp(): void
         $this->imsCommandOptionService = $this->createMock(ImsCommandOptionService::class);
         $this->typeListInterface = $this->createMock(TypeListInterface::class);
         $this->updateTokensService = $this->createMock(UpdateTokensService::class);
+        $roleCollectionMock = $this->createPartialMock(
+            RoleCollection::class,
+            ['addFieldToFilter', 'getSize']
+        );
+        $roleCollectionMock->method('addFieldToFilter')->willReturnSelf();
+        $this->roleCollection = $this->createPartialMock(
+            CollectionFactory::class,
+            ['create']
+        );
+        $this->roleCollection->method('create')->willReturn(
+            $roleCollectionMock
+        );
+        $this->role =  $this->getMockBuilder(Role::class)
+            ->setMethods(['setParentId','setRoleType','setUserId','setRoleName','setUserType','save'])
+            ->disableOriginalConstructor()
+            ->getMock();
+        $this->role->method('setRoleName')->willReturnSelf();
+        $this->role->method('setUserType')->willReturnSelf();
+        $this->role->method('setUserId')->willReturnSelf();
+        $this->role->method('setRoleType')->willReturnSelf();
+        $this->role->method('setParentId')->willReturnSelf();
+        $this->role->method('save')->willReturnSelf();
 
         $this->questionHelperMock = $this->getMockBuilder(QuestionHelper::class)
             ->disableOriginalConstructor()
@@ -90,7 +125,9 @@ protected function setUp(): void
                 'adminImsConnection' => $this->adminImsConnectionMock,
                 'imsCommandOptionService' => $this->imsCommandOptionService,
                 'cacheTypeList' => $this->typeListInterface,
-                'updateTokenService' => $this->updateTokensService
+                'updateTokenService' => $this->updateTokensService,
+                'role'  => $this->role,
+                'roleCollection'  => $this->roleCollection
             ]
         );
     }