Skip to content

Commit 269aedc

Browse files
rimple-sainirimple-saini
committed
Merge remote-tracking branch 'origin/2.4-develop' into AC-6685
2 parents 6d0432a + 62aafe2 commit 269aedc

File tree

18 files changed

+398
-42
lines changed

18 files changed

+398
-42
lines changed

‎app/code/Magento/Catalog/Controller/Adminhtml/Product/Attribute/Save.php‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -326,6 +326,9 @@ public function execute()
326326
return $this->returnResult('catalog/*/', [], ['error' => false]);
327327
} catch (\Exception $e) {
328328
$this->messageManager->addErrorMessage($e->getMessage());
329+
if ($attributeId === null) {
330+
unset($data['frontend_input']);
331+
}
329332
$this->_session->setAttributeData($data);
330333
return $this->returnResult(
331334
'catalog/*/edit',

‎app/code/Magento/CatalogImportExport/Model/Import/Product.php‎

Lines changed: 17 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@
1616
use Magento\CatalogImportExport\Model\Import\Product\StatusProcessor;
1717
use Magento\CatalogImportExport\Model\Import\Product\StockProcessor;
1818
use Magento\CatalogImportExport\Model\StockItemImporterInterface;
19+
use Magento\CatalogImportExport\Model\StockItemProcessorInterface;
1920
use Magento\CatalogInventory\Api\Data\StockItemInterface;
2021
use Magento\Framework\App\Filesystem\DirectoryList;
2122
use Magento\Framework\App\ObjectManager;
@@ -229,7 +230,6 @@ class Product extends AbstractEntity
229230
* @deprecated 101.1.0 use DI for LinkProcessor class if you want to add additional types
230231
*
231232
* @see Magento_CatalogImportExport::etc/di.xml
232-
*
233233
* @var array
234234
*/
235235
protected $_linkNameToId = [
@@ -615,8 +615,8 @@ class Product extends AbstractEntity
615615
/**
616616
* @var array
617617
* @deprecated 100.0.3
618-
* @since 100.0.3
619618
*
619+
* @since 100.0.3
620620
* @see we don't recommend this approach anymore
621621
*/
622622
protected $productUrlKeys = [];
@@ -756,6 +756,11 @@ class Product extends AbstractEntity
756756
*/
757757
private $linkProcessor;
758758

759+
/**
760+
* @var StockItemProcessorInterface
761+
*/
762+
private $stockItemProcessor;
763+
759764
/**
760765
* @param \Magento\Framework\Json\Helper\Data $jsonHelper
761766
* @param \Magento\ImportExport\Helper\Data $importExportData
@@ -805,6 +810,7 @@ class Product extends AbstractEntity
805810
* @param StockProcessor|null $stockProcessor
806811
* @param LinkProcessor|null $linkProcessor
807812
* @param File|null $fileDriver
813+
* @param StockItemProcessorInterface|null $stockItemProcessor
808814
* @throws LocalizedException
809815
* @throws \Magento\Framework\Exception\FileSystemException
810816
* @SuppressWarnings(PHPMD.ExcessiveParameterList)
@@ -859,7 +865,8 @@ public function __construct(
859865
StatusProcessor $statusProcessor = null,
860866
StockProcessor $stockProcessor = null,
861867
LinkProcessor $linkProcessor = null,
862-
?File $fileDriver = null
868+
?File $fileDriver = null,
869+
?StockItemProcessorInterface $stockItemProcessor = null
863870
) {
864871
$this->_eventManager = $eventManager;
865872
$this->stockRegistry = $stockRegistry;
@@ -923,6 +930,8 @@ public function __construct(
923930
$this->dateTimeFactory = $dateTimeFactory ?? ObjectManager::getInstance()->get(DateTimeFactory::class);
924931
$this->productRepository = $productRepository ?? ObjectManager::getInstance()
925932
->get(ProductRepositoryInterface::class);
933+
$this->stockItemProcessor = $stockItemProcessor ?? ObjectManager::getInstance()
934+
->get(StockItemProcessorInterface::class);
926935
}
927936

928937
/**
@@ -1286,6 +1295,7 @@ protected function _prepareRowForDb(array $rowData)
12861295
*
12871296
* @deprecated 101.1.0 use linkProcessor Directly
12881297
* @see linkProcessor
1298+
*
12891299
* @return $this
12901300
*/
12911301
protected function _saveLinks()
@@ -2328,6 +2338,7 @@ protected function _saveStockItem()
23282338
{
23292339
while ($bunch = $this->_dataSourceModel->getNextBunch()) {
23302340
$stockData = [];
2341+
$importedData = [];
23312342
$productIdsToReindex = [];
23322343
$stockChangedProductIds = [];
23332344
// Format bunch to stock data rows
@@ -2353,12 +2364,13 @@ protected function _saveStockItem()
23532364

23542365
if (!isset($stockData[$sku])) {
23552366
$stockData[$sku] = $row;
2367+
$importedData[$sku] = $rowData;
23562368
}
23572369
}
23582370

23592371
// Insert rows
23602372
if (!empty($stockData)) {
2361-
$this->stockItemImporter->import($stockData);
2373+
$this->stockItemProcessor->process($stockData, $importedData);
23622374
}
23632375

23642376
$this->reindexStockStatus($stockChangedProductIds);
@@ -2512,6 +2524,7 @@ public function getRowScope(array $rowData)
25122524
* @SuppressWarnings(PHPMD.CyclomaticComplexity)
25132525
* @SuppressWarnings(PHPMD.NPathComplexity)
25142526
* @SuppressWarnings(PHPMD.ExcessiveMethodLength)
2527+
* @throws \Zend_Validate_Exception
25152528
*/
25162529
public function validateRow(array $rowData, $rowNum)
25172530
{

‎app/code/Magento/CatalogImportExport/Model/StockItemProcessor.php‎

Lines changed: 33 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,33 @@
1+
<?php
2+
/**
3+
* Copyright © Magento, Inc. All rights reserved.
4+
* See COPYING.txt for license details.
5+
*/
6+
declare(strict_types=1);
7+
8+
namespace Magento\CatalogImportExport\Model;
9+
10+
class StockItemProcessor implements StockItemProcessorInterface
11+
{
12+
/**
13+
* @var StockItemImporterInterface
14+
*/
15+
private $stockItemImporter;
16+
17+
/**
18+
* @param StockItemImporterInterface $stockItemImporter
19+
*/
20+
public function __construct(
21+
StockItemImporterInterface $stockItemImporter
22+
) {
23+
$this->stockItemImporter = $stockItemImporter;
24+
}
25+
26+
/**
27+
* @inheritdoc
28+
*/
29+
public function process(array $stockData, array $importedData): void
30+
{
31+
$this->stockItemImporter->import($stockData);
32+
}
33+
}

‎app/code/Magento/CatalogImportExport/Model/StockItemProcessorInterface.php‎

Lines changed: 27 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,27 @@
1+
<?php
2+
/**
3+
* Copyright © Magento, Inc. All rights reserved.
4+
* See COPYING.txt for license details.
5+
*/
6+
declare(strict_types=1);
7+
8+
namespace Magento\CatalogImportExport\Model;
9+
10+
use Magento\Framework\Exception\CouldNotSaveException;
11+
use Magento\Framework\Exception\InputException;
12+
use Magento\Framework\Validation\ValidationException;
13+
14+
interface StockItemProcessorInterface
15+
{
16+
/**
17+
* Handle Import of Stock Item Data
18+
*
19+
* @param array $stockData
20+
* @param array $importedData
21+
* @return void
22+
* @throws CouldNotSaveException
23+
* @throws InputException
24+
* @throws ValidationException
25+
*/
26+
public function process(array $stockData, array $importedData): void;
27+
}

‎app/code/Magento/CatalogImportExport/etc/di.xml‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88
<config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:framework:ObjectManager/etc/config.xsd">
99
<preference for="Magento\CatalogImportExport\Model\Export\RowCustomizerInterface" type="Magento\CatalogImportExport\Model\Export\RowCustomizer\Composite" />
1010
<preference for="Magento\CatalogImportExport\Model\StockItemImporterInterface" type="Magento\CatalogImportExport\Model\StockItemImporter" />
11+
<preference for="Magento\CatalogImportExport\Model\StockItemProcessorInterface" type="Magento\CatalogImportExport\Model\StockItemProcessor" />
1112
<preference for="Magento\CatalogImportExport\Model\Export\ProductFilterInterface" type="Magento\CatalogImportExport\Model\Export\ProductFilters" />
1213
<type name="Magento\ImportExport\Model\Import">
1314
<plugin name="catalogProductFlatIndexerImport" type="Magento\CatalogImportExport\Model\Indexer\Product\Flat\Plugin\Import" />

‎app/code/Magento/Config/Model/Config/Structure/Element/Dependency/Field.php‎

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -5,15 +5,13 @@
55
*/
66
namespace Magento\Config\Model\Config\Structure\Element\Dependency;
77

8-
/**
9-
* @api
10-
* @since 100.0.2
11-
*/
12-
138
/**
149
* Class Field
1510
*
1611
* Fields are used to describe possible values for a type/interface.
12+
*
13+
* @api
14+
* @since 100.0.2
1715
*/
1816
class Field
1917
{

‎app/code/Magento/Customer/Test/Fixture/Customer.php‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@
2828
class Customer implements RevertibleDataFixtureInterface
2929
{
3030
private const DEFAULT_DATA = [
31-
'password' => null,
31+
'password' => 'password',
3232
CustomerInterface::ID => null,
3333
CustomerInterface::CONFIRMATION => null,
3434
CustomerInterface::CREATED_AT => null,

‎app/code/Magento/Eav/Model/Entity/Attribute.php‎

Lines changed: 20 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
*/
66
namespace Magento\Eav\Model\Entity;
77

8+
use Magento\Eav\Model\ReservedAttributeCheckerInterface;
89
use Magento\Eav\Model\Validator\Attribute\Code as AttributeCodeValidator;
910
use Magento\Framework\Api\AttributeValueFactory;
1011
use Magento\Framework\App\ObjectManager;
@@ -29,17 +30,17 @@ class Attribute extends \Magento\Eav\Model\Entity\Attribute\AbstractAttribute im
2930
* The value is defined as 60 because in the flat mode attribute code will be transformed into column name.
3031
* MySQL allows only 64 symbols in column name.
3132
*/
32-
const ATTRIBUTE_CODE_MAX_LENGTH = 60;
33+
public const ATTRIBUTE_CODE_MAX_LENGTH = 60;
3334

3435
/**
3536
* Min accepted length of an attribute code.
3637
*/
37-
const ATTRIBUTE_CODE_MIN_LENGTH = 1;
38+
public const ATTRIBUTE_CODE_MIN_LENGTH = 1;
3839

3940
/**
4041
* Tag to use for attributes caching.
4142
*/
42-
const CACHE_TAG = 'EAV_ATTRIBUTE';
43+
public const CACHE_TAG = 'EAV_ATTRIBUTE';
4344

4445
/**
4546
* Prefix of model events names
@@ -69,6 +70,9 @@ class Attribute extends \Magento\Eav\Model\Entity\Attribute\AbstractAttribute im
6970

7071
/**
7172
* @var \Magento\Catalog\Model\Product\ReservedAttributeList
73+
*
74+
* @deprecated Incorrect direct dependency on Product attribute.
75+
* @see \Magento\Eav\Model\Entity\Attribute::$reservedAttributeChecker
7276
*/
7377
protected $reservedAttributeList;
7478

@@ -87,6 +91,11 @@ class Attribute extends \Magento\Eav\Model\Entity\Attribute\AbstractAttribute im
8791
*/
8892
private $attributeCodeValidator;
8993

94+
/**
95+
* @var ReservedAttributeCheckerInterface|null
96+
*/
97+
private $reservedAttributeChecker;
98+
9099
/**
91100
* @param \Magento\Framework\Model\Context $context
92101
* @param \Magento\Framework\Registry $registry
@@ -108,6 +117,7 @@ class Attribute extends \Magento\Eav\Model\Entity\Attribute\AbstractAttribute im
108117
* @param \Magento\Framework\Data\Collection\AbstractDb $resourceCollection
109118
* @param array $data
110119
* @param AttributeCodeValidator|null $attributeCodeValidator
120+
* @param ReservedAttributeCheckerInterface|null $reservedAttributeChecker
111121
* @SuppressWarnings(PHPMD.ExcessiveParameterList)
112122
* @codeCoverageIgnore
113123
*/
@@ -131,7 +141,8 @@ public function __construct(
131141
\Magento\Framework\Model\ResourceModel\AbstractResource $resource = null,
132142
\Magento\Framework\Data\Collection\AbstractDb $resourceCollection = null,
133143
array $data = [],
134-
AttributeCodeValidator $attributeCodeValidator = null
144+
AttributeCodeValidator $attributeCodeValidator = null,
145+
?ReservedAttributeCheckerInterface $reservedAttributeChecker = null
135146
) {
136147
parent::__construct(
137148
$context,
@@ -157,6 +168,9 @@ public function __construct(
157168
$this->attributeCodeValidator = $attributeCodeValidator ?: ObjectManager::getInstance()->get(
158169
AttributeCodeValidator::class
159170
);
171+
$this->reservedAttributeChecker = $reservedAttributeChecker ?: ObjectManager::getInstance()->get(
172+
ReservedAttributeCheckerInterface::class
173+
);
160174
}
161175

162176
/**
@@ -251,7 +265,7 @@ public function beforeSave()
251265
}
252266

253267
// prevent overriding product data
254-
if (isset($this->_data['attribute_code']) && $this->reservedAttributeList->isReservedAttribute($this)) {
268+
if (isset($this->_data['attribute_code']) && $this->reservedAttributeChecker->isReservedAttribute($this)) {
255269
throw new LocalizedException(
256270
__(
257271
'The attribute code \'%1\' is reserved by system. Please try another attribute code',
@@ -535,6 +549,7 @@ public function __wakeup()
535549
$this->_localeDate = $objectManager->get(\Magento\Framework\Stdlib\DateTime\TimezoneInterface::class);
536550
$this->_localeResolver = $objectManager->get(\Magento\Framework\Locale\ResolverInterface::class);
537551
$this->reservedAttributeList = $objectManager->get(\Magento\Catalog\Model\Product\ReservedAttributeList::class);
552+
$this->reservedAttributeChecker = $objectManager->get(ReservedAttributeCheckerInterface::class);
538553
$this->dateTimeFormatter = $objectManager->get(DateTimeFormatterInterface::class);
539554
}
540555

‎app/code/Magento/Eav/Model/ReservedAttributeChecker.php‎

Lines changed: 20 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
class ReservedAttributeChecker implements ReservedAttributeCheckerInterface
1919
{
2020
/**
21-
* @var ReservedAttributeCheckerInterface[][]
21+
* @var ReservedAttributeCheckerInterface[]
2222
*/
2323
private $validators;
2424

@@ -37,7 +37,8 @@ public function __construct(
3737
public function isReservedAttribute(AbstractAttribute $attribute): bool
3838
{
3939
$isReserved = false;
40-
$validators = $this->validators[$attribute->getEntityType()->getEntityTypeCode()] ?? [];
40+
$entityTypeCode = $this->getAttributeEntityTypeCode($attribute);
41+
$validators = $this->validators[$entityTypeCode] ?? [];
4142
foreach ($validators as $validator) {
4243
$isReserved = $validator->isReservedAttribute($attribute);
4344
if ($isReserved === true) {
@@ -47,4 +48,21 @@ public function isReservedAttribute(AbstractAttribute $attribute): bool
4748

4849
return $isReserved;
4950
}
51+
52+
/**
53+
* Returns attribute entity type code.
54+
*
55+
* @param AbstractAttribute $attribute
56+
* @return string|null
57+
*/
58+
private function getAttributeEntityTypeCode(AbstractAttribute $attribute): ?string
59+
{
60+
try {
61+
$result = $attribute->getEntityType()->getEntityTypeCode();
62+
} catch (LocalizedException $e) {
63+
$result = null;
64+
}
65+
66+
return $result;
67+
}
5068
}

‎app/code/Magento/Payment/Model/Method/Free.php‎

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -20,16 +20,16 @@
2020
*/
2121
class Free extends \Magento\Payment\Model\Method\AbstractMethod
2222
{
23-
const PAYMENT_METHOD_FREE_CODE = 'free';
23+
public const PAYMENT_METHOD_FREE_CODE = 'free';
2424

2525
/**
2626
* XML Paths for configuration constants
2727
*/
28-
const XML_PATH_PAYMENT_FREE_ACTIVE = 'payment/free/active';
28+
public const XML_PATH_PAYMENT_FREE_ACTIVE = 'payment/free/active';
2929

30-
const XML_PATH_PAYMENT_FREE_ORDER_STATUS = 'payment/free/order_status';
30+
public const XML_PATH_PAYMENT_FREE_ORDER_STATUS = 'payment/free/order_status';
3131

32-
const XML_PATH_PAYMENT_FREE_PAYMENT_ACTION = 'payment/free/payment_action';
32+
public const XML_PATH_PAYMENT_FREE_PAYMENT_ACTION = 'payment/free/payment_action';
3333

3434
/**
3535
* Payment Method features
@@ -50,6 +50,11 @@ class Free extends \Magento\Payment\Model\Method\AbstractMethod
5050
*/
5151
protected $priceCurrency;
5252

53+
/**
54+
* @var bool
55+
*/
56+
protected $_isOffline = true;
57+
5358
/**
5459
* @param \Magento\Framework\Model\Context $context
5560
* @param \Magento\Framework\Registry $registry

0 commit comments

Comments
 (0)