improvement

engcom-Charlie · engcom-Charlie · commit 23f98498398e · 2020-03-10T11:12:30.000+02:00
diff --git a/app/code/Magento/Quote/Plugin/UpdateCartId.php b/app/code/Magento/Quote/Plugin/UpdateCartId.php
@@ -42,7 +42,9 @@ public function beforeSave(
         GuestCartItemRepositoryInterface $guestCartItemRepository,
         CartItemInterface $cartItem
     ): void {
-        if ($cartId = $this->request->getParam('cartId')) {
+        $cartId = $this->request->getParam('cartId');
+
+        if ($cartId) {
             $cartItem->setQuoteId($cartId);
         }
     }

Original file line number	Diff line number	Diff line change
`@@ -42,7 +42,9 @@ public function beforeSave(`
`42`	`42`	`GuestCartItemRepositoryInterface $guestCartItemRepository,`
`43`	`43`	`CartItemInterface $cartItem`
`44`	`44`	`): void {`
`45`		`- if ($cartId = $this->request->getParam('cartId')) {`
	`45`	`+ $cartId = $this->request->getParam('cartId');`
	`46`	`+`
	`47`	`+ if ($cartId) {`
`46`	`48`	`$cartItem->setQuoteId($cartId);`
`47`	`49`	`}`
`48`	`50`	`}`