ACP2E-3666: [Mainline] Cart Price rule is not respecting Multishipping

- Initial commit with tests

Author: arnobsh

app/code/Magento/SalesRule/Model/Rule/Condition/Product/Subselect.php

@@ -1,29 +1,33 @@
 <?php
 /**
- * Copyright © Magento, Inc. All rights reserved.
- * See COPYING.txt for license details.
+ * Copyright 2011 Adobe
+ * All Rights Reserved.
  */
 namespace Magento\SalesRule\Model\Rule\Condition\Product;
 
+use Magento\Catalog\Model\Product\Type;
+use Magento\Framework\Model\AbstractModel;
 use Magento\Quote\Api\Data\TotalsItemInterface;
+use Magento\Rule\Model\Condition\Context;
+use Magento\SalesRule\Model\Rule\Condition\Product;
 
 /**
- * Subselect conditions for product.
+ * SubSelect conditions for product.
  */
-class Subselect extends \Magento\SalesRule\Model\Rule\Condition\Product\Combine
+class Subselect extends Combine
 {
     /**
-     * @param \Magento\Rule\Model\Condition\Context $context
-     * @param \Magento\SalesRule\Model\Rule\Condition\Product $ruleConditionProduct
+     * @param Context $context
+     * @param Product $ruleConditionProduct
      * @param array $data
      */
     public function __construct(
-        \Magento\Rule\Model\Condition\Context $context,
-        \Magento\SalesRule\Model\Rule\Condition\Product $ruleConditionProduct,
+        Context $context,
+        Product $ruleConditionProduct,
         array $data = []
     ) {
         parent::__construct($context, $ruleConditionProduct, $data);
-        $this->setType(\Magento\SalesRule\Model\Rule\Condition\Product\Subselect::class)->setValue(null);
+        $this->setType(Subselect::class)->setValue(null);
     }
 
     /**
@@ -143,43 +147,94 @@ public function asHtml()
     }
 
     /**
-     * Validate
+     * Validate subSelect conditions, base_row_total and attribute
      *
-     * @param \Magento\Framework\Model\AbstractModel $model
+     * @param AbstractModel $model
      * @return bool
      * @SuppressWarnings(PHPMD.CyclomaticComplexity)
      */
-    public function validate(\Magento\Framework\Model\AbstractModel $model)
+    public function validate(AbstractModel $model)
     {
+        $subSelectConditionsFlag = true;
         if (!$this->getConditions()) {
             return false;
         }
+
         $attr = $this->getAttribute();
         $total = 0;
-        foreach ($model->getQuote()->getAllVisibleItems() as $item) {
-            $hasValidChild = false;
-            $useChildrenTotal = ($item->getProductType() == \Magento\Catalog\Model\Product\Type::TYPE_BUNDLE);
-            $childrenAttrTotal = 0;
-            $children = $item->getChildren();
-            if (!empty($children)) {
-                foreach ($children as $child) {
-                    if (parent::validate($child)) {
-                        $hasValidChild = true;
-                        if ($useChildrenTotal) {
-                            $childrenAttrTotal += $child->getData($attr);
-                        }
-                    }
-                }
+
+        foreach ($model->getAllItems() as $item) {
+            $subSelectConditionsFlag = $this->validateSubSelectConditions($item);
+            if ($subSelectConditionsFlag) {
+                $total = $this->getBaseRowTotalForChildrenProduct($item, $attr, $total);
             }
-            if ($attr !== TotalsItemInterface::KEY_BASE_ROW_TOTAL) {
-                $childrenAttrTotal *= $item->getQty();
+        }
+        return $subSelectConditionsFlag && $this->validateAttribute($total);
+    }
+
+    /**
+     * Check subSelect conditions to verify if they are met
+     *
+     * @param mixed $item
+     * @return bool
+     */
+    private function validateSubSelectConditions(mixed $item): bool
+    {
+        $subSelectConditionsFlag = true;
+        $all = $this->getAggregator() === 'all';
+        $true = (bool)$this->getValue();
+        $conditions = $this->getConditions();
+        if (!empty($conditions)) {
+            foreach ($conditions as $cond) {
+                if ($item instanceof AbstractModel) {
+                    $validated = $cond->validate($item);
+                } else {
+                    $validated = $cond->validateByEntityId($item);
+                }
+                if ($all && $validated !== $true) {
+                    $subSelectConditionsFlag = false;
+                    break;
+                } elseif (!$all && $validated === $true) {
+                    continue;
+                }
             }
-            if ($hasValidChild || parent::validate($item)) {
-                $total += ($hasValidChild && $useChildrenTotal && $childrenAttrTotal > 0)
-                    ? $childrenAttrTotal
-                    : $item->getData($attr);
+        }
+        return $subSelectConditionsFlag;
+    }
+
+    /**
+     * Get base row total for children product for bundle and configurable product
+     *
+     * @param mixed $item
+     * @param mixed $attr
+     * @param int $total
+     * @return int|mixed
+     * @SuppressWarnings(PHPMD.CyclomaticComplexity)
+     */
+    private function getBaseRowTotalForChildrenProduct(mixed $item, mixed $attr, int $total): mixed
+    {
+        $hasValidChild = false;
+        $useChildrenTotal = ($item->getProductType() == Type::TYPE_BUNDLE);
+        $childrenAttrTotal = 0;
+        $children = $item->getChildren();
+        if (!empty($children)) {
+            foreach ($children as $child) {
+                if (parent::validate($child)) {
+                    $hasValidChild = true;
+                    if ($useChildrenTotal) {
+                        $childrenAttrTotal += $child->getData($attr);
+                    }
+                }
             }
         }
-        return $this->validateAttribute($total);
+        if ($attr !== TotalsItemInterface::KEY_BASE_ROW_TOTAL) {
+            $childrenAttrTotal *= $item->getQty();
+        }
+        if ($hasValidChild || parent::validate($item)) {
+            $total += ($hasValidChild && $useChildrenTotal && $childrenAttrTotal > 0)
+                ? $childrenAttrTotal
+                : $item->getData($attr);
+        }
+        return $total;
     }
 }

app/code/Magento/SalesRule/Test/Unit/Model/Rule/Condition/Product/SubselectTest.php

@@ -1,7 +1,7 @@
 <?php
 /**
- * Copyright © Magento, Inc. All rights reserved.
- * See COPYING.txt for license details.
+ * Copyright 2021 Adobe
+ * All Rights Reserved.
  */
 declare(strict_types=1);
 
@@ -10,7 +10,6 @@
 use Magento\Catalog\Model\Product;
 use Magento\Framework\DataObject;
 use Magento\Framework\Model\AbstractModel;
-use Magento\Quote\Model\Quote;
 use Magento\Quote\Model\Quote\Item;
 use Magento\Quote\Model\Quote\Item\AbstractItem;
 use Magento\Rule\Model\Condition\Context;
@@ -37,9 +36,6 @@ class SubselectTest extends TestCase
     /** @var Product|MockObject */
     private $productMock;
 
-    /** @var Quote|MockObject */
-    private $quoteMock;
-
     /** @var Item|MockObject */
     private $quoteItemMock;
 
@@ -55,17 +51,13 @@ protected function setUp(): void
             ->getMock();
         $this->abstractModel = $this->getMockBuilder(AbstractModel::class)
             ->disableOriginalConstructor()
-            ->addMethods(['getQuote', 'getProduct'])
+            ->addMethods(['getAllItems', 'getProduct'])
             ->getMockForAbstractClass();
         $this->productMock = $this->getMockBuilder(Product::class)
             ->onlyMethods(['getData', 'getResource', 'hasData'])
             ->addMethods(['getOperatorForValidate', 'getValueParsed'])
             ->disableOriginalConstructor()
             ->getMock();
-        $this->quoteMock = $this->getMockBuilder(Quote::class)
-            ->disableOriginalConstructor()
-            ->onlyMethods(['getAllVisibleItems'])
-            ->getMock();
         $this->quoteItemMock = $this->getMockBuilder(Item::class)
             ->addMethods(['getHasChildren', 'getProductId'])
             ->onlyMethods(
@@ -74,19 +66,15 @@ protected function setUp(): void
                     'getProduct',
                     'getProductType',
                     'getChildren',
-                    'getQuote',
                     'getAddress',
                     'getOptionByCode'
                 ]
             )
             ->disableOriginalConstructor()
             ->getMock();
-        $this->quoteMock->expects($this->any())
-            ->method('getAllVisibleItems')
-            ->willReturn([$this->quoteItemMock]);
         $this->abstractModel->expects($this->any())
-            ->method('getQuote')
-            ->willReturn($this->quoteMock);
+            ->method('getAllItems')
+            ->willReturn([$this->quoteItemMock]);
         $this->abstractModel->expects($this->any())
             ->method('getProduct')
             ->willReturn($this->productMock);