ACP2E-2376: avoid double calculation for configurable and child product while applying discount for configurable

Author: alzota

app/code/Magento/SalesRule/Model/Validator.php

@@ -7,8 +7,6 @@
 namespace Magento\SalesRule\Model;
 
 use Laminas\Validator\ValidatorInterface;
-use Magento\Catalog\Model\Product\Type;
-use Magento\ConfigurableProduct\Model\Product\Type\Configurable;
 use Magento\Framework\App\ObjectManager;
 use Magento\Framework\ObjectManager\ResetAfterRequestInterface;
 use Magento\Quote\Model\Quote;
@@ -513,16 +511,10 @@ public function initTotals($items, Address $address)
      */
     private function isValidItemForRule(AbstractItem $item, Rule $rule)
     {
-        if ($item->getProductType() === Type::TYPE_SIMPLE  && $item->getParentItemId() != null
-            && $item->getParentItem()->getProductType() === Configurable::TYPE_CODE) {
-            return false;
-        }
-
-        if (($item->getHasChildren() || $item->getChildren()) && $item->isChildrenCalculated()) {
-            return false;
-        }
-
-        if ($item->getNoDiscount()) {
+        if ($item->getParentItem() && $item->getParentItem()->getProductType() === 'configurable'
+            || (($item->getHasChildren() || $item->getChildren()) && $item->isChildrenCalculated())
+            || $item->getNoDiscount()
+        ) {
             return false;
         }