Skip to content

Commit 1d1acab

Browse files
manishranjan-adobemanishranjan-adobe
committed
AC-12092_PHPUnit10: Providing invalid named argument is deprecated and will not be supported in PHPUnit 11
1 parent e7b8e98 commit 1d1acab

File tree

35 files changed

+132
-132
lines changed

35 files changed

+132
-132
lines changed

‎lib/internal/Magento/Framework/Acl/Test/Unit/AclResource/Config/Converter/DomTest.php‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -65,9 +65,9 @@ public function testConvertWithInvalidDom($xml)
6565
public static function convertWithInvalidDomDataProvider()
6666
{
6767
return [
68-
[
69-
'resource without "id" attribute' => '<?xml version="1.0"?><config><acl>' .
70-
'<resources><resource/></resources></acl></config>',
68+
'resource without "id" attribute' => [
69+
'xml' => '<?xml version="1.0"?><config><acl>' .
70+
'<resources><resource/></resources></acl></config>'
7171
]
7272
];
7373
}

‎lib/internal/Magento/Framework/Amqp/Test/Unit/Connection/FactoryTest.php‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -118,12 +118,12 @@ public static function connectionDataProvider()
118118
{
119119
return [
120120
[
121-
'ssl_enabled' => true,
122-
'connection_class' => AMQPSSLConnection::class,
121+
'sslEnabled' => true,
122+
'connectionClass' => AMQPSSLConnection::class,
123123
],
124124
[
125-
'ssl_enabled' => false,
126-
'connection_class' => AMQPStreamConnection::class,
125+
'sslEnabled' => false,
126+
'connectionClass' => AMQPStreamConnection::class,
127127
],
128128
];
129129
}

‎lib/internal/Magento/Framework/App/Test/Unit/Response/HeaderProvider/XssProtectionTest.php‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -39,16 +39,16 @@ public static function userAgentDataProvider()
3939
{
4040
return [
4141
[
42-
'user-agent' => 'Mozilla/5.0 (compatible; MSIE 8.0; Windows NT 6.1; Trident/4.0; GTB7.4)',
43-
'expected-header' => XssProtection::HEADER_DISABLED
42+
'userAgent' => 'Mozilla/5.0 (compatible; MSIE 8.0; Windows NT 6.1; Trident/4.0; GTB7.4)',
43+
'expectedHeader' => XssProtection::HEADER_DISABLED
4444
],
4545
[
46-
'user-agent' => 'Mozilla/5.0 (compatible; MSIE 10.0; Windows NT 6.1; Trident/4.0; GTB7.4)',
47-
'expected-header' => XssProtection::HEADER_ENABLED
46+
'userAgent' => 'Mozilla/5.0 (compatible; MSIE 10.0; Windows NT 6.1; Trident/4.0; GTB7.4)',
47+
'expectedHeader' => XssProtection::HEADER_ENABLED
4848
],
4949
[
50-
'user-agent' => 'Mozilla/5.0 (Macintosh; Intel Mac OS X 10_10_1) Chrome/41.0.2227.1 Safari/537.36',
51-
'expected-header' => XssProtection::HEADER_ENABLED
50+
'userAgent' => 'Mozilla/5.0 (Macintosh; Intel Mac OS X 10_10_1) Chrome/41.0.2227.1 Safari/537.36',
51+
'expectedHeader' => XssProtection::HEADER_ENABLED
5252
],
5353
];
5454
}

‎lib/internal/Magento/Framework/Code/Test/Unit/GeneratorTest.php‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -347,8 +347,8 @@ public function generateValidClassDataProvider(): array
347347
foreach ($this->expectedEntities as $generatedEntity) {
348348
$generatedEntity = ucfirst($generatedEntity);
349349
$data['test class for ' . $generatedEntity] = [
350-
'class name' => self::SOURCE_CLASS,
351-
'entity type' => $generatedEntity,
350+
'className' => self::SOURCE_CLASS,
351+
'entityType' => $generatedEntity,
352352
];
353353
}
354354
return $data;

‎lib/internal/Magento/Framework/DB/Test/Unit/Adapter/Pdo/MysqlTest.php‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -438,7 +438,7 @@ public static function addColumnDataProvider()
438438
{
439439
return [
440440
[
441-
'columnData' => [
441+
'options' => [
442442
'TYPE' => 'integer',
443443
'IDENTITY' => true,
444444
'UNSIGNED' => true,

‎lib/internal/Magento/Framework/Data/Test/Unit/AbstractCriteriaTest.php‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -223,7 +223,7 @@ public static function dataProviderRemoveAllFilters()
223223
{
224224
return [
225225
[
226-
'actualResult' => [
226+
'actualField' => [
227227
'test-filter-name',
228228
'test-field-name',
229229
'test-condition',
@@ -243,7 +243,7 @@ public static function dataProviderRemoveFilter()
243243
{
244244
return [
245245
[
246-
'actualResult' => [
246+
'actualField' => [
247247
'test-filter-name',
248248
'test-field-name',
249249
'test-condition',

‎lib/internal/Magento/Framework/Indexer/Test/Unit/Config/ConverterTest.php‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -133,14 +133,14 @@ public static function convertWithCircularDependenciesDataProvider()
133133
{
134134
return [
135135
'Circular dependency on the first level' => [
136-
'inputXML' => '<?xml version="1.0" encoding="UTF-8"?><config>'
136+
'inputXml' => '<?xml version="1.0" encoding="UTF-8"?><config>'
137137
. '<indexer id="indexer_1"><dependencies><indexer id="indexer_2"/></dependencies></indexer>'
138138
. '<indexer id="indexer_2"><dependencies><indexer id="indexer_1"/></dependencies></indexer>'
139139
. '</config>',
140140
'exceptionMessage' => "Circular dependency references from 'indexer_2' to 'indexer_1'.",
141141
],
142142
'Circular dependency a deeper than the first level' => [
143-
'inputXML' => '<?xml version="1.0" encoding="UTF-8"?><config>'
143+
'inputXml' => '<?xml version="1.0" encoding="UTF-8"?><config>'
144144
. '<indexer id="indexer_1"><dependencies><indexer id="indexer_2"/></dependencies></indexer>'
145145
. '<indexer id="indexer_2"><dependencies><indexer id="indexer_3"/></dependencies></indexer>'
146146
. '<indexer id="indexer_3"><dependencies><indexer id="indexer_4"/></dependencies></indexer>'
@@ -172,7 +172,7 @@ public static function convertWithDependencyOnNotExistingIndexerDataProvider()
172172
{
173173
return [
174174
[
175-
'inputXML' => '<?xml version="1.0" encoding="UTF-8"?><config>'
175+
'inputXml' => '<?xml version="1.0" encoding="UTF-8"?><config>'
176176
. '<indexer id="indexer_1"><dependencies><indexer id="indexer_3"/></dependencies></indexer>'
177177
. '<indexer id="indexer_2"><dependencies><indexer id="indexer_1"/></dependencies></indexer>'
178178
. '</config>',

‎lib/internal/Magento/Framework/Indexer/Test/Unit/Config/DependencyInfoProviderTest.php‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -99,8 +99,8 @@ public static function getDependentIndexerIdsDataProvider()
9999
{
100100
return [
101101
[
102-
'indexer' => 'indexer_2',
103-
'indexers' => [
102+
'indexerId' => 'indexer_2',
103+
'indexersData' => [
104104
'indexer_2' => [
105105
'indexer_id' => 'indexer_2',
106106
'dependencies' => [],
@@ -129,7 +129,7 @@ public static function getDependentIndexerIdsDataProvider()
129129
'dependencies' => [],
130130
],
131131
],
132-
'dependent_indexers' => ['indexer_4', 'indexer_1'],
132+
'dependentIndexerIds' => ['indexer_4', 'indexer_1'],
133133
]
134134
];
135135
}

‎lib/internal/Magento/Framework/Indexer/Test/Unit/ScopeResolver/IndexScopeResolverTest.php‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -94,33 +94,33 @@ public static function resolveDataProvider()
9494
{
9595
return [
9696
[
97-
'index' => 'some_index',
97+
'indexName' => 'some_index',
9898
'dimensions' => [],
9999
'expected' => 'some_index'
100100
],
101101
[
102-
'index' => 'index_name',
102+
'indexName' => 'index_name',
103103
'dimensions' => [['scope', 'name']],
104104
'expected' => 'index_name_scope1'
105105
],
106106
[
107-
'index' => 'index_name',
107+
'indexName' => 'index_name',
108108
'dimensions' => [['index', 20]],
109109
'expected' => 'index_name_index20'
110110
],
111111
[
112-
'index' => 'index_name',
112+
'indexName' => 'index_name',
113113
'dimensions' => [['first', 10], ['second', 20]],
114114
// actually you will get exception here thrown in ScopeResolverInterface
115115
'expected' => 'index_name_first10_second20'
116116
],
117117
[
118-
'index' => 'index_name',
118+
'indexName' => 'index_name',
119119
'dimensions' => [['second', 10], ['first', 20]],
120120
'expected' => 'index_name_first20_second10'
121121
],
122122
[
123-
'index' => 'index_name',
123+
'indexName' => 'index_name',
124124
'dimensions' => [[-1, 10], ['first', 20]],
125125
'expected' => 'index_name_-110_first20'
126126
]

‎lib/internal/Magento/Framework/Module/Test/Unit/Setup/_files/data_content_plain_model.php‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -9,21 +9,21 @@
99
* See COPYING.txt for license details.
1010
*/
1111
return [
12-
'$replaceRules' => [
12+
'replaceRules' => [
1313
[
1414
'table',
1515
'field',
1616
Migration::ENTITY_TYPE_MODEL,
1717
Migration::FIELD_CONTENT_TYPE_PLAIN,
1818
],
1919
],
20-
'$tableData' => [
20+
'tableData' => [
2121
['field' => 'customer/customer'],
2222
['field' => 'customer/attribute_data_postcode'],
2323
['field' => 'customer/attribute_data_postcode::someMethod'],
2424
['field' => Customer::class],
2525
],
26-
'$expected' => [
26+
'expected' => [
2727
'updates' => [
2828
[
2929
'table' => 'table',
@@ -51,7 +51,7 @@
5151
],
5252
],
5353
],
54-
'$aliasesMap' => [
54+
'aliasesMap' => [
5555
Migration::ENTITY_TYPE_MODEL => [
5656
'customer/customer' => \Magento\Customer\Model\Customer_FROM_MAP::class,
5757
],

0 commit comments

Comments
 (0)