ACP2E-3374: In Backend, default store values for product attributes (instead of expected admin values)

Author: glo23503

app/code/Magento/Rule/Test/Unit/Model/Condition/Product/AbstractProductTest.php

@@ -21,7 +21,6 @@
 use Magento\Eav\Model\ResourceModel\Entity\Attribute\Set\Collection;
 use Magento\Framework\DataObject;
 use Magento\Framework\Model\AbstractModel;
-use Magento\Framework\TestFramework\Unit\Helper\ObjectManager;
 use Magento\Rule\Model\Condition\Product\AbstractProduct;
 use Magento\Store\Api\Data\StoreInterface;
 use Magento\Store\Model\StoreManagerInterface;
@@ -68,17 +67,11 @@ class AbstractProductTest extends TestCase
      */
     private $productCategoryListProperty;
 
-    /**
-     * @var ObjectManager
-     */
-    protected $objectManager;
-
     /**
      * @inheritdoc
      */
     protected function setUp(): void
     {
-        $this->objectManager = new ObjectManager($this);
         $this->_condition = $this->getMockForAbstractClass(
             AbstractProduct::class,
             [],
@@ -351,6 +344,8 @@ public function testGetMappedSqlField()
      * @param bool $expectedAttrObjSourceAllOptionsParam
      * @param array $expectedValueSelectOptions
      * @param array $expectedValueOption
+     * @param array|null $options,
+     * @param array|null $optionsDefault
      * @dataProvider prepareValueOptionsDataProvider
      * @SuppressWarnings(PHPMD.NPathComplexity)
      */
@@ -361,40 +356,32 @@ public function testPrepareValueOptions(
         $attrSetCollectionOptionsArray,
         $expectedAttrObjSourceAllOptionsParam,
         $expectedValueSelectOptions,
-        $expectedValueOption
+        $expectedValueOption,
+        $options = null,
+        $optionsDefault = null
     ) {
         foreach ($setData as $key => $value) {
             $this->_condition->setData($key, $value);
         }
 
-        if ($attributeObjectFrontendInput == 'select') {
+        $attributeObjectMock = $this->getMockBuilder(Attribute::class)
+            ->disableOriginalConstructor()
+            ->getMock();
+        if ($attributeObjectFrontendInput == 'select' || $attributeObjectFrontendInput == 'multiselect') {
             $attrObjectSourceMock = $this->verifySelectAllOptions(
                 $attrObjectSourceAllOptionsValue,
-                $expectedAttrObjSourceAllOptionsParam
+                $expectedAttrObjSourceAllOptionsParam,
+                $options,
+                $optionsDefault
             );
-        } else {
-            $attrObjectSourceMock = $this->getMockBuilder(AbstractSource::class)
-                ->onlyMethods(['getAllOptions'])
-                ->disableOriginalConstructor()
-                ->getMock();
-            $attrObjectSourceMock
-                ->expects((null === $expectedAttrObjSourceAllOptionsParam) ? $this->never() : $this->once())
-                ->method('getAllOptions')
-                ->with($expectedAttrObjSourceAllOptionsParam)
-                ->willReturn($attrObjectSourceAllOptionsValue);
+            $attributeObjectMock->method('getSource')->willReturn($attrObjectSourceMock);
         }
 
-        $attributeObjectMock = $this->getMockBuilder(Attribute::class)
-            ->addMethods(['getAllOptions'])
-            ->onlyMethods(['usesSource', 'getFrontendInput', 'getSource'])
-            ->disableOriginalConstructor()
-            ->getMock();
         $attributeObjectMock->method('usesSource')->willReturn(true);
         $attributeObjectMock
             ->expects((null === $attributeObjectFrontendInput) ? $this->never() : $this->once())
             ->method('getFrontendInput')
             ->willReturn($attributeObjectFrontendInput);
-        $attributeObjectMock->method('getSource')->willReturn($attrObjectSourceMock);
 
         $entityTypeMock = $this->getMockBuilder(Type::class)
             ->onlyMethods(['getId'])
@@ -456,7 +443,9 @@ public function testPrepareValueOptions(
      */
     private function verifySelectAllOptions(
         array $attrObjectSourceAllOptionsValue,
-        bool $expectedAttrObjSourceAllOptionsParam
+        bool $expectedAttrObjSourceAllOptionsParam,
+        array $options,
+        array $optionsDefault
     ): Table {
         $collectionFactory = $this->getMockBuilder(CollectionFactory::class)
             ->addMethods(
@@ -485,35 +474,23 @@ private function verifySelectAllOptions(
                 ]
             )
             ->disableOriginalConstructor()
-            ->getMockForAbstractClass();
-
-        $attrObjectSourceMock = $this->objectManager->getObject(
-            Table::class,
-            [
-                'attrOptionCollectionFactory' => $collectionFactory,
-                'attrOptionFactory' => $attrOptionFactory
-            ]
-        );
-        $attrObjectSourceMock->setAttribute($abstractAttributeMock);
+            ->getMock();
 
-        $storeManagerMock = $this->getMockForAbstractClass(StoreManagerInterface::class);
-        $storeMock = $this->getMockForAbstractClass(StoreInterface::class);
+        $storeManagerMock = $this->getMockBuilder(StoreManagerInterface::class)->getMock();
+        $storeMock = $this->getMockBuilder(StoreInterface::class)->getMock();
 
-        $this->objectManager->setBackwardCompatibleProperty(
-            $attrObjectSourceMock,
-            'storeManager',
-            $storeManagerMock
-        );
+        $attrObjectSourceMock = new Table($collectionFactory, $attrOptionFactory, $storeManagerMock);
+        $attrObjectSourceMock->setAttribute($abstractAttributeMock);
 
         $storeId = '1';
         $attributeId = '42';
 
-        $abstractAttributeMock->expects($this->any())->method('getStoreId')->willReturn(null);
+        $abstractAttributeMock->expects($this->atLeastOnce())->method('getStoreId')->willReturn(null);
 
-        $storeManagerMock->expects($this->any())->method('getStore')->willReturn($storeMock);
-        $storeMock->expects($this->any())->method('getId')->willReturn($storeId);
+        $storeManagerMock->expects($this->atLeastOnce())->method('getStore')->willReturn($storeMock);
+        $storeMock->expects($this->atLeastOnce())->method('getId')->willReturn($storeId);
 
-        $abstractAttributeMock->expects($this->any())->method('getId')->willReturn($attributeId);
+        $abstractAttributeMock->expects($this->atLeastOnce())->method('getId')->willReturn($attributeId);
 
         $collectionFactory->expects($this->once())
             ->method('create')
@@ -532,8 +509,6 @@ private function verifySelectAllOptions(
         $collectionFactory->expects($this->once())
             ->method('load')
             ->willReturn($attributeOptionCollectionMock);
-        $options = [['value' => '16', 'label' => 'default sv black'], ['value' => '17', 'label' => 'default sv white']];
-        $optionsDefault = [['value' => '16', 'label' => 'black'], ['value' => '17', 'label' => 'white']];
         $attributeOptionCollectionMock->expects($this->any())
             ->method('toOptionArray')
             ->willReturnMap(
@@ -640,6 +615,14 @@ public static function prepareValueOptionsDataProvider()
                     'value7' => 'Label for value 7',
                     'value8' => 'Label for value 8',
                 ],
+                [
+                    ['value' => 'value7', 'label' => 'Label for default sv value 7'],
+                    ['value' => 'value8', 'label' => 'Label for default sv value 8'],
+                ],
+                [
+                    ['value' => 'value7', 'label' => 'Label for value 7'],
+                    ['value' => 'value8', 'label' => 'Label for value 8'],
+                ]
             ],
             [
                 [],
@@ -657,6 +640,14 @@ public static function prepareValueOptionsDataProvider()
                 [
                     'valueA' => 'Label for value A',
                 ],
+                [
+                    ['value' => 'valueA', 'label' => 'Label for default sv value A'],
+                    ['value' => ['array value'], 'label' => 'Label for default sv value B']
+                ],
+                [
+                    ['value' => 'valueA', 'label' => 'Label for value A'],
+                    ['value' => ['array value'], 'label' => 'Label for value B']
+                ],
             ],
             [
                 [],
@@ -678,6 +669,14 @@ public static function prepareValueOptionsDataProvider()
                     '16' => 'black',
                     '17' => 'white'
                 ],
+                [
+                    ['value' => '16', 'label' => 'default sv black'],
+                    ['value' => '17', 'label' => 'default sv white']
+                ],
+                [
+                    ['value' => '16', 'label' => 'black'],
+                    ['value' => '17', 'label' => 'white']
+                ],
             ]
         ];
     }