Merge branch 'ACP2E-1675' of https://github.com/magento-l3/magento2ce into PR2-L3-09132023

Author: chittima

app/code/Magento/Catalog/Setup/Patch/Data/UpdateMultiselectAttributesBackendTypes.php

@@ -9,11 +9,12 @@
 use Magento\Catalog\Model\Product;
 use Magento\Eav\Setup\EavSetup;
 use Magento\Eav\Setup\EavSetupFactory;
-use Magento\Framework\Exception\LocalizedException;
+use Magento\Framework\DB\Adapter\AdapterInterface;
 use Magento\Framework\Setup\ModuleDataSetupInterface;
 use Magento\Framework\Setup\Patch\DataPatchInterface;
+use Magento\Framework\Setup\Patch\NonTransactionableInterface;
 
-class UpdateMultiselectAttributesBackendTypes implements DataPatchInterface
+class UpdateMultiselectAttributesBackendTypes implements DataPatchInterface, NonTransactionableInterface
 {
     /**
      * @var ModuleDataSetupInterface
@@ -24,6 +25,11 @@ class UpdateMultiselectAttributesBackendTypes implements DataPatchInterface
      */
     private $eavSetupFactory;
 
+    /**
+     * @var array
+     */
+    private $triggersRestoreQueries = [];
+
     /**
      * MigrateMultiselectAttributesData constructor.
      * @param ModuleDataSetupInterface $dataSetup
@@ -61,6 +67,7 @@ public function apply()
         $this->dataSetup->startSetup();
         $setup = $this->dataSetup;
         $connection = $setup->getConnection();
+        $this->triggersRestoreQueries = [];
 
         $attributeTable = $setup->getTable('eav_attribute');
         /** @var EavSetup $eavSetup */
@@ -74,26 +81,31 @@ public function apply()
                 ->where('backend_type = ?', 'varchar')
                 ->where('frontend_input = ?', 'multiselect')
         );
+        $attributesToMigrate = array_map('intval', $attributesToMigrate);
 
         $varcharTable = $setup->getTable('catalog_product_entity_varchar');
         $textTable = $setup->getTable('catalog_product_entity_text');
-        $varcharTableDataSql = $connection
-            ->select()
-            ->from($varcharTable)
-            ->where('attribute_id in (?)', $attributesToMigrate);
 
         $columns = $connection->describeTable($varcharTable);
         unset($columns['value_id']);
-        $connection->query(
-            $connection->insertFromSelect(
-                $connection->select()
-                    ->from($varcharTable, array_keys($columns))
-                    ->where('attribute_id in (?)', $attributesToMigrate),
-                $textTable,
-                array_keys($columns)
-            )
-        );
-        $connection->query($connection->deleteFromSelect($varcharTableDataSql, $varcharTable));
+        $this->dropTriggers($textTable);
+        $this->dropTriggers($varcharTable);
+        try {
+            $connection->query(
+                $connection->insertFromSelect(
+                    $connection->select()
+                        ->from($varcharTable, array_keys($columns))
+                        ->where('attribute_id in (?)', $attributesToMigrate, \Zend_Db::INT_TYPE),
+                    $textTable,
+                    array_keys($columns),
+                    AdapterInterface::INSERT_ON_DUPLICATE
+                )
+            );
+            $connection->delete($varcharTable, ['attribute_id IN (?)' => $attributesToMigrate]);
+        } finally {
+            $this->restoreTriggers($textTable);
+            $this->restoreTriggers($varcharTable);
+        }
 
         foreach ($attributesToMigrate as $attributeId) {
             $eavSetup->updateAttribute($entityTypeId, $attributeId, 'backend_type', 'text');
@@ -103,4 +115,48 @@ public function apply()
 
         return $this;
     }
+
+    /**
+     * Drop table triggers
+     *
+     * @param string $tableName
+     * @return void
+     * @throws \Zend_Db_Statement_Exception
+     */
+    private function dropTriggers(string $tableName): void
+    {
+        $triggers = $this->dataSetup->getConnection()
+            ->query('SHOW TRIGGERS LIKE \''. $tableName . '\'')
+            ->fetchAll();
+
+        if (!$triggers) {
+            return;
+        }
+
+        foreach ($triggers as $trigger) {
+            $triggerData = $this->dataSetup->getConnection()
+                ->query('SHOW CREATE TRIGGER '. $trigger['Trigger'])
+                ->fetch();
+            $this->triggersRestoreQueries[$tableName][] =
+                preg_replace('/DEFINER=[^\s]*/', '', $triggerData['SQL Original Statement']);
+            // phpcs:ignore Magento2.SQL.RawQuery.FoundRawSql
+            $this->dataSetup->getConnection()->query('DROP TRIGGER IF EXISTS ' . $trigger['Trigger']);
+        }
+    }
+
+    /**
+     * Restore table triggers.
+     *
+     * @param string $tableName
+     * @return void
+     * @throws \Zend_Db_Statement_Exception
+     */
+    private function restoreTriggers(string $tableName): void
+    {
+        if (array_key_exists($tableName, $this->triggersRestoreQueries)) {
+            foreach ($this->triggersRestoreQueries[$tableName] as $query) {
+                $this->dataSetup->getConnection()->multiQuery($query);
+            }
+        }
+    }
 }

app/code/Magento/Catalog/Test/Unit/Setup/Patch/Data/UpdateMultiselectAttributesBackendTypesTest.php

@@ -52,6 +52,8 @@ public function testApply(): void
         $select1 = $this->createMock(Select::class);
         $select2 = $this->createMock(Select::class);
         $select3 = $this->createMock(Select::class);
+        $statement = $this->createMock(\Zend_Db_Statement_Interface::class);
+
         $this->eavSetupFactory->method('create')
             ->willReturn($eavSetup);
         $this->dataSetup->method('getConnection')
@@ -65,7 +67,7 @@ public function testApply(): void
                 [$entityTypeId, 3, 'backend_type', 'text'],
                 [$entityTypeId, 7, 'backend_type', 'text']
             );
-        $connection->expects($this->exactly(3))
+        $connection->expects($this->exactly(2))
             ->method('select')
             ->willReturnOnConsecutiveCalls($select1, $select2, $select3);
         $connection->method('describeTable')
@@ -78,6 +80,10 @@ public function testApply(): void
                     'row_id' => [],
                 ]
             );
+        $connection->method('query')
+            ->willReturn($statement);
+        $connection->method('fetchAll')
+            ->willReturn([]);
         $connection->method('fetchCol')
             ->with($select1)
             ->willReturn($attributeIds);