ACP2E-1001: Customer Zip Code input validation rule not working

- Adding unit test coverage

Author: Mohan Ahuja

app/code/Magento/Customer/Test/Unit/Model/Metadata/Form/PostcodeTest.php

@@ -7,12 +7,18 @@
 
 namespace Magento\Customer\Test\Unit\Model\Metadata\Form;
 
+use Magento\Customer\Api\Data\ValidationRuleInterface;
 use Magento\Customer\Model\Metadata\Form\Postcode;
 use Magento\Directory\Helper\Data as DirectoryHelper;
+use Magento\Framework\Phrase;
 use PHPUnit\Framework\MockObject\MockObject;
+use Magento\Framework\Stdlib\StringUtils;
 
 class PostcodeTest extends AbstractFormTestCase
 {
+    /** @var StringUtils */
+    protected StringUtils $stringHelper;
+
     /**
      * @var DirectoryHelper|MockObject
      */
@@ -21,7 +27,7 @@ class PostcodeTest extends AbstractFormTestCase
     protected function setUp(): void
     {
         parent::setUp();
-
+        $this->stringHelper = new StringUtils();
         $this->directoryHelper = $this->getMockBuilder(\Magento\Directory\Helper\Data::class)
             ->disableOriginalConstructor()
             ->getMock();
@@ -43,7 +49,8 @@ protected function getClass($value)
             $value,
             0,
             false,
-            $this->directoryHelper
+            $this->directoryHelper,
+            $this->stringHelper
         );
     }
 
@@ -87,4 +94,103 @@ public function validateValueDataProvider()
             ['90034', true, 'IE', true],
         ];
     }
+
+    /**
+     * @param string|int|bool|null $value to assign to boolean
+     * @param string|bool $expected text output
+     * @dataProvider validateValueLengthDataProvider
+     */
+    public function testValidateValueLength($value, $expected)
+    {
+        $minTextLengthRule = $this->getMockBuilder(ValidationRuleInterface::class)
+            ->disableOriginalConstructor()
+            ->setMethods(['getName', 'getValue'])
+            ->getMockForAbstractClass();
+        $minTextLengthRule->expects($this->any())
+            ->method('getName')
+            ->willReturn('min_text_length');
+        $minTextLengthRule->expects($this->any())
+            ->method('getValue')
+            ->willReturn(5);
+
+        $maxTextLengthRule = $this->getMockBuilder(ValidationRuleInterface::class)
+            ->disableOriginalConstructor()
+            ->setMethods(['getName', 'getValue'])
+            ->getMockForAbstractClass();
+        $maxTextLengthRule->expects($this->any())
+            ->method('getName')
+            ->willReturn('max_text_length');
+        $maxTextLengthRule->expects($this->any())
+            ->method('getValue')
+            ->willReturn(6);
+
+        $inputValidationRule = $this->getMockBuilder(ValidationRuleInterface::class)
+            ->disableOriginalConstructor()
+            ->setMethods(['getName', 'getValue'])
+            ->getMockForAbstractClass();
+        $inputValidationRule->expects($this->any())
+            ->method('getName')
+            ->willReturn('input_validation');
+        $inputValidationRule->expects($this->any())
+            ->method('getValue')
+            ->willReturn('numeric');
+
+        $validationRules = [
+            'input_validation' => $inputValidationRule,
+            'min_text_length' => $minTextLengthRule,
+            'max_text_length' => $maxTextLengthRule,
+        ];
+
+        $this->attributeMetadataMock->expects(
+            $this->any()
+        )->method(
+            'getValidationRules'
+        )->willReturn(
+            $validationRules
+        );
+
+        $sut = $this->getClass($value);
+        $actual = $sut->validateValue($value);
+
+        if (is_bool($actual)) {
+            $this->assertEquals($expected, $actual);
+        } else {
+            if (is_array($actual)) {
+                $actual = array_map(function ($message) {
+                    return $message instanceof Phrase ? $message->__toString() : $message;
+                }, $actual);
+            }
+
+            if (is_array($expected)) {
+                foreach ($expected as $key => $row) {
+                    $this->assertEquals($row, $actual[$key]);
+                }
+            } else {
+                $this->assertContains($expected, $actual);
+            }
+        }
+    }
+
+    /**
+     * @return array
+     */
+    public function validateValueLengthDataProvider(): array
+    {
+        return [
+            'false' => [false, ['"" is a required value.', '"" length must be equal or greater than 5 characters.']],
+            'empty' => ['', ['"" is a required value.', '"" length must be equal or greater than 5 characters.']],
+            'null' => [null, ['"" is a required value.', '"" length must be equal or greater than 5 characters.']],
+            'one' => [1, '"" length must be equal or greater than 5 characters.'],
+            'L1' => ['6', '"" length must be equal or greater than 5 characters.'],
+            'L2' => ['66', '"" length must be equal or greater than 5 characters.'],
+            'L5' => ['66666', true],
+            'thousand' => ['10000', true],
+            'L6' => ['666666', true],
+            'L7' => ['6666666', '"" length must be equal or less than 6 characters.'],
+            'S1' => ['s', ['"" length must be equal or greater than 5 characters.', "notDigits" => '"" contains non-numeric characters.']],
+            'S6' => ['string', ["notDigits" => '"" contains non-numeric characters.']],
+            'S7' => ['strings', ['"" length must be equal or less than 6 characters.', "notDigits" => '"" contains non-numeric characters.']],
+            'L6s' => ['66666s', ["notDigits" => '"" contains non-numeric characters.']],
+        ];
+    }
 }