Skip to content

Commit 179f2c6

Browse files
pawan-adobe-securitypawan-adobe-security
committed
Merge branch 'AC-9883' into cia-2.4.7-develop-bugfix-03012024
2 parents acf174f + 53fd107 commit 179f2c6

File tree

4 files changed

+79
-34
lines changed

4 files changed

+79
-34
lines changed

‎app/code/Magento/Config/Model/Config/Backend/File.php‎

Lines changed: 20 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,8 @@
33
* Copyright © Magento, Inc. All rights reserved.
44
* See COPYING.txt for license details.
55
*/
6+
declare(strict_types=1);
7+
68
namespace Magento\Config\Model\Config\Backend;
79

810
use Exception;
@@ -114,7 +116,7 @@ public function beforeSave()
114116
if (is_array($value) && !empty($value['delete'])) {
115117
$this->setValue('');
116118
} elseif (is_array($value) && !empty($value['value'])) {
117-
$this->setValue($value['value']);
119+
$this->setValueAfterValidation($value['value']);
118120
} else {
119121
$this->unsValue();
120122
}
@@ -266,4 +268,21 @@ protected function _getAllowedExtensions()
266268
{
267269
return [];
268270
}
271+
272+
/**
273+
* Validate if the value is intercepted
274+
*
275+
* @param string $value
276+
* @return void
277+
* @throws LocalizedException
278+
*/
279+
private function setValueAfterValidation(string $value): void
280+
{
281+
// avoid intercepting value
282+
if (preg_match('/[^a-z0-9_\/\\-\\.]+/i', $value)) {
283+
throw new LocalizedException(__('Invalid file name'));
284+
}
285+
286+
$this->setValue($value);
287+
}
269288
}

‎app/code/Magento/Config/i18n/en_US.csv‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -122,3 +122,4 @@ Dashboard,Dashboard
122122
"Web Section","Web Section"
123123
"Store Email Addresses Section","Store Email Addresses Section"
124124
"Email to a Friend","Email to a Friend"
125+
"Invalid file name", "Invalid file name"

‎lib/internal/Magento/Framework/Data/Form/Element/Image.php‎

Lines changed: 10 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -71,30 +71,27 @@ public function getElementHtml()
7171
{
7272
$html = '';
7373

74-
if ((string)$this->getValue()) {
74+
if ((string)$this->getEscapedValue()) {
7575
$url = $this->_getUrl();
7676

7777
if (!preg_match("/^http\:\/\/|https\:\/\//", $url)) {
7878
$url = $this->_urlBuilder->getBaseUrl(['_type' => UrlInterface::URL_TYPE_MEDIA]) . $url;
7979
}
8080

8181
$linkId = 'linkId' .$this->random->getRandomString(8);
82-
$html = '<a previewlinkid="' .$linkId .'" href="' .
83-
$url .
84-
'" ' .
82+
$html = '<a previewlinkid="' .$linkId .'" href="' .
83+
$url . '" ' .
8584
$this->_getUiId(
8685
'link'
8786
) .
8887
'>' .
89-
'<img src="' .
90-
$url .
91-
'" id="' .
88+
'<img src="' . $url . '" id="' .
9289
$this->getHtmlId() .
9390
'_image" title="' .
94-
$this->getValue() .
91+
$this->getEscapedValue() .
9592
'"' .
9693
' alt="' .
97-
$this->getValue() .
94+
$this->getEscapedValue() .
9895
'" height="22" width="22" class="small-image-preview v-middle" ' .
9996
$this->_getUiId() .
10097
' />' .
@@ -120,7 +117,7 @@ public function getElementHtml()
120117
protected function _getDeleteCheckbox()
121118
{
122119
$html = '';
123-
if ($this->getValue()) {
120+
if ($this->getEscapedValue()) {
124121
$label = (string)new \Magento\Framework\Phrase('Delete Image');
125122
$html .= '<span class="delete-image">';
126123
$html .= '<input type="checkbox"' .
@@ -153,7 +150,8 @@ protected function _getDeleteCheckbox()
153150
*/
154151
protected function _getHiddenInput()
155152
{
156-
return '<input type="hidden" name="' . parent::getName() . '[value]" value="' . $this->getValue() . '" />';
153+
return '<input type="hidden" name="' . parent::getName() .
154+
'[value]" value="' . $this->getEscapedValue() . '" />';
157155
}
158156

159157
/**
@@ -163,7 +161,7 @@ protected function _getHiddenInput()
163161
*/
164162
protected function _getUrl()
165163
{
166-
return $this->getValue();
164+
return $this->getEscapedValue();
167165
}
168166

169167
/**

‎lib/internal/Magento/Framework/Data/Test/Unit/Form/Element/ImageTest.php‎

Lines changed: 48 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -15,12 +15,13 @@
1515
use Magento\Framework\Data\Form\Element\Image;
1616
use Magento\Framework\DataObject;
1717
use Magento\Framework\Escaper;
18+
use Magento\Framework\Math\Random;
19+
use Magento\Framework\TestFramework\Unit\Helper\ObjectManager;
1820
use Magento\Framework\Url;
19-
use Magento\Framework\UrlInterface;
21+
use Magento\Framework\View\Helper\SecureHtmlRenderer;
2022
use PHPUnit\Framework\MockObject\MockObject;
2123
use PHPUnit\Framework\TestCase;
22-
use Magento\Framework\Math\Random;
23-
use Magento\Framework\View\Helper\SecureHtmlRenderer;
24+
use Magento\Framework\UrlInterface;
2425

2526
/**
2627
* Test for the widget.
@@ -44,11 +45,16 @@ class ImageTest extends TestCase
4445
*/
4546
protected $_image;
4647

48+
/**
49+
* @var array
50+
*/
51+
protected $testData;
52+
4753
protected function setUp(): void
4854
{
55+
$objectManager = new ObjectManager($this);
4956
$factoryMock = $this->createMock(Factory::class);
5057
$collectionFactoryMock = $this->createMock(CollectionFactory::class);
51-
$escaperMock = $this->createMock(Escaper::class);
5258
$this->urlBuilder = $this->createMock(Url::class);
5359
$randomMock = $this->createMock(Random::class);
5460
$randomMock->method('getRandomString')->willReturn('some-rando-string');
@@ -67,18 +73,28 @@ function (string $tag, array $attrs, ?string $content): string {
6773
return "<$tag {$attrs->serialize()}>$content</$tag>";
6874
}
6975
);
70-
$this->_image = new Image(
71-
$factoryMock,
72-
$collectionFactoryMock,
73-
$escaperMock,
74-
$this->urlBuilder,
75-
[],
76-
$secureRendererMock,
77-
$randomMock
76+
$this->_image = $objectManager->getObject(
77+
Image::class,
78+
[
79+
'factoryMock'=>$factoryMock,
80+
'collectionFactoryMock'=>$collectionFactoryMock,
81+
'urlBuilder' => $this->urlBuilder,
82+
'_escaper' => $objectManager->getObject(Escaper::class),
83+
'random' => $randomMock,
84+
'secureRenderer' => $secureRendererMock,
85+
]
7886
);
87+
$this->testData = [
88+
'html_id_prefix' => 'test_id_prefix_',
89+
'html_id' => 'test_id',
90+
'html_id_suffix' => '_test_id_suffix',
91+
'path' => 'catalog/product/placeholder',
92+
'value' => 'test_value',
93+
];
94+
7995
$formMock = new DataObject();
80-
$formMock->getHtmlIdPrefix('id_prefix');
81-
$formMock->getHtmlIdPrefix('id_suffix');
96+
$formMock->getHtmlIdPrefix($this->testData['html_id_prefix']);
97+
$formMock->getHtmlIdPrefix($this->testData['html_id_suffix']);
8298
$this->_image->setForm($formMock);
8399
}
84100

@@ -117,21 +133,32 @@ public function testGetElementHtmlWithoutValue()
117133
*/
118134
public function testGetElementHtmlWithValue()
119135
{
120-
$this->_image->setValue('test_value');
121-
$this->urlBuilder->expects($this->once())
122-
->method('getBaseUrl')
123-
->with(['_type' => UrlInterface::URL_TYPE_MEDIA])
124-
->willReturn('http://localhost/media/');
136+
$url = 'http://test.example.com/media/';
137+
138+
$this->_image->setValue($this->testData['value']);
139+
$this->_image->setHtmlId($this->testData['html_id']);
140+
141+
$this->urlBuilder->expects($this->once())->method('getBaseUrl')
142+
->with(['_type' => UrlInterface::URL_TYPE_MEDIA])->willReturn($url);
143+
144+
$expectedHtmlId = $this->testData['html_id'];
145+
125146
$html = $this->_image->getElementHtml();
147+
126148
$this->assertStringContainsString('class="input-file"', $html);
127149
$this->assertStringContainsString('<input', $html);
128150
$this->assertStringContainsString('type="file"', $html);
129151
$this->assertStringContainsString('value="test_value"', $html);
152+
130153
$this->assertStringContainsString(
131-
'<a previewlinkid="linkIdsome-rando-string" href="http://localhost/media/test_value"',
154+
'<a previewlinkid="linkIdsome-rando-string" href="'
155+
. $url
156+
. $this->testData['value']
157+
. '"',
132158
$html
133159
);
134-
$this->assertStringContainsString("imagePreview('_image');\nreturn false;", $html);
160+
161+
$this->assertStringContainsString("imagePreview('{$expectedHtmlId}_image');\nreturn false;", $html);
135162
$this->assertStringContainsString('<input type="checkbox"', $html);
136163
}
137164
}

0 commit comments

Comments
 (0)