MC-22982: Enable template filter strict mode by default

nathanjosiah · nathanjosiah · commit 1790ba503a75 · 2020-01-24T09:06:55.000-06:00
diff --git a/app/code/Magento/Customer/Block/Address/Renderer/DefaultRenderer.php b/app/code/Magento/Customer/Block/Address/Renderer/DefaultRenderer.php
@@ -167,7 +167,7 @@ public function renderArray($addressAttributes, $format = null)
                     $addressAttributes['country_id']
                 )->getName();
             } elseif ($attributeCode == 'region' && isset($addressAttributes['region'])) {
-                $data['region'] = __($addressAttributes['region']);
+                $data['region'] = (string)__($addressAttributes['region']);
             } elseif (isset($addressAttributes[$attributeCode])) {
                 $value = $addressAttributes[$attributeCode];
                 $dataModel = $this->_elementFactory->create($attributeMetadata, $value, 'customer_address');
diff --git a/dev/tests/integration/testsuite/Magento/Framework/Filter/DirectiveProcessor/SimpleDirectiveTest.php b/dev/tests/integration/testsuite/Magento/Framework/Filter/DirectiveProcessor/SimpleDirectiveTest.php
@@ -74,6 +74,7 @@ public function testDefaultFiltersAreUsed()
     public function testParametersAreParsed()
     {
         $filter = $this->objectManager->create(Template::class);
+        $filter->setStrictMode(false);
 
         $processor = $this->createWithProcessorsAndFilters(
             ['mydir' => $this->objectManager->create(MyDirProcessor::class)],

Original file line number	Diff line number	Diff line change
`@@ -74,6 +74,7 @@ public function testDefaultFiltersAreUsed()`
`74`	`74`	`public function testParametersAreParsed()`
`75`	`75`	`{`
`76`	`76`	`$filter = $this->objectManager->create(Template::class);`
	`77`	`+ $filter->setStrictMode(false);`
`77`	`78`
`78`	`79`	`$processor = $this->createWithProcessorsAndFilters(`
`79`	`80`	`['mydir' => $this->objectManager->create(MyDirProcessor::class)],`