Make method signature consistent with interface

kassner · web-flow · commit 16b1bf115a18 · 2021-02-03T09:41:50.000+01:00
diff --git a/app/code/Magento/Eav/Model/AttributeManagement.php b/app/code/Magento/Eav/Model/AttributeManagement.php
@@ -173,11 +173,11 @@ public function unassign($attributeSetId, $attributeCode)
     /**
      * {@inheritdoc}
      */
-    public function getAttributes($entityType, $attributeSetId)
+    public function getAttributes($entityTypeCode, $attributeSetId)
     {
         /** @var \Magento\Eav\Api\Data\AttributeSetInterface $attributeSet */
         $attributeSet = $this->setRepository->get($attributeSetId);
-        $requiredEntityTypeId = $this->eavConfig->getEntityType($entityType)->getId();
+        $requiredEntityTypeId = $this->eavConfig->getEntityType($entityTypeCode)->getId();
         if (!$attributeSet->getAttributeSetId() || $attributeSet->getEntityTypeId() != $requiredEntityTypeId) {
             throw NoSuchEntityException::singleField('attributeSetId', $attributeSetId);
         }

Original file line number	Diff line number	Diff line change
`@@ -173,11 +173,11 @@ public function unassign($attributeSetId, $attributeCode)`
`173`	`173`	`/**`
`174`	`174`	`* {@inheritdoc}`
`175`	`175`	`*/`
`176`		`- public function getAttributes($entityType, $attributeSetId)`
	`176`	`+ public function getAttributes($entityTypeCode, $attributeSetId)`
`177`	`177`	`{`
`178`	`178`	`/** @var \Magento\Eav\Api\Data\AttributeSetInterface $attributeSet */`
`179`	`179`	`$attributeSet = $this->setRepository->get($attributeSetId);`
`180`		`- $requiredEntityTypeId = $this->eavConfig->getEntityType($entityType)->getId();`
	`180`	`+ $requiredEntityTypeId = $this->eavConfig->getEntityType($entityTypeCode)->getId();`
`181`	`181`	`if (!$attributeSet->getAttributeSetId() \|\| $attributeSet->getEntityTypeId() != $requiredEntityTypeId) {`
`182`	`182`	`throw NoSuchEntityException::singleField('attributeSetId', $attributeSetId);`
`183`	`183`	`}`