AC-15461:Migration New Relic from REST v2 to NerdGraph (GraphQL)

Author: sandesh-as

app/code/Magento/NewRelicReporting/Console/Command/DeployMarker.php

@@ -65,8 +65,8 @@ protected function configure()
                 'Deploy Message / Description'
             )
             ->addArgument(
-                'changelog',
-                InputArgument::OPTIONAL,
+                'change_log',
+                InputArgument::REQUIRED,
                 'Change Log?'
             )
             ->addArgument(
@@ -112,7 +112,7 @@ protected function execute(InputInterface $input, OutputInterface $output): int
         try {
             $result = $this->deploymentsFactory->create()->setDeployment(
                 $input->getArgument('message'),
-                $input->getArgument('changelog') ?: false,
+                $input->getArgument('change_log') ?: false,
                 $this->serviceShellUser->get($input->getArgument('user')) ?: false,
                 $input->getArgument('revision'),
                 $input->getOption('commit'),

app/code/Magento/NewRelicReporting/Test/Unit/Console/Command/DeployMarkerTest.php

@@ -103,8 +103,8 @@ public function testConfigure()
         $this->assertTrue($definition->getArgument('message')->isRequired());
 
         // Check optional arguments
-        $this->assertTrue($definition->hasArgument('changelog'));
-        $this->assertFalse($definition->getArgument('changelog')->isRequired());
+        $this->assertTrue($definition->hasArgument('change_log'));
+        $this->assertTrue($definition->getArgument('change_log')->isRequired());
 
         $this->assertTrue($definition->hasArgument('user'));
         $this->assertFalse($definition->getArgument('user')->isRequired());
@@ -194,7 +194,7 @@ public function testExecuteSuccessWithArrayResultNerdGraphStyle()
 
         $this->mockArguments([
             ['message', $message],
-            ['changelog', 'New features'],
+            ['change_log', 'New features'],
             ['user', $user],
             ['revision', $revision]
         ], [
@@ -465,7 +465,7 @@ public function testExecuteSuccessWithCompleteDeploymentDataNerdGraphStyle()
 
         $this->mockArguments([
             ['message', $message],
-            ['changelog', 'Added new features'],
+            ['change_log', 'Added new features'],
             ['user', 'complete-user'],
             ['revision', 'v2.0.0']
         ], [
@@ -587,7 +587,7 @@ public function testCommandArgumentValidation()
         $this->assertEquals('Deploy Message / Description', $messageArg->getDescription());
 
         // Verify optional arguments exist
-        $this->assertTrue($definition->hasArgument('changelog'));
+        $this->assertTrue($definition->hasArgument('change_log'));
         $this->assertTrue($definition->hasArgument('user'));
         $this->assertTrue($definition->hasArgument('revision'));
 

dev/tests/integration/testsuite/Magento/NewRelicReporting/Console/Command/DeployMarkerCommandTest.php

@@ -53,7 +53,7 @@ protected function setUp(): void
     public function testCommandWithMissingArgument()
     {
         $this->expectException(RuntimeException::class);
-        $this->expectExceptionMessage('Not enough arguments (missing: "message")');
+        $this->expectExceptionMessage('Not enough arguments (missing: "message, change_log")');
 
         $this->commandTester->execute([]);
     }
@@ -66,7 +66,8 @@ public function testCommandWithMissingArgument()
     public function testCommandWithDisabledNewRelic()
     {
         $exitCode = $this->commandTester->execute([
-            'message' => 'Test deployment'
+            'message' => 'Test deployment',
+            'change_log' => 'Test changelog'
         ]);
 
         $this->assertEquals(1, $exitCode);
@@ -88,7 +89,8 @@ public function testCommandWithDisabledNewRelic()
     public function testCommandWithMinimalArgumentsV2Rest()
     {
         $exitCode = $this->commandTester->execute([
-            'message' => 'Test deployment message'
+            'message' => 'Test deployment message',
+            'change_log' => 'Test changelog'
         ]);
 
         $this->assertTrue(
@@ -133,7 +135,7 @@ public function testCommandConfiguration()
         $this->assertTrue($messageArg->isRequired());
 
         // Verify optional arguments
-        $this->assertTrue($definition->hasArgument('changelog'));
+        $this->assertTrue($definition->hasArgument('change_log'));
         $this->assertTrue($definition->hasArgument('user'));
         $this->assertTrue($definition->hasArgument('revision'));
 
@@ -156,7 +158,7 @@ public function testCommandWithAllParametersNerdGraph()
     {
         $exitCode = $this->commandTester->execute([
             'message' => 'Full deployment test',
-            'changelog' => 'Added new features',
+            'change_log' => 'Added new features',
             'user' => 'deploy-user',
             'revision' => 'v2.0.0',
             '--commit' => 'abc123',
@@ -188,7 +190,8 @@ public function testCommandWithAllParametersNerdGraph()
     public function testCommandWithEmptyMessage()
     {
         $exitCode = $this->commandTester->execute([
-            'message' => ''
+            'message' => '',
+            "change_log" => "Test changelog"
         ]);
 
         $this->assertIsInt($exitCode);
@@ -235,7 +238,8 @@ public function testCommandHelpOption()
     public function testV2RestDoesNotShowNerdGraphDetails()
     {
         $exitCode = $this->commandTester->execute([
-            'message' => 'v2 rest test'
+            'message' => 'v2 rest test',
+            'change_log' => 'Test changelog'
         ]);
 
         $this->assertTrue(in_array($exitCode, [0, 1], true));
@@ -252,7 +256,8 @@ public function testV2RestDoesNotShowNerdGraphDetails()
     public function testV2RestMisconfiguredFailsGracefully()
     {
         $exitCode = $this->commandTester->execute([
-            'message' => 'misconfig v2'
+            'message' => 'misconfig v2',
+            'change_log' => 'Test changelog'
         ]);
 
         $this->assertEquals(1, $exitCode);
@@ -270,7 +275,8 @@ public function testV2RestMisconfiguredFailsGracefully()
     public function testNerdGraphMisconfiguredFailsGracefully()
     {
         $exitCode = $this->commandTester->execute([
-            'message' => 'misconfig nerdgraph'
+            'message' => 'misconfig nerdgraph',
+            'change_log' => 'Test changelog'
         ]);
 
         $this->assertEquals(1, $exitCode);