B2B-2094: [AWS S3] Failed to load gift card order print page

Author: danmooney2

app/code/Magento/Checkout/Test/Mftf/Test/CheckCheckoutSuccessPageTest/CheckCheckoutSuccessPageAsRegisterCustomerTest.xml

@@ -137,7 +137,7 @@
 
         <!-- See print page -->
         <click selector="{{CheckoutSuccessMainSection.printLink}}" stepKey="clickPrintLink"/>
-        <helper class="Magento\Ui\Test\Mftf\Helper\UiHelper" method="switchToWindowWithUrlAndClosePrintDialogIfEncountered" stepKey="switchToWindowWithUrlAndClosePrintDialogIfEncountered">
+        <helper class="Magento\Sales\Test\Mftf\Helper\SalesHelper" method="switchToWindowWithUrlAndClosePrintDialogIfEncountered" stepKey="switchToWindowWithUrlAndClosePrintDialogIfEncountered">
             <argument name="expectedUrl">sales/order/print/order_id/</argument>
             <argument name="expectedUrlComparisonType">COMPARISON_PATH_SUBSET_MATCH</argument>
         </helper>

app/code/Magento/Ui/Test/Mftf/Helper/UiHelper.php renamed to app/code/Magento/Sales/Test/Mftf/Helper/SalesHelper.php

@@ -5,16 +5,16 @@
  */
 declare(strict_types=1);
 
-namespace Magento\Ui\Test\Mftf\Helper;
+namespace Magento\Sales\Test\Mftf\Helper;
 
 use Facebook\WebDriver\Remote\RemoteWebDriver;
 use Magento\FunctionalTestingFramework\Helper\Helper;
 use Facebook\WebDriver\Exception\NoSuchWindowException;
 
 /**
- * Class for MFTF helpers for Ui module.
+ * Class for MFTF helpers for Sales module.
  */
-class UiHelper extends Helper
+class SalesHelper extends Helper
 {
     private const COMPARISON_PATH_EXACT_MATCH = 'COMPARISON_PATH_EXACT_MATCH';
     private const COMPARISON_PATH_SUBSET_MATCH = 'COMPARISON_PATH_SUBSET_MATCH';
@@ -24,6 +24,14 @@ class UiHelper extends Helper
         self::COMPARISON_PATH_SUBSET_MATCH
     ];
 
+    /**
+     * Iterate through all available window handles and attach webdriver to window matching $expectedUrl.
+     * If print dialog is found, close it to prevent selenium from hanging and becoming unresponsive.
+     *
+     * @param string $expectedUrl
+     * @param string $expectedUrlComparisonType
+     * @throws \Codeception\Exception\ModuleException
+     */
     public function switchToWindowWithUrlAndClosePrintDialogIfEncountered(
         string $expectedUrl,
         string $expectedUrlComparisonType

app/code/Magento/Sales/Test/Mftf/Test/StorefrontPrintOrderGuestTest.xml

@@ -267,7 +267,7 @@
 
         <!--  Click on the "Print Order" button -->
         <click selector="{{StorefrontGuestOrderViewSection.printOrder}}" stepKey="printOrder"/>
-        <helper class="Magento\Ui\Test\Mftf\Helper\UiHelper" method="switchToWindowWithUrlAndClosePrintDialogIfEncountered" stepKey="switchToWindowWithUrlAndClosePrintDialogIfEncountered">
+        <helper class="Magento\Sales\Test\Mftf\Helper\SalesHelper" method="switchToWindowWithUrlAndClosePrintDialogIfEncountered" stepKey="switchToWindowWithUrlAndClosePrintDialogIfEncountered">
             <argument name="expectedUrl">sales/guest/print/order_id/</argument>
             <argument name="expectedUrlComparisonType">COMPARISON_PATH_SUBSET_MATCH</argument>
         </helper>

app/code/Magento/Sales/Test/Mftf/Test/StorefrontRedirectToOrderHistoryTest.xml

@@ -48,7 +48,7 @@
         <grabFromCurrentUrl regex="~/order_id/(\d+)/~" stepKey="grabOrderIdFromURL"/>
         <comment userInput="BIC workaround" stepKey="waitForPrintWindowToOpen"/>
 
-        <helper class="Magento\Ui\Test\Mftf\Helper\UiHelper" method="switchToWindowWithUrlAndClosePrintDialogIfEncountered" stepKey="switchToWindowWithUrlAndClosePrintDialogIfEncountered">
+        <helper class="Magento\Sales\Test\Mftf\Helper\SalesHelper" method="switchToWindowWithUrlAndClosePrintDialogIfEncountered" stepKey="switchToWindowWithUrlAndClosePrintDialogIfEncountered">
             <argument name="expectedUrl">sales/order/print/order_id/{$grabOrderIdFromURL}</argument>
             <argument name="expectedUrlComparisonType">COMPARISON_PATH_SUBSET_MATCH</argument>
         </helper>
@@ -85,7 +85,7 @@
         </actionGroup>
 
         <comment userInput="Step key preserved for backwards compatibility" stepKey="waitForPrintWindowToOpen2" />
-        <helper class="Magento\Ui\Test\Mftf\Helper\UiHelper" method="switchToWindowWithUrlAndClosePrintDialogIfEncountered" stepKey="switchToWindowWithUrlAndClosePrintDialogIfEncountered2">
+        <helper class="Magento\Sales\Test\Mftf\Helper\SalesHelper" method="switchToWindowWithUrlAndClosePrintDialogIfEncountered" stepKey="switchToWindowWithUrlAndClosePrintDialogIfEncountered2">
             <argument name="expectedUrl">sales/order/print/order_id/</argument>
             <argument name="expectedUrlComparisonType">COMPARISON_PATH_SUBSET_MATCH</argument>
         </helper>