MC-38197: [Magento Cloud] Error when updating carts - fatal error Call to a member function getValue() on null in module-configurable-product CartItemProcessor.php

Author: yelahin-serhiy

app/code/Magento/ConfigurableProduct/Model/Quote/Item/CartItemProcessor.php

@@ -82,31 +82,34 @@ public function convertToBuyRequest(CartItemInterface $cartItem)
      */
     public function processOptions(CartItemInterface $cartItem)
     {
-        $attributesOption = $cartItem->getProduct()->getCustomOption('attributes');
-        $selectedConfigurableOptions = $this->serializer->unserialize($attributesOption->getValue());
+        $attributesOption = $cartItem->getProduct()
+            ->getCustomOption('attributes');
+        if ($attributesOption) {
+            $selectedConfigurableOptions = $this->serializer->unserialize($attributesOption->getValue());
 
-        if (is_array($selectedConfigurableOptions)) {
-            $configurableOptions = [];
-            foreach ($selectedConfigurableOptions as $optionId => $optionValue) {
-                /** @var \Magento\ConfigurableProduct\Api\Data\ConfigurableItemOptionValueInterface $option */
-                $option = $this->itemOptionValueFactory->create();
-                $option->setOptionId($optionId);
-                $option->setOptionValue($optionValue);
-                $configurableOptions[] = $option;
-            }
+            if (is_array($selectedConfigurableOptions)) {
+                $configurableOptions = [];
+                foreach ($selectedConfigurableOptions as $optionId => $optionValue) {
+                    /** @var \Magento\ConfigurableProduct\Api\Data\ConfigurableItemOptionValueInterface $option */
+                    $option = $this->itemOptionValueFactory->create();
+                    $option->setOptionId($optionId);
+                    $option->setOptionValue($optionValue);
+                    $configurableOptions[] = $option;
+                }
 
-            $productOption = $cartItem->getProductOption()
-                ? $cartItem->getProductOption()
-                : $this->productOptionFactory->create();
+                $productOption = $cartItem->getProductOption()
+                    ? $cartItem->getProductOption()
+                    : $this->productOptionFactory->create();
 
-            /** @var  \Magento\Quote\Api\Data\ProductOptionExtensionInterface $extensibleAttribute */
-            $extensibleAttribute =  $productOption->getExtensionAttributes()
-                ? $productOption->getExtensionAttributes()
-                : $this->extensionFactory->create();
+                /** @var  \Magento\Quote\Api\Data\ProductOptionExtensionInterface $extensibleAttribute */
+                $extensibleAttribute = $productOption->getExtensionAttributes()
+                    ? $productOption->getExtensionAttributes()
+                    : $this->extensionFactory->create();
 
-            $extensibleAttribute->setConfigurableItemOptions($configurableOptions);
-            $productOption->setExtensionAttributes($extensibleAttribute);
-            $cartItem->setProductOption($productOption);
+                $extensibleAttribute->setConfigurableItemOptions($configurableOptions);
+                $productOption->setExtensionAttributes($extensibleAttribute);
+                $cartItem->setProductOption($productOption);
+            }
         }
         return $cartItem;
     }

app/code/Magento/ConfigurableProduct/Test/Unit/Model/Quote/Item/CartItemProcessorTest.php

@@ -59,7 +59,7 @@ class CartItemProcessorTest extends TestCase
      */
     private $productOptionExtensionAttributes;
 
-    /** @var \PHPUnit\Framework\MockObject\MockObject */
+    /** @var MockObject */
     private $serializer;
 
     protected function setUp(): void
@@ -263,4 +263,25 @@ public function testProcessProductOptionsIfOptionsExist()
 
         $this->assertEquals($cartItemMock, $this->model->processOptions($cartItemMock));
     }
+
+    /**
+     * Checks processOptions method with the empty custom option
+     *
+     * @return void
+     */
+    public function testProcessProductWithEmptyOption(): void
+    {
+        $customOption = $this->createMock(Option::class);
+        $productMock = $this->createMock(Product::class);
+        $productMock->method('getCustomOption')
+            ->with('attributes')
+            ->willReturn(null);
+        $customOption->expects($this->never())
+            ->method('getValue');
+        $cartItemMock = $this->createPartialMock(Item::class, ['getProduct']);
+        $cartItemMock->expects($this->once())
+            ->method('getProduct')
+            ->willReturn($productMock);
+        $this->assertEquals($cartItemMock, $this->model->processOptions($cartItemMock));
+    }
 }