MC-17592: End-to-end integration to test order with Payflow Link

- addressing review comments

Author: dthampy

dev/tests/integration/testsuite/Magento/Paypal/_files/order_payflow_link_with_payment_rollback.php

@@ -5,14 +5,18 @@
  */
 
 use Magento\TestFramework\Helper\Bootstrap;
+use Magento\Sales\Model\ResourceModel\Order\Collection;
+use Magento\Framework\Registry;
+
+$objectManager = Bootstrap::getObjectManager();
 
 /** @var \Magento\Framework\Registry $registry */
-$registry = Bootstrap::getObjectManager()->get(\Magento\Framework\Registry::class);
+$registry = Bootstrap::getObjectManager()->get(Registry::class);
 $registry->unregister('isSecureArea');
 $registry->register('isSecureArea', true);
 
 /** @var $order \Magento\Sales\Model\Order */
-$orderCollection = Bootstrap::getObjectManager()->create(\Magento\Sales\Model\ResourceModel\Order\Collection::class);
+$orderCollection = $objectManager->create(Collection::class);
 foreach ($orderCollection as $order) {
     $order->delete();
 }

dev/tests/integration/testsuite/Magento/PaypalGraphQl/Model/Resolver/Guest/GetPayflowLinkTokenTest.php

@@ -17,6 +17,7 @@
 use Magento\TestFramework\Helper\Bootstrap;
 use Magento\TestFramework\ObjectManager;
 use PHPUnit\Framework\TestCase;
+use Zend\Http\Headers;
 
 /**
  * Test getPayflowLinkToken graphql endpoint for non-registered customer
@@ -47,7 +48,6 @@ class GetPayflowLinkTokenTest extends TestCase
 
     protected function setUp()
     {
-        parent::setUp();
         $this->objectManager = Bootstrap::getObjectManager();
         $this->getMaskedQuoteIdByReservedOrderId = $this->objectManager->get(GetMaskedQuoteIdByReservedOrderId::class);
         $this->graphqlController = $this->objectManager->get(GraphQl::class);
@@ -74,8 +74,8 @@ public function testResolvePayflowLinkToken() : void
  {
    getPayflowLinkToken(input: {cart_id:"$cartId"})
    {
-       secret_token
-       secret_token_id
+       secure_token
+       secure_token_id
        mode
        paypal_url
   }
@@ -86,7 +86,7 @@ public function testResolvePayflowLinkToken() : void
         $this->request->setPathInfo('/graphql');
         $this->request->setMethod('POST');
         $this->request->setContent($postData);
-        $headers = $this->objectManager->create(\Zend\Http\Headers::class)
+        $headers = $this->objectManager->create(Headers::class)
             ->addHeaders(['Content-Type' => 'application/json']);
         $this->request->setHeaders($headers);
         $response = $this->graphqlController->dispatch($this->request);
@@ -96,8 +96,8 @@ public function testResolvePayflowLinkToken() : void
 
         $payflowLinkTokenResponse = $responseData['data']['getPayflowLinkToken'];
 
-        $this->assertArrayHasKey('secret_token', $payflowLinkTokenResponse);
-        $this->assertArrayHasKey('secret_token_id', $payflowLinkTokenResponse);
+        $this->assertArrayHasKey('secure_token', $payflowLinkTokenResponse);
+        $this->assertArrayHasKey('secure_token_id', $payflowLinkTokenResponse);
 
         $this->assertEquals('TEST', $payflowLinkTokenResponse['mode']);
         $this->assertEquals('https://pilot-payflowlink.paypal.com', $payflowLinkTokenResponse['paypal_url']);

dev/tests/integration/testsuite/Magento/PaypalGraphQl/Model/Resolver/Guest/PlaceOrderWithPayflowLinkTest.php

@@ -23,6 +23,7 @@
 use Magento\TestFramework\ObjectManager;
 use PHPUnit\Framework\MockObject\MockObject;
 use PHPUnit\Framework\TestCase;
+use Zend\Http\Headers;
 
 /**
  * End to end place order test using payflow_link via graphql endpoint for guest
@@ -78,7 +79,21 @@ protected function setUp()
 
         $this->payflowRequest = $this->getMockBuilder(\Magento\Paypal\Model\Payflow\Request::class)
             ->disableOriginalConstructor()
+            ->setMethods(['__call','setData'])
             ->getMock();
+        $this->payflowRequest->expects($this->any())
+            ->method('__call')
+            ->will(
+                $this->returnCallback(
+                    function ($method) {
+                        if (strpos($method, 'set') === 0) {
+                            return $this->payflowRequest;
+                        }
+                        return null;
+                    }
+                )
+            );
+
         $requestFactory->expects($this->any())->method('create')->will($this->returnValue($this->payflowRequest));
         $this->objectManager->addSharedInstance($this->gateway, Gateway::class);
     }
@@ -161,7 +176,7 @@ public function testResolvePlaceOrderWithPayflowLink(): void
             ->method('postRequest')
             ->willReturn($payflowLinkResponse);
 
-        $this->payflowRequest->expects($this->any())
+        $this->payflowRequest
             ->method('setData')
             ->willReturnMap(
                 [
@@ -177,7 +192,7 @@ public function testResolvePlaceOrderWithPayflowLink(): void
                     $this->returnSelf()
                 ],
                 ['USER1', 1, $this->returnSelf()],
-                ['USER2', '4b102efb018ad34bacea669f401fc8cb', $this->returnSelf()]
+                ['USER2', 'USER2SilentPostHash', $this->returnSelf()]
             );
 
         $response = $this->graphqlController->dispatch($this->request);
@@ -260,13 +275,13 @@ public function testResolveWithPayflowLinkDeclined(): void
         $this->request->setPathInfo('/graphql');
         $this->request->setMethod('POST');
         $this->request->setContent($postData);
-        $headers = $this->objectManager->create(\Zend\Http\Headers::class)
+        $headers = $this->objectManager->create(Headers::class)
             ->addHeaders(['Content-Type' => 'application/json']);
         $this->request->setHeaders($headers);
 
         $resultCode = Payflowlink::RESPONSE_CODE_DECLINED_BY_FILTER;
         $exception = new LocalizedException(__('Declined response message from PayPal gateway'));
-         $this->payflowRequest->expects($this->any())
+         $this->payflowRequest
             ->method('setData')
             ->with(
                 [
@@ -280,7 +295,7 @@ public function testResolveWithPayflowLinkDeclined(): void
 
                     ]
                 ]
-            );
+            )->willReturnSelf();
         $this->gateway->method('postRequest')
             /** @var DataObject $linkRequest */
             ->with(

dev/tests/integration/testsuite/Magento/PaypalGraphQl/Model/Resolver/Guest/SetPaymentMethodAsPayflowLinkTest.php

@@ -43,7 +43,7 @@ class SetPaymentMethodAsPayflowLinkTest extends TestCase
     protected $objectManager;
 
     /** @var  GraphQl */
-    protected $graphqlController;
+    private $graphqlController;
 
     protected function setUp()
     {
@@ -77,9 +77,6 @@ public function testSetPayflowLinkAsPaymentMethod(): void
         $paymentMethod = 'payflow_link';
         $cartId = $this->getMaskedQuoteIdByReservedOrderId->execute('test_quote');
 
-        $url = $this->objectManager->get(UrlInterface::class);
-        $baseUrl = $url->getBaseUrl();
-
         $query
             = <<<QUERY
  mutation {