AC-15208: Attribute Option Label Gets Overwritten When Updating Store Labels

Added WebAPI test coverage for the change

Author: sumesh-GL

dev/tests/api-functional/testsuite/Magento/Catalog/Api/ProductAttributeOptionUpdateInterfaceTest.php

@@ -1,13 +1,23 @@
 <?php
 /**
- * Copyright © Magento, Inc. All rights reserved.
- * See COPYING.txt for license details.
+ * Copyright 2020 Adobe.
+ * All Rights Reserved.
  */
+
 namespace Magento\Catalog\Api;
 
+use Magento\Catalog\Test\Fixture\SelectAttribute as SelectAttributeFixture;
 use Magento\Eav\Api\Data\AttributeOptionInterface;
 use Magento\Eav\Api\Data\AttributeOptionLabelInterface;
 use Magento\Framework\Webapi\Rest\Request;
+use Magento\Store\Test\Fixture\Group as StoreGroupFixture;
+use Magento\Store\Test\Fixture\Store as StoreFixture;
+use Magento\Store\Test\Fixture\Website as WebsiteFixture;
+use Magento\TestFramework\Fixture\DataFixture;
+use Magento\TestFramework\Fixture\DataFixtureStorage;
+use Magento\TestFramework\Fixture\DataFixtureStorageManager;
+use Magento\TestFramework\Helper\Bootstrap;
+use Magento\TestFramework\ObjectManager;
 use Magento\TestFramework\TestCase\WebapiAbstract;
 
 /**
@@ -20,6 +30,26 @@ class ProductAttributeOptionUpdateInterfaceTest extends WebapiAbstract
     private const SERVICE_VERSION = 'V1';
     private const RESOURCE_PATH = '/V1/products/attributes';
 
+    /**
+     * @var ObjectManager
+     */
+    private $objectManager;
+
+    /**
+     * @var DataFixtureStorage
+     */
+    private $fixtures;
+
+    /**
+     * @inheritdoc
+     */
+    protected function setUp(): void
+    {
+        parent::setUp();
+        $this->objectManager = Bootstrap::getObjectManager();
+        $this->fixtures = $this->objectManager->get(DataFixtureStorageManager::class)->getStorage();
+    }
+
     /**
      * Test to update attribute option
      *
@@ -67,6 +97,114 @@ public function testUpdate()
         }
     }
 
+    #[
+        DataFixture(WebsiteFixture::class, as: 'website'),
+        DataFixture(StoreGroupFixture::class, ['website_id' => '$website.id$'], 'store_group'),
+        DataFixture(StoreFixture::class, ['store_group_id' => '$store_group.id$'], 'store1'),
+        DataFixture(StoreFixture::class, ['store_group_id' => '$store_group.id$'], 'store2'),
+        DataFixture(SelectAttributeFixture::class, ['default_frontend_label' => 'CustomAttr'], 'multi_store_attr'),
+    ]
+    public function testUpdateMultistorePreservingOtherStoreLabel()
+    {
+        $store1 = $this->fixtures->get('store1');
+        $store2 = $this->fixtures->get('store2');
+        $attributeCode = $this->fixtures->get('multi_store_attr')->getAttributeCode();
+        $attributeLabel = 'Multi Store Option';
+        $store1Label = 'Store 1 Label';
+        $store2Label = 'Store 2 Label';
+        $store1LabelUpdated = 'Store 1 Label Updated';
+
+        // First, create an option with multiple store labels
+        $initialOptionData = [
+            AttributeOptionInterface::LABEL => $attributeLabel,
+            AttributeOptionInterface::STORE_LABELS => [
+                [
+                    AttributeOptionLabelInterface::LABEL => $store1Label,
+                    AttributeOptionLabelInterface::STORE_ID => $store1->getId(),
+                ],
+                [
+                    AttributeOptionLabelInterface::LABEL => $store2Label,
+                    AttributeOptionLabelInterface::STORE_ID => $store2->getId(),
+                ],
+            ],
+        ];
+
+        // Add the option first
+        $newOptionId = $this->webApiCallAttributeOptions(
+            $attributeCode,
+            Request::HTTP_METHOD_POST,
+            'add',
+            [
+                'attributeCode' => $attributeCode,
+                'option' => $initialOptionData,
+            ]
+        );
+        $this->assertNotNull($newOptionId, 'Option should be created successfully');
+
+        // Now update only the first store label
+        $updateOptionData = [
+            AttributeOptionInterface::LABEL => $attributeLabel,
+            AttributeOptionInterface::VALUE => $newOptionId,
+            AttributeOptionInterface::STORE_LABELS => [
+                [
+                    AttributeOptionLabelInterface::LABEL => $store1LabelUpdated,
+                    AttributeOptionLabelInterface::STORE_ID => $store1->getId(),
+                ],
+            ],
+        ];
+
+        $response = $this->webApiCallAttributeOptions(
+            $attributeCode,
+            Request::HTTP_METHOD_PUT,
+            'update',
+            [
+                'attributeCode' => $attributeCode,
+                'optionId' => $newOptionId,
+                'option' => $updateOptionData,
+            ],
+            $newOptionId
+        );
+        $this->assertTrue($response, 'Update should be successful');
+
+        // Test store labels preservation by checking labels in different store contexts
+        // This verifies that the fix for preserving store labels is working correctly
+        $store1Options = $this->getAttributeOptions($attributeCode, $store1->getCode());
+        $store2Options = $this->getAttributeOptions($attributeCode, $store2->getCode());
+
+        // Find the option in store1 context
+        $store1Option = null;
+        foreach ($store1Options as $option) {
+            if ($option['value'] === $newOptionId) {
+                $store1Option = $option;
+                break;
+            }
+        }
+        // Find the option in store2 context
+        $store2Option = null;
+        foreach ($store2Options as $option) {
+            if ($option['value'] === $newOptionId) {
+                $store2Option = $option;
+                break;
+            }
+        }
+
+        // Verify that store1 label was updated
+        $this->assertNotNull($store1Option, 'Option should exist in store1 context');
+        $this->assertEquals(
+            $store1LabelUpdated,
+            $store1Option['label'],
+            'Store1 label should be updated'
+        );
+
+        // Verify that store2 label was preserved
+        $this->assertNotNull($store2Option, 'Option should exist in store2 context');
+        $this->assertEquals(
+            $store2Label,
+            $store2Option['label'],
+            'Store2 label should be preserved'
+        );
+    }
+
     /**
      * Test to update option with already exist exception
      *