fix failed static tests

Author: karyna-t

app/code/Magento/Catalog/Helper/Image.php

@@ -24,7 +24,7 @@ class Image extends AbstractHelper implements ArgumentInterface
     /**
      * Media config node
      */
-    const MEDIA_TYPE_CONFIG_NODE = 'images';
+    public const MEDIA_TYPE_CONFIG_NODE = 'images';
 
     /**
      * Current model

app/code/Magento/Catalog/Model/Category.php

@@ -48,29 +48,29 @@ class Category extends \Magento\Catalog\Model\AbstractModel implements
      * Entity code.
      * Can be used as part of method name for entity processing
      */
-    const ENTITY = 'catalog_category';
+    public const ENTITY = 'catalog_category';
 
     /**#@+
      * Category display modes
      */
-    const DM_PRODUCT = 'PRODUCTS';
+    public const DM_PRODUCT = 'PRODUCTS';
 
-    const DM_PAGE = 'PAGE';
+    public const DM_PAGE = 'PAGE';
 
-    const DM_MIXED = 'PRODUCTS_AND_PAGE';
+    public const DM_MIXED = 'PRODUCTS_AND_PAGE';
     /**#@-*/
 
     /**
      * Id of root category
      */
-    const ROOT_CATEGORY_ID = 0;
+    public const ROOT_CATEGORY_ID = 0;
 
     /**
      * Id of category tree root
      */
-    const TREE_ROOT_ID = 1;
+    public const TREE_ROOT_ID = 1;
 
-    const CACHE_TAG = 'cat_c';
+    public const CACHE_TAG = 'cat_c';
 
     /**
      * @var string

app/code/Magento/CatalogSearch/Model/Indexer/Fulltext/Action/DataProvider.php

@@ -69,15 +69,11 @@ class DataProvider
     private $productAttributeCollectionFactory;
 
     /**
-     * Eav config
-     *
      * @var Config
      */
     private $eavConfig;
 
     /**
-     * Catalog product type
-     *
      * @var Type
      */
     private $catalogProductType;
@@ -90,8 +86,6 @@ class DataProvider
     private $eventManager;
 
     /**
-     * Store manager
-     *
      * @var StoreManagerInterface
      */
     private $storeManager;
@@ -179,7 +173,8 @@ public function __construct(
         $this->engine = $engineProvider->get();
         $this->metadata = $metadataPool->getMetadata(ProductInterface::class);
         $this->antiGapMultiplier = $antiGapMultiplier;
-        $this->selectSearchableProducts = $getSearchableProductsSelect ?: ObjectManager::getInstance()->get(GetSearchableProductsSelect::class);
+        $this->selectSearchableProducts = $getSearchableProductsSelect ?:
+            ObjectManager::getInstance()->get(GetSearchableProductsSelect::class);
     }
 
     /**
@@ -589,7 +584,9 @@ private function getAttributeValue($attributeId, $valueIds, $storeId)
      * @param int $attributeId
      * @param int|string $valueIds
      * @param int $storeId
+     *
      * @return null|string
+     * @SuppressWarnings(PHPMD.CyclomaticComplexity)
      */
     private function getAttributeOptionValue($attributeId, $valueIds, $storeId)
     {

app/code/Magento/Sales/Model/Order/Creditmemo.php

@@ -32,15 +32,15 @@
  */
 class Creditmemo extends AbstractModel implements EntityInterface, CreditmemoInterface
 {
-    const STATE_OPEN = 1;
+    public const STATE_OPEN = 1;
 
-    const STATE_REFUNDED = 2;
+    public const STATE_REFUNDED = 2;
 
-    const STATE_CANCELED = 3;
+    public const STATE_CANCELED = 3;
 
-    const REPORT_DATE_TYPE_ORDER_CREATED = 'order_created';
+    public const REPORT_DATE_TYPE_ORDER_CREATED = 'order_created';
 
-    const REPORT_DATE_TYPE_REFUND_CREATED = 'refund_created';
+    public const REPORT_DATE_TYPE_REFUND_CREATED = 'refund_created';
 
     /**
      * Identifier for order history item

app/code/Magento/Webapi/Model/Soap/Wsdl/ComplexTypeStrategy.php

@@ -16,12 +16,12 @@ class ComplexTypeStrategy extends AbstractComplexTypeStrategy
     /**
      *  Array item key value for element.
      */
-    const ARRAY_ITEM_KEY_NAME = 'item';
+    public const ARRAY_ITEM_KEY_NAME = 'item';
 
     /**
      * Appinfo nodes namespace.
      */
-    const APP_INF_NS = 'inf';
+    public const APP_INF_NS = 'inf';
 
     /**
      * @var \Magento\Framework\Reflection\TypeProcessor

lib/internal/Magento/Framework/Stdlib/StringUtils.php

@@ -16,7 +16,7 @@ class StringUtils
     /**
      * Default charset
      */
-    const ICONV_CHARSET = 'UTF-8';
+    public const ICONV_CHARSET = 'UTF-8';
 
     /**
      * Capitalize first letters and convert separators if needed