Fix complaints from static code analysers

Author: fredden

app/code/Magento/Sitemap/Model/ResourceModel/Cms/Page.php

@@ -1,10 +1,13 @@
 <?php
+
 /**
  * Copyright © Magento, Inc. All rights reserved.
  * See COPYING.txt for license details.
  */
+
 namespace Magento\Sitemap\Model\ResourceModel\Cms;
 
+use Magento\Framework\DataObject;
 use Magento\Cms\Api\Data\PageInterface;
 use Magento\Cms\Api\GetUtilityPageIdentifiersInterface;
 use Magento\Cms\Model\Page as CmsPage;
@@ -21,6 +24,8 @@
  *
  * @api
  * @since 100.0.2
+ * @SuppressWarnings(PHPMD.CamelCaseMethodName)
+ * @SuppressWarnings(PHPMD.LongVariable)
  */
 class Page extends AbstractDb
 {
@@ -85,6 +90,7 @@ public function getConnection()
      * Retrieve cms page collection array
      *
      * @param int $storeId
+     *
      * @return array
      */
     public function getCollection($storeId)
@@ -133,11 +139,12 @@ static function ($urlKey) {
      * Prepare page object
      *
      * @param array $data
-     * @return \Magento\Framework\DataObject
+     *
+     * @return DataObject
      */
     protected function _prepareObject(array $data)
     {
-        $object = new \Magento\Framework\DataObject();
+        $object = new DataObject();
         $object->setId($data[$this->getIdFieldName()]);
         $object->setUrl($data['url']);
         $object->setUpdatedAt($data['updated_at']);
@@ -150,7 +157,8 @@ protected function _prepareObject(array $data)
      *
      * @param CmsPage|AbstractModel $object
      * @param mixed $value
-     * @param string $field field to load by (defaults to model id)
+     * @param string $field Field to load by (defaults to model id).
+     *
      * @return $this
      * @since 100.1.0
      */
@@ -178,6 +186,7 @@ public function load(AbstractModel $object, $value, $field = null)
         if ($isId) {
             $this->entityManager->load($object, $value);
         }
+
         return $this;
     }
 
@@ -200,6 +209,7 @@ public function save(AbstractModel $object)
                 $object->setHasDataChanges(false);
                 return $this;
             }
+
             $object->validateBeforeSave();
             $object->beforeSave();
             if ($object->isSaveAllowed()) {
@@ -211,13 +221,15 @@ public function save(AbstractModel $object)
                 $this->unserializeFields($object);
                 $this->processAfterSaves($object);
             }
+
             $this->addCommitCallback([$object, 'afterCommitCallback'])->commit();
             $object->setHasDataChanges(false);
         } catch (\Exception $e) {
             $this->rollBack();
             $object->setHasDataChanges(true);
             throw $e;
         }
+
         return $this;
     }
 

app/code/Magento/Sitemap/Test/Unit/Model/ResourceModel/Cms/PageTest.php

@@ -1,8 +1,10 @@
 <?php
+
 /**
  * Copyright © Magento, Inc. All rights reserved.
  * See COPYING.txt for license details.
  */
+
 declare(strict_types=1);
 
 namespace Magento\Sitemap\Test\Unit\Model\ResourceModel\Cms;
@@ -25,6 +27,8 @@
 /**
  * Provide tests for Cms Page resource model.
  * @SuppressWarnings(PHPMD.CouplingBetweenObjects)
+ * @SuppressWarnings(PHPMD.ExcessiveMethodLength)
+ * @SuppressWarnings(PHPMD.LongVariable)
  */
 class PageTest extends TestCase
 {
@@ -151,7 +155,10 @@ public function testGetCollection()
             ->method('where')
             ->withConsecutive(
                 [$this->identicalTo('main_table.is_active = 1')],
-                [$this->identicalTo('main_table.identifier NOT IN (?)'), $this->identicalTo(array_values($pageIdentifiers))],
+                [
+                    $this->identicalTo('main_table.identifier NOT IN (?)'),
+                    $this->identicalTo(array_values($pageIdentifiers))
+                ],
                 [$this->identicalTo('store_table.store_id IN(?)'), $this->identicalTo([0, $storeId])]
             )->willReturnSelf();