Merge pull request #6458 from magento-lynx/MC-39542

[lynx] MC-39044: Test for Compatibility with the New PHP Versions [2.4]

Author: svera

dev/tests/static/testsuite/Magento/Test/Php/LiveCodeTest.php

@@ -209,14 +209,14 @@ private function getFullWhitelist()
     }
 
     /**
-     * Retrieves the lowest PHP version specified in <kbd>composer.json</var> of project.
+     * Retrieves the lowest and highest PHP version specified in <kbd>composer.json</var> of project.
      *
-     * @return string
+     * @return array
      */
-    private function getLowestPhpVersion(): string
+    private function getTargetPhpVersions(): array
     {
         $composerJson = json_decode(file_get_contents(BP . '/composer.json'), true);
-        $phpVersion   = '7.0';
+        $versionsRange = [];
 
         if (isset($composerJson['require']['php'])) {
             $versions = explode('||', $composerJson['require']['php']);
@@ -232,12 +232,17 @@ private function getLowestPhpVersion(): string
             //sort versions
             usort($versions, 'version_compare');
 
-            $lowestVersion = array_shift($versions);
-            $versionParts  = explode('.', $lowestVersion);
-            $phpVersion    = sprintf('%s.%s', $versionParts[0], $versionParts[1] ?? '0');
+            $versionsRange[] = array_shift($versions);
+            if (!empty($versions)) {
+                $versionsRange[] = array_pop($versions);
+            }
+            foreach ($versionsRange as $key => $version) {
+                $versionParts  = explode('.', $versionsRange[$key]);
+                $versionsRange[$key] = sprintf('%s.%s', $versionParts[0], $versionParts[1] ?? '0');
+            }
         }
 
-        return $phpVersion;
+        return $versionsRange;
     }
 
     /**
@@ -408,7 +413,8 @@ public function testStrictTypes()
      */
     public function testPhpCompatibility()
     {
-        $targetVersion = $this->getLowestPhpVersion();
+        $targetVersions = $this->getTargetPhpVersions();
+        $this->assertNotEmpty($targetVersions, 'No supported versions information in composer.json');
         $reportFile    = self::$reportDir . '/phpcompatibility_report.txt';
         $rulesetDir    = __DIR__ . '/_files/PHPCompatibilityMagento';
 
@@ -417,7 +423,11 @@ public function testPhpCompatibility()
         }
 
         $codeSniffer = new PhpCompatibility($rulesetDir, $reportFile, new Wrapper());
-        $codeSniffer->setTestVersion($targetVersion);
+        if (count($targetVersions) > 1) {
+            $codeSniffer->setTestVersion($targetVersions[0] . '-' . $targetVersions[1]);
+        } else {
+            $codeSniffer->setTestVersion($targetVersions[0]);
+        }
 
         $result = $codeSniffer->run(
             $this->isFullScan() ? $this->getFullWhitelist() : self::getWhitelist(['php', 'phtml'])