MAGETWO-39948: Security scan, global scope variables (#15723882, #15723890)

Viktor Tymchynskyi · Viktor Tymchynskyi · commit 046cacbaea7b · 2015-07-14T13:52:38.000+03:00
- Add EXTR_SKIP flag that deny variable overriding if it already exists
diff --git a/app/code/Magento/Eav/Model/Entity/AbstractEntity.php b/app/code/Magento/Eav/Model/Entity/AbstractEntity.php
@@ -1413,7 +1413,7 @@ protected function _prepareStaticValue($key, $value)
      */
     protected function _processSaveData($saveData)
     {
-        extract($saveData);
+        extract($saveData, EXTR_SKIP);
         /**
          * Import variables into the current symbol table from save data array
          *

Original file line number	Diff line number	Diff line change
`@@ -1413,7 +1413,7 @@ protected function _prepareStaticValue($key, $value)`
`1413`	`1413`	`*/`
`1414`	`1414`	`protected function _processSaveData($saveData)`
`1415`	`1415`	`{`
`1416`		`- extract($saveData);`
	`1416`	`+ extract($saveData, EXTR_SKIP);`
`1417`	`1417`	`/**`
`1418`	`1418`	`* Import variables into the current symbol table from save data array`
`1419`	`1419`	`*`