ACP2E-4045: Product Views Report Incorrect - Lower Count Compared to GA

Author: o-dubovyk

app/code/Magento/Reports/Controller/Report/Product/View.php

@@ -7,7 +7,7 @@
 
 namespace Magento\Reports\Controller\Report\Product;
 
-use Magento\Backend\App\Action\Context;
+use Magento\Framework\App\Action\Context;
 use Magento\Customer\Model\Session;
 use Magento\Customer\Model\Visitor;
 use Magento\Framework\App\Action\HttpPostActionInterface;

app/code/Magento/Reports/Observer/CatalogProductViewObserver.php

@@ -1,7 +1,7 @@
 <?php
 /**
- * Copyright © Magento, Inc. All rights reserved.
- * See COPYING.txt for license details.
+ * Copyright 2015 Adobe
+ * All Rights Reserved.
  */
 namespace Magento\Reports\Observer;
 
@@ -11,6 +11,10 @@
 /**
  * Reports Event observer model
  * @SuppressWarnings(PHPMD.CookieAndSessionMisuse)
+ * @deprecated We cannot rely on the observer to count product page visits (GET requests)
+ * because the observer will not be called due fact that pages rely heavily on cache.
+ * Instead, a call from a product page should be made to a separate controller.
+ * @see \Magento\Reports\Controller\Report\Product\View
  */
 class CatalogProductViewObserver implements ObserverInterface
 {

app/code/Magento/Reports/etc/frontend/events.xml

@@ -1,8 +1,8 @@
 <?xml version="1.0"?>
 <!--
 /**
- * Copyright © Magento, Inc. All rights reserved.
- * See COPYING.txt for license details.
+ * Copyright 2013 Adobe
+ * All Rights Reserved.
  */
 -->
 <config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:framework:Event/etc/events.xsd">
@@ -15,9 +15,6 @@
     <event name="customer_logout">
         <observer name="reports" instance="Magento\Reports\Observer\CustomerLogoutObserver" />
     </event>
-    <event name="catalog_controller_product_view">
-        <observer name="reports" instance="Magento\Reports\Observer\CatalogProductViewObserver" />
-    </event>
     <event name="sendfriend_product">
         <observer name="reports" instance="Magento\Reports\Observer\SendfriendProductObserver" />
     </event>

app/code/Magento/Reports/view/frontend/web/js/product-viewed.js

@@ -4,13 +4,14 @@
  */
 
 define([
-    'jquery'
-], function ($) {
+    'jquery',
+    'mage/url'
+], function ($, urlBuilder) {
     'use strict';
 
     return function (data) {
         $.ajax({
-            url: 'reports/report_product/view',
+            url: urlBuilder.build('reports/report_product/view'),
             type: 'POST',
             data: {'product_id': data.product_id },
             dataType: 'json'

dev/tests/integration/testsuite/Magento/Backend/Block/Dashboard/Tab/Products/ViewedTest.php renamed to dev/tests/integration/testsuite/Magento/Reports/Controller/Adminhtml/Report/ViewedTest.php

@@ -1,21 +1,23 @@
 <?php
 /**
- * Copyright © Magento, Inc. All rights reserved.
- * See COPYING.txt for license details.
+ * Copyright 2017 Adobe
+ * All Rights Reserved.
  */
-namespace Magento\Backend\Block\Dashboard\Tab\Products;
+namespace Magento\Reports\Controller\Adminhtml\Report;
 
-use Magento\TestFramework\Helper\Bootstrap as BootstrapHelper;
-use Magento\Framework\ObjectManagerInterface;
-use Magento\Framework\View\LayoutInterface;
 use Magento\Backend\Block\Dashboard\Tab\Products\Viewed as ViewedProductsTabBlock;
 use Magento\Catalog\Model\ProductRepository;
+use Magento\Framework\App\Request\Http;
 use Magento\Framework\Event\ManagerInterface as EventManager;
+use Magento\Framework\ObjectManagerInterface;
+use Magento\Framework\View\LayoutInterface;
+use Magento\TestFramework\Helper\Bootstrap as BootstrapHelper;
+use function PHPUnit\Framework\assertEquals;
 
 /**
  * @magentoAppArea frontend
  */
-class ViewedTest extends \PHPUnit\Framework\TestCase
+class ViewedTest extends \Magento\TestFramework\TestCase\AbstractController
 {
     /**
      * @var ObjectManagerInterface
@@ -39,24 +41,30 @@ class ViewedTest extends \PHPUnit\Framework\TestCase
 
     protected function setUp(): void
     {
+        parent::setUp();
         $this->objectManager = BootstrapHelper::getObjectManager();
         $this->layout = $this->objectManager->get(LayoutInterface::class);
         $this->productRepository = $this->objectManager->get(ProductRepository::class);
         $this->eventManager = $this->objectManager->get(EventManager::class);
     }
 
     /**
+     * Assert viewed product in reports.
+     *
      * @magentoDataFixture Magento/Catalog/_files/product_simple.php
      * @magentoDbIsolation enabled
      * @magentoAppIsolation enabled
      * @magentoConfigFixture default/reports/options/enabled 1
      */
     public function testGetPreparedCollectionProductPrice()
     {
+        $sku = 'simple';
+        $product = $this->productRepository->get($sku);
+        $this->getRequest()->setMethod(Http::METHOD_POST)->setPostValue('product_id', $product->getId());
+        $this->dispatch('reports/report_product/view');
+
         /** @var ViewedProductsTabBlock $viewedProductsTabBlock */
         $viewedProductsTabBlock = $this->layout->createBlock(ViewedProductsTabBlock::class);
-        $product = $this->productRepository->getById(1);
-        $this->eventManager->dispatch('catalog_controller_product_view', ['product' => $product]);
 
         $collection = $viewedProductsTabBlock->getPreparedCollection();