Skip to content

Commit 0059b1f

Browse files
committed
Fix static test failures
1 parent 729dfb0 commit 0059b1f

File tree

31 files changed

+87
-60
lines changed

31 files changed

+87
-60
lines changed

app/code/Magento/Backend/Block/Dashboard/AbstractDashboard.php

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,8 @@ public function __construct(
3838
}
3939

4040
/**
41+
* Return a collection
42+
*
4143
* @return array|AbstractCollection|\Magento\Eav\Model\Entity\Collection\Abstract
4244
*/
4345
public function getCollection()
@@ -46,6 +48,8 @@ public function getCollection()
4648
}
4749

4850
/**
51+
* Return items count
52+
*
4953
* @return int
5054
*/
5155
public function getCount()
@@ -64,6 +68,8 @@ public function getDataHelper()
6468
}
6569

6670
/**
71+
* Prepare any data for display, if required
72+
*
6773
* @return $this
6874
*/
6975
protected function _prepareData()
@@ -72,6 +78,8 @@ protected function _prepareData()
7278
}
7379

7480
/**
81+
* Ensure data is prepared before layout
82+
*
7583
* @return $this
7684
*/
7785
protected function _prepareLayout()

app/code/Magento/Backend/Block/Dashboard/Graph.php

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -14,32 +14,24 @@
1414
*/
1515
class Graph extends \Magento\Backend\Block\Dashboard\AbstractDashboard
1616
{
17-
const API_URL = 'https://image-charts.com/chart';
17+
public const API_URL = 'https://image-charts.com/chart';
1818

1919
/**
20-
* All series
21-
*
2220
* @var array
2321
*/
2422
protected $_allSeries = [];
2523

2624
/**
27-
* Axis labels
28-
*
2925
* @var array
3026
*/
3127
protected $_axisLabels = [];
3228

3329
/**
34-
* Axis maps
35-
*
3630
* @var array
3731
*/
3832
protected $_axisMaps = [];
3933

4034
/**
41-
* Data rows
42-
*
4335
* @var array
4436
*/
4537
protected $_dataRows = [];

app/code/Magento/Backend/Block/Page.php

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -60,6 +60,8 @@ public function getLang()
6060
}
6161

6262
/**
63+
* Returns true if we are running in single store mode
64+
*
6365
* @return bool
6466
*/
6567
public function isSingleStoreMode()

app/code/Magento/Backend/Block/Page/Header.php

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,6 @@ class Header extends \Magento\Backend\Block\Template
2020
protected $_template = 'Magento_Backend::page/header.phtml';
2121

2222
/**
23-
* Backend data
24-
*
2523
* @var \Magento\Backend\Helper\Data
2624
*/
2725
protected $_backendData = null;
@@ -49,6 +47,8 @@ public function __construct(
4947
}
5048

5149
/**
50+
* Return URL to homepage
51+
*
5252
* @return string
5353
*/
5454
public function getHomeLink()
@@ -57,6 +57,8 @@ public function getHomeLink()
5757
}
5858

5959
/**
60+
* Return the current user
61+
*
6062
* @return \Magento\User\Model\User|null
6163
*/
6264
public function getUser()
@@ -65,6 +67,8 @@ public function getUser()
6567
}
6668

6769
/**
70+
* Return URL to log out from admin
71+
*
6872
* @return string
6973
*/
7074
public function getLogoutLink()

app/code/Magento/Backend/Block/Page/System/Config/Robots/Reset.php

Lines changed: 3 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -16,20 +16,10 @@
1616
class Reset extends \Magento\Config\Block\System\Config\Form\Field
1717
{
1818
/**
19-
* Pasge robots default instructions
19+
* Page robots default instructions
2020
*/
21-
const XML_PATH_ROBOTS_DEFAULT_CUSTOM_INSTRUCTIONS = 'design/search_engine_robots/default_custom_instructions';
22-
23-
/**
24-
* @param \Magento\Backend\Block\Template\Context $context
25-
* @param array $data
26-
*/
27-
public function __construct(
28-
\Magento\Backend\Block\Template\Context $context,
29-
array $data = []
30-
) {
31-
parent::__construct($context, $data);
32-
}
21+
public const XML_PATH_ROBOTS_DEFAULT_CUSTOM_INSTRUCTIONS =
22+
'design/search_engine_robots/default_custom_instructions';
3323

3424
/**
3525
* Set template

app/code/Magento/Backend/Block/System/Account/Edit.php

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,8 @@
1414
class Edit extends \Magento\Backend\Block\Widget\Form\Container
1515
{
1616
/**
17+
* Initialise the page
18+
*
1719
* @return void
1820
*/
1921
protected function _construct()
@@ -28,6 +30,8 @@ protected function _construct()
2830
}
2931

3032
/**
33+
* Return a Phrase for the header text
34+
*
3135
* @return \Magento\Framework\Phrase
3236
*/
3337
public function getHeaderText()

app/code/Magento/Backend/Block/System/Account/Edit/Form.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
*/
1414
class Form extends \Magento\Backend\Block\Widget\Form\Generic
1515
{
16-
const IDENTITY_VERIFICATION_PASSWORD_FIELD = 'current_password';
16+
public const IDENTITY_VERIFICATION_PASSWORD_FIELD = 'current_password';
1717

1818
/**
1919
* @var \Magento\Backend\Model\Auth\Session

app/code/Magento/Backend/Block/System/Cache/Edit.php

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,8 @@ class Edit extends \Magento\Backend\Block\Widget
1616
protected $_template = 'Magento_Backend::system/cache/edit.phtml';
1717

1818
/**
19+
* Set the page title
20+
*
1921
* @return void
2022
*/
2123
protected function _construct()
@@ -26,7 +28,7 @@ protected function _construct()
2628
}
2729

2830
/**
29-
* {@inheritdoc}
31+
* @inheritDoc
3032
*/
3133
protected function _prepareLayout()
3234
{
@@ -45,6 +47,8 @@ protected function _prepareLayout()
4547
}
4648

4749
/**
50+
* Return the HTML for the save button
51+
*
4852
* @return string
4953
*/
5054
public function getSaveButtonHtml()
@@ -53,6 +57,8 @@ public function getSaveButtonHtml()
5357
}
5458

5559
/**
60+
* Return the URL to save an item
61+
*
5662
* @return string
5763
*/
5864
public function getSaveUrl()
@@ -61,6 +67,8 @@ public function getSaveUrl()
6167
}
6268

6369
/**
70+
* Initialise the form
71+
*
6472
* @return $this
6573
*/
6674
public function initForm()

app/code/Magento/Backend/Block/System/Store/Delete/Group.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
class Group extends \Magento\Backend\Block\Template
1212
{
1313
/**
14-
* {@inheritdoc}
14+
* @inheritDoc
1515
*/
1616
protected function _prepareLayout()
1717
{

app/code/Magento/Backend/Block/System/Store/Delete/Website.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
class Website extends \Magento\Backend\Block\Template
1212
{
1313
/**
14-
* {@inheritdoc}
14+
* @inheritDoc
1515
*/
1616
protected function _prepareLayout()
1717
{

0 commit comments

Comments
 (0)