Merge branch '2.3-develop' of github.com:magento/magento2-sample-data into MQE-1069

Author: okolesnyk

app/code/Magento/DownloadableSampleData/Model/Product/Converter.php

@@ -24,6 +24,35 @@ class Converter extends \Magento\CatalogSampleData\Model\Product\Converter
      */
     private $filesystem;
 
+    public function __construct(
+        \Magento\Catalog\Model\Category\TreeFactory $categoryTreeFactory,
+        \Magento\Catalog\Model\ResourceModel\Category\TreeFactory $categoryResourceTreeFactory,
+        \Magento\Eav\Model\Config $eavConfig,
+        \Magento\Catalog\Model\ResourceModel\Category\CollectionFactory $categoryCollectionFactory,
+        \Magento\Catalog\Model\ResourceModel\Product\Attribute\CollectionFactory $attributeCollectionFactory,
+        \Magento\Eav\Model\ResourceModel\Entity\Attribute\Option\CollectionFactory $attrOptionCollectionFactory,
+        \Magento\Catalog\Model\ResourceModel\Product\CollectionFactory $productCollectionFactory,
+        \Magento\Downloadable\Api\Data\File\ContentInterfaceFactory $fileContentFactory = null,
+        Filesystem $filesystem = null
+    ) {
+        parent::__construct(
+            $categoryTreeFactory,
+            $categoryResourceTreeFactory,
+            $eavConfig,
+            $categoryCollectionFactory,
+            $attributeCollectionFactory,
+            $attrOptionCollectionFactory,
+            $productCollectionFactory
+        );
+        $this->fileContentFactory = $fileContentFactory ?: ObjectManager::getInstance()->get(
+            \Magento\Downloadable\Api\Data\File\ContentInterfaceFactory::class
+        );
+        $this->filesystem = $filesystem ?: ObjectManager::getInstance()->get(
+            Filesystem::class
+        );
+    }
+
+
     /**
      * Get downloadable data from array
      *
@@ -159,11 +188,6 @@ public function getSamplesInfo()
      */
     private function getFileContent()
     {
-        if (!$this->fileContentFactory) {
-            $this->fileContentFactory = ObjectManager::getInstance()->create(
-                \Magento\Downloadable\Api\Data\File\ContentInterfaceFactory::class
-            );
-        }
         return $this->fileContentFactory->create();
     }
 
@@ -173,11 +197,6 @@ private function getFileContent()
      */
     private function getFilesystem()
     {
-        if (!$this->filesystem) {
-            $this->filesystem = ObjectManager::getInstance()->create(
-                Filesystem::class
-            );
-        }
         return $this->filesystem;
     }
 }

app/code/Magento/OfflineShippingSampleData/Model/Tablerate.php

@@ -8,6 +8,7 @@
 use Magento\Framework\Setup\SampleData\Context as SampleDataContext;
 use Magento\Framework\App\ObjectManager;
 use Magento\Config\App\Config\Type\System as SystemConfig;
+use Magento\OfflineShipping\Model\Carrier\Tablerate as CarrierTablerate;
 
 /**
  * Class Tablerate
@@ -128,7 +129,7 @@ public function install(array $fixtures)
                             'dest_country_id' => $data['country'],
                             'dest_region_id' => $regionId,
                             'dest_zip' => $data['zip'],
-                            'condition_name' => 'package_value',
+                            'condition_name' => 'package_value_with_discount',
                             'condition_value' => $data['order_subtotal'],
                             'price' => $data['price'],
                             'cost' => 0,
@@ -146,7 +147,9 @@ public function install(array $fixtures)
         }
 
         $this->configWriter->save('carriers/tablerate/active', 1);
-        $this->configWriter->save('carriers/tablerate/condition_name', 'package_value');
+        $this->configWriter->save(
+            'carriers/tablerate/condition_name', 'package_value_with_discount'
+        );
         $this->cacheTypeList->cleanType('config');
         $this->systemConfig->clean();
     }

app/code/Magento/WidgetSampleData/Model/CmsBlock.php

@@ -7,6 +7,7 @@
 
 use Magento\Framework\Serialize\Serializer\Json;
 use Magento\Framework\Setup\SampleData\Context as SampleDataContext;
+use \Magento\Framework\App\State;
 
 /**
  * Launches setup of sample data for Widget module
@@ -53,6 +54,11 @@ class CmsBlock
      */
     private $serializer;
 
+    /**
+     * @var State
+     */
+    private $appState;
+
     /**
      * @param SampleDataContext $sampleDataContext
      * @param \Magento\Widget\Model\Widget\InstanceFactory $widgetFactory
@@ -61,6 +67,7 @@ class CmsBlock
      * @param \Magento\Widget\Model\ResourceModel\Widget\Instance\CollectionFactory $appCollectionFactory
      * @param \Magento\Catalog\Model\ResourceModel\Category\CollectionFactory $categoryFactory
      * @param Json|null $serializer
+     * @param State|null $appState
      */
     public function __construct(
         SampleDataContext $sampleDataContext,
@@ -69,7 +76,8 @@ public function __construct(
         \Magento\Cms\Model\BlockFactory $cmsBlockFactory,
         \Magento\Widget\Model\ResourceModel\Widget\Instance\CollectionFactory $appCollectionFactory,
         \Magento\Catalog\Model\ResourceModel\Category\CollectionFactory $categoryFactory,
-        Json $serializer = null
+        Json $serializer = null,
+        State $appState = null
     ) {
         $this->fixtureManager = $sampleDataContext->getFixtureManager();
         $this->csvReader = $sampleDataContext->getCsvReader();
@@ -79,6 +87,7 @@ public function __construct(
         $this->appCollectionFactory = $appCollectionFactory;
         $this->categoryFactory = $categoryFactory;
         $this->serializer = $serializer ?: \Magento\Framework\App\ObjectManager::getInstance()->get(Json::class);
+        $this->appState = $appState ?: \Magento\Framework\App\ObjectManager::getInstance()->get(State::class);
     }
 
     /**
@@ -163,7 +172,10 @@ public function install(array $fixtures)
                     ->setStoreIds([\Magento\Store\Model\Store::DEFAULT_STORE_ID])
                     ->setWidgetParameters(['block_id' => $block->getId()])
                     ->setPageGroups([$pageGroup]);
-                $widgetInstance->save();
+                $this->appState->emulateAreaCode(
+                    'frontend',
+                    [$widgetInstance, 'save']
+                );
             }
         }
     }