Fixed PMD rules

Author: Vitaliy Boyko

gradle-tasks/pmd/ruleset.xml

@@ -0,0 +1,25 @@
+<?xml version="1.0"?>
+
+<ruleset name="Custom Rules"
+         xmlns="http://pmd.sourceforge.net/ruleset/2.0.0"
+         xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+         xsi:schemaLocation="http://pmd.sourceforge.net/ruleset/2.0.0 https://pmd.sourceforge.io/ruleset_2_0_0.xsd">
+
+    <description>
+        Magento PhpStorm rules
+    </description>
+    <rule ref="category/java/bestpractices.xml" />
+    <rule ref="category/java/codestyle.xml"/>
+    <rule ref="category/java/design.xml">
+        <exclude name="LawOfDemeter"/>
+    </rule>
+    <rule ref="category/java/documentation.xml">
+        <exclude name="CommentRequired" />
+    </rule>
+    <rule ref="category/java/errorprone.xml">
+        <exclude name="BeanMembersShouldSerialize"/>
+    </rule>
+    <rule ref="category/java/multithreading.xml"/>
+    <rule ref="category/java/performance.xml"/>
+    <rule ref="category/java/security.xml" />
+</ruleset>

gradle-tasks/staticChecks.gradle

@@ -21,12 +21,7 @@ pmd {
     consoleOutput = true
     rulePriority = 5
     ruleSets = [
-        "category/java/codestyle.xml",
-        "category/java/design.xml",
-        "category/java/errorprone.xml",
-        "category/java/bestpractices.xml",
-        "category/java/performance.xml",
-        "category/java/security.xml",
+        "gradle-tasks/pmd/ruleset.xml"
     ]
 }
 

src/com/magento/idea/magento2plugin/actions/generation/dialog/CreateAnObserverDialog.java

@@ -30,33 +30,35 @@
 import javax.swing.KeyStroke;
 import org.jetbrains.annotations.NotNull;
 
-public class CreateAnObserverDialog extends AbstractDialog {
+public class CreateAnObserverDialog extends AbstractDialog {//NOPMD
     @NotNull
     private final Project project;
     @NotNull
     private final CreateAnObserverDialogValidator validator;
-    private String targetEvent;
+    private final String targetEvent;
     private JPanel contentPane;
     private JButton buttonOK;
     private JButton buttonCancel;
     private JTextField observerClassName;
-    private JLabel observerClassNameLabel;
     private JTextField observerDirectory;
-    private JLabel observerDirectoryName;
-    private JLabel selectObserverModule;
     private FilteredComboBox observerModule;
     private JComboBox observerArea;
-    private JLabel observerAreaLabel;
-    private JLabel observerNameLabel;
     private JTextField observerName;
+    private JLabel observerClassNameLabel;//NOPMD
+    private JLabel observerDirectoryName;//NOPMD
+    private JLabel selectObserverModule;//NOPMD
+    private JLabel observerAreaLabel;//NOPMD
+    private JLabel observerNameLabel;//NOPMD
 
     /**
      * Constructor.
      *
      * @param project Project Scope
      * @param targetEvent Action Event
      */
-    public CreateAnObserverDialog(@NotNull Project project, String targetEvent) {
+    public CreateAnObserverDialog(@NotNull final Project project, final String targetEvent) {
+        super();
+
         this.project = project;
         this.targetEvent = targetEvent;
         this.validator = CreateAnObserverDialogValidator.getInstance(this);
@@ -71,7 +73,7 @@ public CreateAnObserverDialog(@NotNull Project project, String targetEvent) {
 
         setDefaultCloseOperation(DO_NOTHING_ON_CLOSE);
         addWindowListener(new WindowAdapter() {
-            public void windowClosing(WindowEvent e) {
+            public void windowClosing(final WindowEvent event) {
                 onCancel();
             }
         });
@@ -89,8 +91,8 @@ public void windowClosing(WindowEvent e) {
      * @param project Project Scope
      * @param targetEvent Action Event
      */
-    public static void open(@NotNull Project project, String targetEvent) {
-        CreateAnObserverDialog dialog = new CreateAnObserverDialog(project, targetEvent);
+    public static void open(@NotNull final Project project, final String targetEvent) {
+        final CreateAnObserverDialog dialog = new CreateAnObserverDialog(project, targetEvent);
         dialog.pack();
         dialog.centerDialog(dialog);
         dialog.setVisible(true);
@@ -100,7 +102,7 @@ public static void open(@NotNull Project project, String targetEvent) {
      * Setup observer area combobox.
      */
     private void fillTargetAreaOptions() {
-        for (Package.Areas area : Package.Areas.values()) {
+        for (final Package.Areas area : Package.Areas.values()) {
             observerArea.addItem(area.toString());
         }
     }
@@ -152,14 +154,14 @@ public String getObserverModule() {
         return this.observerModule.getSelectedItem().toString();
     }
 
-    private void createUiComponents() {
-        List<String> allModulesList = ModuleIndex.getInstance(project).getEditableModuleNames();
+    private void createUiComponents() {//NOPMD
+        final List<String> allModulesList = ModuleIndex.getInstance(project).getEditableModuleNames();
 
         this.observerModule = new FilteredComboBox(allModulesList);
     }
 
     private String getNamespace() {
-        String targetModule = getObserverModule();
+        final String targetModule = getObserverModule();
         String namespace = targetModule.replace(
                 Package.VENDOR_MODULE_NAME_SEPARATOR,
                 Package.FQN_SEPARATOR