2490: Remove SlowOperations API and deprecated behaviors

Refactor code to remove usage of the SlowOperations API for resolving references and retrieving data, improving performance and aligning with the latest IntelliJ guidelines. Additionally, deprecated methods and hardcoded Magento directory prompts were removed, and notification handling was updated to use modern APIs.

Author: VitaliyBoyko

gradle.properties

@@ -3,7 +3,7 @@ pluginName = Magento PhpStorm
 pluginRepositoryUrl = https://github.com/magento/magento2-phpstorm-plugin
 pluginVersion = 5.4.0
 pluginSinceBuild = 233
-pluginUntilBuild = 248.*
+pluginUntilBuild = 258.*
 platformType = PS
 platformVersion = 2024.3
 platformPlugins =

src/main/java/com/magento/idea/magento2plugin/actions/generation/CreateAnObserverAction.java

@@ -17,7 +17,6 @@
 import com.intellij.psi.PsiFile;
 import com.intellij.psi.PsiReference;
 import com.intellij.psi.tree.IElementType;
-import com.intellij.util.SlowOperations;
 import com.jetbrains.php.lang.lexer.PhpTokenTypes;
 import com.jetbrains.php.lang.psi.PhpFile;
 import com.jetbrains.php.lang.psi.elements.Method;
@@ -133,7 +132,7 @@ private boolean checkIsEventDispatchMethod(final MethodReference element) {
         if (elementReference == null) {
             return false;
         }
-        final PsiElement method = SlowOperations.allowSlowOperations(elementReference::resolve);
+        final PsiElement method = elementReference.resolve();
         if (!(method instanceof Method)) {
             return false;
         }

src/main/java/com/magento/idea/magento2plugin/generation/php/MagentoModuleGenerator.java

@@ -15,7 +15,6 @@
 import com.intellij.psi.PsiDirectory;
 import com.intellij.psi.PsiFile;
 import com.intellij.psi.PsiManager;
-import com.intellij.util.PlatformUtils;
 import com.magento.idea.magento2plugin.MagentoIcons;
 import com.magento.idea.magento2plugin.actions.generation.data.ModuleComposerJsonData;
 import com.magento.idea.magento2plugin.actions.generation.data.ModuleRegistrationPhpData;
@@ -57,11 +56,6 @@ public ProjectGeneratorPeer<MagentoProjectGeneratorSettings> createPeer() {
         return new MagentoProjectPeer();
     }
 
-    @Override
-    public boolean isPrimaryGenerator() {
-        return PlatformUtils.isPhpStorm();
-    }
-
     /**
      * Generate project.
      *

src/main/java/com/magento/idea/magento2plugin/generation/php/NewModuleForm.java

@@ -79,8 +79,6 @@ private void addPathListener() {
                 FileChooserDescriptorFactory.createSingleFolderDescriptor();
         final ComponentWithBrowseButton.BrowseFolderActionListener<JTextField> browseFolderListener
                 = new ComponentWithBrowseButton.BrowseFolderActionListener<JTextField>(
-                "Magento Root Directory",
-                "Choose Magento root directory",
                 this.magentoPath,
                 null,
                 descriptor,

src/main/java/com/magento/idea/magento2plugin/indexes/ModuleIndex.java

@@ -12,7 +12,6 @@
 import com.intellij.psi.PsiDirectory;
 import com.intellij.psi.PsiManager;
 import com.intellij.psi.search.GlobalSearchScope;
-import com.intellij.util.SlowOperations;
 import com.intellij.util.indexing.FileBasedIndex;
 import com.jetbrains.php.lang.PhpFileType;
 import com.magento.idea.magento2plugin.magento.packages.Package;
@@ -128,18 +127,16 @@ private List<String> getNames(
                 .getInstance();
         final Collection<VirtualFile> files = new ArrayList<>();
 
-        SlowOperations.allowSlowOperations(() -> {
-            files.addAll(
-                    index.getContainingFiles(
-                            ModuleNameIndex.KEY,
-                            moduleName,
-                            GlobalSearchScope.getScopeRestrictedByFileTypes(
-                                    GlobalSearchScope.allScope(project),
-                                    PhpFileType.INSTANCE
-                            )
-                    )
-            );
-        });
+        files.addAll(
+                index.getContainingFiles(
+                        ModuleNameIndex.KEY,
+                        moduleName,
+                        GlobalSearchScope.getScopeRestrictedByFileTypes(
+                                GlobalSearchScope.allScope(project),
+                                PhpFileType.INSTANCE
+                        )
+                )
+        );
 
         if (files.isEmpty()) {
             return null;

src/main/java/com/magento/idea/magento2plugin/inspections/php/util/PhpClassImplementsNoninterceptableInterfaceUtil.java

@@ -5,7 +5,6 @@
 
 package com.magento.idea.magento2plugin.inspections.php.util;
 
-import com.intellij.util.SlowOperations;
 import com.jetbrains.php.lang.psi.elements.PhpClass;
 import com.magento.idea.magento2plugin.magento.files.Plugin;
 import org.jetbrains.annotations.NotNull;
@@ -22,9 +21,7 @@ private PhpClassImplementsNoninterceptableInterfaceUtil() {}
      * @return bool
      */
     public static boolean execute(final @NotNull PhpClass phpClass) {
-        final PhpClass[] interfaces = SlowOperations.allowSlowOperations(
-                phpClass::getImplementedInterfaces
-        );
+        final PhpClass[] interfaces = phpClass.getImplementedInterfaces();
 
         if (interfaces.length == 0) {
             return false;

src/main/java/com/magento/idea/magento2plugin/project/ProjectDetector.java

@@ -5,6 +5,7 @@
 
 package com.magento.idea.magento2plugin.project;
 
+import com.intellij.notification.NotificationGroupManager;
 import com.intellij.notification.Notification;
 import com.intellij.notification.NotificationListener;
 import com.intellij.notification.NotificationType;
@@ -36,9 +37,13 @@ public void configureProject(
                 if (!MagentoBasePathUtil.isMagentoFolderValid(baseDir.getPath())) {
                     return;
                 }
-                final Notification notification = new Notification("Magento", "Magento",
-                        "<a href='enable'>Enable</a> Magento support for this project?",
-                        NotificationType.INFORMATION, new NotificationListener.Adapter() {
+                final Notification notification = NotificationGroupManager.getInstance()
+                        .getNotificationGroup("Magento Notifications")
+                        .createNotification(
+                                "Magento",
+                                "<a href='enable'>Enable</a> Magento support for this project?",
+                                NotificationType.INFORMATION
+                        ).setListener(new NotificationListener.Adapter() {
                             @Override
                             public void hyperlinkActivated(
                                     final @NotNull Notification notification,

src/main/java/com/magento/idea/magento2plugin/project/SettingsForm.java

@@ -195,8 +195,6 @@ private void addPathListener() {
                 FileChooserDescriptorFactory.createSingleFolderDescriptor();
         final ComponentWithBrowseButton.BrowseFolderActionListener<JTextField> browseFolderListener
                 = new ComponentWithBrowseButton.BrowseFolderActionListener<JTextField>(
-                "Magento Root Directory",
-                "Choose Magento root directory",
                 this.magentoPath,
                 project,
                 descriptor,

src/main/java/com/magento/idea/magento2plugin/util/magento/GetMagentoModuleUtil.java

@@ -10,7 +10,6 @@
 import com.intellij.psi.PsiElement;
 import com.intellij.psi.PsiFile;
 import com.intellij.psi.util.PsiTreeUtil;
-import com.intellij.util.SlowOperations;
 import com.jetbrains.php.lang.psi.elements.ClassConstantReference;
 import com.jetbrains.php.lang.psi.elements.MethodReference;
 import com.jetbrains.php.lang.psi.elements.StringLiteralExpression;
@@ -140,9 +139,7 @@ private static PsiFile getModuleRegistrationFile(
     private static String parseParameterValue(final PsiElement valueHolder) {
         if (valueHolder instanceof ClassConstantReference) {
             final ClassConstantReference constantReference = (ClassConstantReference) valueHolder;
-            final PsiElement resolved = SlowOperations.allowSlowOperations(
-                    constantReference::resolve
-            );
+            final PsiElement resolved = constantReference.resolve();
 
             if (!(resolved instanceof ClassConstImpl)) {
                 return null;