977: Code refactoring

Author: bohdan-harniuk

tests/com/magento/idea/magento2plugin/completion/xml/BackendModelXmlCompletionRegistrarTest.java

@@ -17,33 +17,45 @@ public class BackendModelXmlCompletionRegistrarTest extends CompletionXmlFixture
             "Magento\\Backend\\Model\\Source\\YesNo"
     };
 
+    /**
+     * Test system.xml file element completion.
+     */
     public void testSystemXmlElementProvideCompletion() {
         final String filePath = this.getFixturePath(ModuleSystemXmlFile.FILE_NAME);
         myFixture.configureByFile(filePath);
 
         assertCompletionContains(filePath, SYSTEM_XML_BACKEND_MODEL_LOOKUP_STRING_CHECK);
     }
 
+    /**
+     * Test system.xml file element completion won't show.
+     */
     public void testSystemXmlElementCompletionWontShow() {
         final String filePath = this.getFixturePath(
-            ModuleSystemXmlFile.FILE_NAME
+                ModuleSystemXmlFile.FILE_NAME
         );
         myFixture.copyFileToProject(filePath);
 
         assertCompletionNotShowing(filePath);
     }
 
+    /**
+     * Test system.xml backend model attribute match with the file.
+     */
     public void testSystemXmlBackendModelAttributeMatchWithFile() {
         final String filePath = this.getFixturePath(
-            ModuleSystemXmlFile.FILE_NAME
+                ModuleSystemXmlFile.FILE_NAME
         );
 
         assertFileContainsCompletions(filePath, SYSTEM_XML_BACKEND_MODEL_LOOKUP_STRING_CHECK);
     }
 
+    /**
+     * Test system.xml backend model attribute doesn't match with the file.
+     */
     public void testSystemXmlBackendModelAttributeDontMatchWithFile() {
         final String filePath = this.getFixturePath(
-            "other-file-than-system.xml"
+                "other-file-than-system.xml"
         );
 
         assertFileNotContainsCompletions(
@@ -52,35 +64,47 @@ public void testSystemXmlBackendModelAttributeDontMatchWithFile() {
         );
     }
 
+    /**
+     * Test config.xml file element completion.
+     */
     public void testConfigXmlElementProvideCompletion() {
         final String filePath = this.getFixturePath(
-            ModuleConfigXml.FILE_NAME
+                ModuleConfigXml.FILE_NAME
         );
         myFixture.copyFileToProject(filePath);
 
         assertCompletionContains(filePath, CONFIG_XML_BACKEND_MODEL_LOOKUP_STRING_CHECK);
     }
 
+    /**
+     * Test config.xml file element completion won't show.
+     */
     public void testConfigXmlElementCompletionWontShow() {
         final String filePath = this.getFixturePath(
-            ModuleConfigXml.FILE_NAME
+                ModuleConfigXml.FILE_NAME
         );
         myFixture.copyFileToProject(filePath);
 
         assertCompletionNotShowing(filePath);
     }
 
+    /**
+     * Test config.xml backend model attribute match with the file.
+     */
     public void testConfigXmlBackendModelAttributeMatchWithFile() {
         final String filePath = this.getFixturePath(
-            ModuleConfigXml.FILE_NAME
+                ModuleConfigXml.FILE_NAME
         );
 
         assertFileContainsCompletions(filePath, CONFIG_XML_BACKEND_MODEL_LOOKUP_STRING_CHECK);
     }
 
+    /**
+     * Test config.xml backend model attribute doesn't match with the file.
+     */
     public void testConfigXmlBackendModelAttributeDontMatchWithFile() {
         final String filePath = this.getFixturePath(
-            "other-file-than-config.xml"
+                "other-file-than-config.xml"
         );
 
         assertFileNotContainsCompletions(

tests/com/magento/idea/magento2plugin/completion/xml/SourceModelXmlCompletionRegistrarTest.java

@@ -7,58 +7,75 @@
 
 import com.magento.idea.magento2plugin.magento.files.ModuleSystemXmlFile;
 import com.magento.idea.magento2plugin.magento.files.ModuleWidgetXml;
-import java.io.IOException;
 
 public class SourceModelXmlCompletionRegistrarTest extends CompletionXmlFixtureTestCase {
 
     private static final String[] LOOKUP_STRINGS_CHECK = {
             "Magento\\Backend\\Model\\Source\\YesNo"
     };
 
+    /**
+     * Test source model xml element completion.
+     */
     public void testSourceModelXmlElementMustProvideCompletion() {
         final String filePath = this.getFixturePath(ModuleSystemXmlFile.FILE_NAME);
         myFixture.copyFileToProject(filePath);
 
         assertCompletionContains(filePath, LOOKUP_STRINGS_CHECK);
     }
 
+    /**
+     * Test source model xml element completion match with the file false positive.
+     */
     public void testSourceModelXmlElementMatchWithFilePositiveCase() {
         final String filePath = this.getFixturePath(ModuleSystemXmlFile.FILE_NAME);
         myFixture.copyFileToProject(filePath);
 
         assertFileContainsCompletions(filePath, LOOKUP_STRINGS_CHECK);
     }
 
+    /**
+     * Test source model xml element completion match with the file negative case.
+     */
     public void testSourceModelXmlElementMatchWithFileNegativeCase() {
         final String filePath = this.getFixturePath("not-system.xml");
         myFixture.copyFileToProject(filePath);
 
         assertFileNotContainsCompletions(
-            filePath,
+                filePath,
                 LOOKUP_STRINGS_CHECK
         );
     }
 
+    /**
+     * Test source model attribute must provide completion.
+     */
     public void testSourceModelXmlAttributeMustProvideCompletion() {
         final String filePath = this.getFixturePath(ModuleWidgetXml.FILE_NAME);
         myFixture.copyFileToProject(filePath);
 
         assertCompletionContains(filePath, LOOKUP_STRINGS_CHECK);
     }
 
+    /**
+     * Test source model attribute match with the file positive case.
+     */
     public void testSourceModelXmlAttributeMatchWithFilePositiveCase() {
         final String filePath = this.getFixturePath(ModuleWidgetXml.FILE_NAME);
         myFixture.copyFileToProject(filePath);
 
         assertFileContainsCompletions(filePath, LOOKUP_STRINGS_CHECK);
     }
 
-    public void testSourceModelXmlAttributeMatchWithFileNegativeCase() throws IOException {
+    /**
+     * Test source model attribute match with the file negative case.
+     */
+    public void testSourceModelXmlAttributeMatchWithFileNegativeCase() {
         final String filePath = this.getFixturePath("not-widget.xml");
         myFixture.copyFileToProject(filePath);
 
         assertFileNotContainsCompletions(
-            filePath,
+                filePath,
                 LOOKUP_STRINGS_CHECK
         );
     }