Skip to content

Commit bb64f30

Browse files
bohdan-harniukbohdan-harniuk
committed
Fixed issues with wrong xml and broken test cases
1 parent 519311b commit bb64f30

File tree

12 files changed

+54
-26
lines changed

12 files changed

+54
-26
lines changed

‎testData/inspections/xml/TypeConfigurationTagTypesInspection/argumentFactoryTypeExists/di.xml‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
<?xml version="1.0"?>
2-
<routes xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
3-
xsi:noNamespaceSchemaLocation="urn:magento:module:Magento_Webapi:etc/webapi.xsd">
2+
<config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
3+
xsi:noNamespaceSchemaLocation="urn:magento:framework:ObjectManager/etc/config.xsd">
44
<type name="Magento\Catalog\Api\ProductRepositoryInterface">
55
<arguments>
66
<argument name="test_parameter_2" xsi:type="object">Magento\Catalog\Api\ProductRepositoryInterfaceFactory</argument>
77
</arguments>
88
</type>
9-
</routes>
9+
</config>

‎testData/inspections/xml/TypeConfigurationTagTypesInspection/nameAttributeValueTypeDoesNotExist/di.xml‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
<?xml version="1.0"?>
2-
<routes xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
3-
xsi:noNamespaceSchemaLocation="urn:magento:module:Magento_Webapi:etc/webapi.xsd">
2+
<config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
3+
xsi:noNamespaceSchemaLocation="urn:magento:framework:ObjectManager/etc/config.xsd">
44
<type name="Not\Existent\Class"/>
5-
</routes>
5+
</config>

‎testData/inspections/xml/TypeConfigurationTagTypesInspection/nameAttributeValueTypeExists/di.xml‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
<?xml version="1.0"?>
2-
<routes xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
3-
xsi:noNamespaceSchemaLocation="urn:magento:module:Magento_Webapi:etc/webapi.xsd">
2+
<config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
3+
xsi:noNamespaceSchemaLocation="urn:magento:framework:ObjectManager/etc/config.xsd">
44
<type name="Magento\Catalog\Api\ProductRepositoryInterface"/>
5-
</routes>
5+
</config>

‎testData/inspections/xml/TypeConfigurationTagTypesInspection/recursivelyArgumentProxyTypeDoesNotExist/di.xml‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
<?xml version="1.0"?>
2-
<routes xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
3-
xsi:noNamespaceSchemaLocation="urn:magento:module:Magento_Webapi:etc/webapi.xsd">
2+
<config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
3+
xsi:noNamespaceSchemaLocation="urn:magento:framework:ObjectManager/etc/config.xsd">
44
<type name="Magento\Catalog\Api\ProductRepositoryInterface">
55
<arguments>
66
<argument name="test_parameter" xsi:type="array">
@@ -10,4 +10,4 @@
1010
</argument>
1111
</arguments>
1212
</type>
13-
</routes>
13+
</config>

‎testData/inspections/xml/TypeConfigurationTagTypesInspection/recursivelyArgumentProxyTypeExists/di.xml‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
<?xml version="1.0"?>
2-
<routes xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
3-
xsi:noNamespaceSchemaLocation="urn:magento:module:Magento_Webapi:etc/webapi.xsd">
2+
<config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
3+
xsi:noNamespaceSchemaLocation="urn:magento:framework:ObjectManager/etc/config.xsd">
44
<type name="Magento\Catalog\Api\ProductRepositoryInterface">
55
<arguments>
66
<argument name="test_parameter" xsi:type="array">
@@ -10,4 +10,4 @@
1010
</argument>
1111
</arguments>
1212
</type>
13-
</routes>
13+
</config>

‎testData/inspections/xml/TypeConfigurationTagTypesInspection/recursivelyArgumentVirtualTypeDoesNotExist/di.xml‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
<?xml version="1.0"?>
2-
<routes xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
3-
xsi:noNamespaceSchemaLocation="urn:magento:module:Magento_Webapi:etc/webapi.xsd">
2+
<config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
3+
xsi:noNamespaceSchemaLocation="urn:magento:framework:ObjectManager/etc/config.xsd">
44
<type name="Magento\Catalog\Api\ProductRepositoryInterface">
55
<arguments>
66
<argument name="test_parameter" xsi:type="array">
@@ -10,4 +10,4 @@
1010
</argument>
1111
</arguments>
1212
</type>
13-
</routes>
13+
</config>

‎testData/inspections/xml/TypeConfigurationTagTypesInspection/recursivelyArgumentVirtualTypeExists/di.xml‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
<?xml version="1.0"?>
2-
<routes xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
3-
xsi:noNamespaceSchemaLocation="urn:magento:module:Magento_Webapi:etc/webapi.xsd">
2+
<config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
3+
xsi:noNamespaceSchemaLocation="urn:magento:framework:ObjectManager/etc/config.xsd">
44
<type name="Magento\Catalog\Api\ProductRepositoryInterface">
55
<arguments>
66
<argument name="test_parameter" xsi:type="array">
@@ -10,4 +10,4 @@
1010
</argument>
1111
</arguments>
1212
</type>
13-
</routes>
13+
</config>

‎testData/project/magento2/app/code/Foo/Bar/etc/di.xml‎

Lines changed: 0 additions & 5 deletions
This file was deleted.

‎testData/project/magento2/app/code/Foo/Bar2/composer.json‎

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,17 @@
1+
{
2+
"name": "foo/bar2",
3+
"description": "N/A",
4+
"type": "magento2-module",
5+
"version": "1.0.0",
6+
"require": {
7+
"magento/framework": "*"
8+
},
9+
"autoload": {
10+
"files": [
11+
"registration.php"
12+
],
13+
"psr-4": {
14+
"Foo\\Bar2\\": ""
15+
}
16+
}
17+
}

‎testData/project/magento2/app/code/Foo/Bar2/etc/di.xml‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
<?xml version="1.0"?>
2+
<config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
3+
xsi:noNamespaceSchemaLocation="urn:magento:framework:ObjectManager/etc/config.xsd">
4+
<virtualType name="VirtualProductRepository" type="Magento\Catalog\Api\ProductRepositoryInterface"/>
5+
</config>

0 commit comments

Comments
 (0)