Fixed static tests

Author: Sergiy Zhovnir

src/com/magento/idea/magento2plugin/actions/generation/NewControllerAction.java

@@ -15,7 +15,6 @@
 import com.intellij.psi.PsiDirectory;
 import com.magento.idea.magento2plugin.MagentoIcons;
 import com.magento.idea.magento2plugin.actions.generation.dialog.NewControllerDialog;
-import org.jetbrains.annotations.NotNull;
 
 @SuppressWarnings({"PMD.OnlyOneReturn", "PMD.FieldNamingConventions"})
 public class NewControllerAction extends AnAction {
@@ -30,7 +29,7 @@ public NewControllerAction() {
     }
 
     @Override
-    public void actionPerformed(@NotNull AnActionEvent event) {
+    public void actionPerformed(final AnActionEvent event) {
         final DataContext dataContext = event.getDataContext();
         final IdeView view = LangDataKeys.IDE_VIEW.getData(dataContext);
 

src/com/magento/idea/magento2plugin/actions/generation/dialog/validator/CreateAPluginDialogValidator.java

@@ -19,6 +19,7 @@
         "PMD.OnlyOneReturn",
         "PMD.CyclomaticComplexity",
         "PMD.NonThreadSafeSingleton",
+        "PMD.ExcessiveMethodLength",
         "PMD.NPathComplexity",
         "PMD.FieldNamingConventions"
 })

src/com/magento/idea/magento2plugin/actions/generation/dialog/validator/CreateAnObserverDialogValidator.java

@@ -20,6 +20,7 @@
         "PMD.FieldNamingConventions",
         "PMD.CyclomaticComplexity",
         "PMD.NonThreadSafeSingleton",
+        "PMD.ExcessiveMethodLength",
         "PMD.DataflowAnomalyAnalysis",
         "PMD.NPathComplexity"
 })

src/com/magento/idea/magento2plugin/actions/generation/dialog/validator/NewCronjobValidator.java

@@ -22,6 +22,7 @@
         "PMD.DataflowAnomalyAnalysis",
         "PMD.CyclomaticComplexity",
         "PMD.NonThreadSafeSingleton",
+        "PMD.ExcessiveMethodLength",
         "PMD.NcssCount",
         "PMD.NPathComplexity"
 })

src/com/magento/idea/magento2plugin/actions/generation/dialog/validator/NewModuleDialogValidator.java

@@ -17,6 +17,7 @@
         "PMD.DataflowAnomalyAnalysis",
         "PMD.NonThreadSafeSingleton",
         "PMD.CyclomaticComplexity",
+        "PMD.ExcessiveMethodLength",
         "PMD.NPathComplexity"
 })
 public class NewModuleDialogValidator {
@@ -34,7 +35,7 @@ public class NewModuleDialogValidator {
      *
      * @return NewModuleDialogValidator
      */
-    public static NewModuleDialogValidator getInstance(NewModuleDialog dialog) {
+    public static NewModuleDialogValidator getInstance(final NewModuleDialog dialog) {
         if (null == INSTANCE) {
             INSTANCE = new NewModuleDialogValidator();
         }

src/com/magento/idea/magento2plugin/magento/files/Controller.java

@@ -5,7 +5,7 @@
 
 package com.magento.idea.magento2plugin.magento.files;
 
-@SuppressWarnings({"PMD.FieldNamingConventions", "PMD.UseUtilityClass"})
+@SuppressWarnings({"PMD.FieldNamingConventions", "PMD.ClassNamingConventions"})
 public class Controller {
     public static final String ADMINHTML_CONTROLLER_FQN =
             "Magento\\Backend\\App\\Action";

src/com/magento/idea/magento2plugin/magento/packages/HttpMethod.java

@@ -21,7 +21,7 @@ public enum HttpMethod {
      *
      * @param interfaceFqn String
      */
-    HttpMethod(String interfaceFqn) {
+    HttpMethod(final String interfaceFqn) {
         this.interfaceFqn = interfaceFqn;
     }