Skip to content

Commit 422fff4

Browse files
author
Serhiy Zhovnir
committed
fixing static tests
1 parent 7255394 commit 422fff4

File tree

4 files changed

+42
-20
lines changed

4 files changed

+42
-20
lines changed

src/com/magento/idea/magento2plugin/actions/generation/NewEmailTemplateAction.java

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,11 +6,15 @@
66
package com.magento.idea.magento2plugin.actions.generation;
77

88
import com.intellij.ide.IdeView;
9-
import com.intellij.openapi.actionSystem.*;
9+
import com.intellij.openapi.actionSystem.AnAction;
10+
import com.intellij.openapi.actionSystem.AnActionEvent;
11+
import com.intellij.openapi.actionSystem.CommonDataKeys;
12+
import com.intellij.openapi.actionSystem.DataContext;
13+
import com.intellij.openapi.actionSystem.LangDataKeys;
1014
import com.intellij.openapi.project.Project;
1115
import com.intellij.psi.PsiDirectory;
12-
import com.magento.idea.magento2plugin.MagentoIcons;
1316
import com.magento.idea.magento2plugin.actions.generation.dialog.NewEmailTemplateDialog;
17+
import com.magento.idea.magento2plugin.MagentoIcons;
1418

1519
@SuppressWarnings({"PMD.OnlyOneReturn", "PMD.FieldNamingConventions"})
1620
public class NewEmailTemplateAction extends AnAction {

src/com/magento/idea/magento2plugin/actions/generation/dialog/NewEmailTemplateDialog.java

Lines changed: 24 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@
77

88
import com.intellij.openapi.project.Project;
99
import com.intellij.psi.PsiDirectory;
10-
import com.magento.idea.magento2plugin.actions.generation.NewEmailTemplateAction;
1110
import com.magento.idea.magento2plugin.actions.generation.data.EmailTemplateHtmlData;
1211
import com.magento.idea.magento2plugin.actions.generation.data.EmailTemplatesXmlData;
1312
import com.magento.idea.magento2plugin.actions.generation.dialog.validator.annotation.FieldValidation;
@@ -16,23 +15,24 @@
1615
import com.magento.idea.magento2plugin.actions.generation.dialog.validator.rule.NotEmptyRule;
1716
import com.magento.idea.magento2plugin.actions.generation.generator.ModuleEmailTemplateHtmlGenerator;
1817
import com.magento.idea.magento2plugin.actions.generation.generator.ModuleEmailTemplatesXmlGenerator;
18+
import com.magento.idea.magento2plugin.actions.generation.NewEmailTemplateAction;
1919
import com.magento.idea.magento2plugin.magento.files.EmailTemplateHtml;
2020
import com.magento.idea.magento2plugin.magento.packages.Areas;
2121
import com.magento.idea.magento2plugin.ui.FilteredComboBox;
2222
import com.magento.idea.magento2plugin.util.magento.GetModuleNameByDirectoryUtil;
23-
import javax.swing.JPanel;
24-
import javax.swing.JComponent;
25-
import javax.swing.JButton;
26-
import javax.swing.KeyStroke;
27-
import javax.swing.JTextField;
28-
import java.awt.event.WindowEvent;
29-
import java.awt.event.WindowAdapter;
30-
import java.awt.event.ActionListener;
3123
import java.awt.event.ActionEvent;
24+
import java.awt.event.ActionListener;
3225
import java.awt.event.KeyEvent;
26+
import java.awt.event.WindowAdapter;
27+
import java.awt.event.WindowEvent;
3328
import java.util.ArrayList;
3429
import java.util.Arrays;
3530
import java.util.List;
31+
import javax.swing.JButton;
32+
import javax.swing.JComponent;
33+
import javax.swing.JPanel;
34+
import javax.swing.JTextField;
35+
import javax.swing.KeyStroke;
3636

3737
public class NewEmailTemplateDialog extends AbstractDialog {
3838
private final String moduleName;
@@ -60,6 +60,12 @@ public class NewEmailTemplateDialog extends AbstractDialog {
6060
private FilteredComboBox templateType;
6161
private JTextField subject;
6262

63+
/**
64+
* New email template dialog.
65+
*
66+
* @param project Project
67+
* @param directory Directory
68+
*/
6369
public NewEmailTemplateDialog(final Project project, final PsiDirectory directory) {
6470
setContentPane(contentPane);
6571
setModal(true);
@@ -79,11 +85,15 @@ public void windowClosing(final WindowEvent e) {
7985
});
8086

8187
// call onCancel() on ESCAPE
82-
contentPane.registerKeyboardAction(new ActionListener() {
83-
public void actionPerformed(ActionEvent e) {
84-
onCancel();
85-
}
86-
}, KeyStroke.getKeyStroke(KeyEvent.VK_ESCAPE, 0), JComponent.WHEN_ANCESTOR_OF_FOCUSED_COMPONENT);
88+
contentPane.registerKeyboardAction(
89+
new ActionListener() {
90+
public void actionPerformed(ActionEvent e) {
91+
onCancel();
92+
}
93+
},
94+
KeyStroke.getKeyStroke(KeyEvent.VK_ESCAPE, 0),
95+
JComponent.WHEN_ANCESTOR_OF_FOCUSED_COMPONENT
96+
);
8797
}
8898

8999
/**

src/com/magento/idea/magento2plugin/actions/generation/generator/ModuleEmailTemplatesXmlGenerator.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,9 +8,9 @@
88
import com.intellij.openapi.command.WriteCommandAction;
99
import com.intellij.openapi.editor.Document;
1010
import com.intellij.openapi.project.Project;
11+
import com.intellij.psi.codeStyle.CodeStyleManager;
1112
import com.intellij.psi.PsiDocumentManager;
1213
import com.intellij.psi.PsiFile;
13-
import com.intellij.psi.codeStyle.CodeStyleManager;
1414
import com.intellij.psi.util.PsiTreeUtil;
1515
import com.intellij.psi.xml.XmlAttributeValue;
1616
import com.intellij.psi.xml.XmlFile;
@@ -23,10 +23,10 @@
2323
import com.magento.idea.magento2plugin.bundles.ValidatorBundle;
2424
import com.magento.idea.magento2plugin.magento.files.EmailTemplatesXml;
2525
import com.magento.idea.magento2plugin.util.xml.XmlPsiTreeUtil;
26-
import javax.swing.JOptionPane;
2726
import java.io.IOException;
2827
import java.util.Collection;
2928
import java.util.Properties;
29+
import javax.swing.JOptionPane;
3030

3131
@SuppressWarnings({"PMD.AvoidPrintStackTrace"})
3232
public class ModuleEmailTemplatesXmlGenerator extends FileGenerator {

tests/com/magento/idea/magento2plugin/actions/generation/generator/ModuleEmailTemplateHtmlGeneratorTest.java

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,11 @@ public void testGenerateEmailTemplateHtml() {
3939
area
4040
);
4141

42-
assertGeneratedFileIsCorrect(expectedFile, getExpectedDirectory(area), emailTemplateXmlFile);
42+
assertGeneratedFileIsCorrect(
43+
expectedFile,
44+
getExpectedDirectory(area),
45+
emailTemplateXmlFile
46+
);
4347
}
4448

4549
/**
@@ -62,7 +66,11 @@ public void testGenerateEmailTemplateText() {
6266
area
6367
);
6468

65-
assertGeneratedFileIsCorrect(expectedFile, getExpectedDirectory(area), emailTemplateXmlFile);
69+
assertGeneratedFileIsCorrect(
70+
expectedFile,
71+
getExpectedDirectory(area),
72+
emailTemplateXmlFile
73+
);
6674
}
6775

6876
/**

0 commit comments

Comments
 (0)