Fixed test class static check issues

Author: bohdan-harniuk

src/com/magento/idea/magento2plugin/actions/generation/generator/code/util/ConvertPluginParamsToString.java

@@ -42,7 +42,7 @@ private ConvertPluginParamsToString() {}
      *
      * @return String
      */
-    @SuppressWarnings({"PMD.NPathComplexity", "PMD.CyclomaticComplexity"})
+    @SuppressWarnings({"PMD.NPathComplexity", "PMD.CyclomaticComplexity", "PMD.ConfusingTernary"})
     public static String execute(
             final Collection<PsiElement> parameters,
             final @NotNull Plugin.PluginType type,

tests/com/magento/idea/magento2plugin/actions/generation/generator/PluginClassGeneratorTest.java

@@ -16,13 +16,13 @@
 
 public class PluginClassGeneratorTest extends BaseGeneratorTestCase {
 
-    private static final String targetClassFnq = "Foo\\Bar\\Service\\SimpleService";
-    private static final String targetMethodName = "execute";
-    private static final String module = "Foo_Bar";
-    private static final String pluginNamespace = "Foo\\Bar\\Plugin";
-    private static final String pluginFqn = "Foo\\Bar\\Plugin\\TestPlugin";
-    private static final String pluginClassName = "TestPlugin";
-    private static final String pluginDir = "Plugin";
+    private static final String TARGET_CLASS_FQN = "Foo\\Bar\\Service\\SimpleService";
+    private static final String TARGET_METHOD_NAME = "execute";
+    private static final String MODULE_NAME = "Foo_Bar";
+    private static final String PLUGIN_NAMESPACE = "Foo\\Bar\\Plugin";
+    private static final String PLUGIN_FQN = "Foo\\Bar\\Plugin\\TestPlugin";
+    private static final String PLUGIN_CLASS_NAME = "TestPlugin";
+    private static final String PLUGIN_DIR = "Plugin";
 
     /**
      * Test of plugin generation.
@@ -33,8 +33,8 @@ public void testGeneratePluginClassFile() {
         addPluginToTargetClass(Plugin.PluginType.around.toString());
         pluginClassFile = addPluginToTargetClass(Plugin.PluginType.after.toString());
 
-        String filePath = this.getFixturePath(pluginClassName.concat(".php"));
-        PsiFile expectedFile = myFixture.configureByFile(filePath);
+        final String filePath = this.getFixturePath(PLUGIN_CLASS_NAME.concat(".php"));
+        final PsiFile expectedFile = myFixture.configureByFile(filePath);
 
         assertGeneratedFileIsCorrect(
                 expectedFile,
@@ -51,21 +51,22 @@ public void testGeneratePluginClassFile() {
      * @return PsiFile
      */
     private PsiFile addPluginToTargetClass(final @NotNull String pluginType) {
-        Project project = myFixture.getProject();
-        PhpClass targetClass = GetPhpClassByFQN.getInstance(project).execute(targetClassFnq);
-        Method targetMethod = targetClass.findMethodByName(targetMethodName);
+        final Project project = myFixture.getProject();
+        final PhpClass targetClass = 
+                GetPhpClassByFQN.getInstance(project).execute(TARGET_CLASS_FQN);
+        final Method targetMethod = targetClass.findMethodByName(TARGET_METHOD_NAME);
 
-        PluginFileData pluginClass = new PluginFileData(
-                pluginDir,
-                pluginClassName,
+        final PluginFileData pluginClass = new PluginFileData(
+                PLUGIN_DIR,
+                PLUGIN_CLASS_NAME,
                 pluginType,
-                module,
+                MODULE_NAME,
                 targetClass,
                 targetMethod,
-                pluginFqn,
-                pluginNamespace
+                PLUGIN_FQN,
+                PLUGIN_NAMESPACE
         );
-        PluginClassGenerator pluginClassGenerator = new PluginClassGenerator(
+        final PluginClassGenerator pluginClassGenerator = new PluginClassGenerator(
                 pluginClass,
                 project
         );