409: Added target type suggestion

Author: bohdan-harniuk

src/com/magento/idea/magento2plugin/actions/generation/dialog/NewArgumentInjectionDialog.java

@@ -15,6 +15,7 @@
 import com.intellij.ui.EditorTextField;
 import com.jetbrains.php.PhpIndex;
 import com.jetbrains.php.completion.PhpCompletionUtil;
+import com.jetbrains.php.lang.PhpLangUtil;
 import com.jetbrains.php.lang.psi.elements.Field;
 import com.jetbrains.php.lang.psi.elements.Parameter;
 import com.jetbrains.php.lang.psi.elements.PhpClass;
@@ -33,11 +34,13 @@
 import com.magento.idea.magento2plugin.magento.packages.Areas;
 import com.magento.idea.magento2plugin.magento.packages.DiArgumentType;
 import com.magento.idea.magento2plugin.ui.FilteredComboBox;
+import com.magento.idea.magento2plugin.util.php.PhpTypeMetadataParserUtil;
 import java.awt.event.ActionListener;
 import java.awt.event.KeyEvent;
 import java.awt.event.WindowAdapter;
 import java.awt.event.WindowEvent;
 import java.util.ArrayList;
+import java.util.Arrays;
 import java.util.Collection;
 import java.util.List;
 import javax.swing.JButton;
@@ -69,6 +72,7 @@ public class NewArgumentInjectionDialog extends AbstractDialog {
 
     private final @NotNull Project project;
     private final PhpClass targetClass;
+    private final Parameter targetParameter;
 
     private JPanel contentPane;
     private JButton buttonCancel;
@@ -172,6 +176,7 @@ public NewArgumentInjectionDialog(
 
         this.project = project;
         this.targetClass = targetClass;
+        targetParameter = parameter;
         arrayValues = new DiArrayValueData();
 
         setContentPane(contentPane);
@@ -333,6 +338,7 @@ public void documentChanged(final @NotNull DocumentEvent event) {
                 }
             }
         });
+        guessTargetType();
     }
 
     /**
@@ -618,6 +624,39 @@ private void changeViewBySelectedArgumentType(final String itemValue) {
         return "";
     }
 
+    @SuppressWarnings("PMD.CyclomaticComplexity")
+    private void guessTargetType() {
+        final String mainType = PhpTypeMetadataParserUtil.getMainType(targetParameter);
+
+        if (mainType == null) {
+            return;
+        }
+        String targetDiType = "";
+
+        if (Arrays.asList("int", "float").contains(mainType)) {
+            targetDiType = DiArgumentType.NUMBER.getArgumentType();
+        } else if (DiArgumentType.STRING.getArgumentType().equals(mainType)) {
+            targetDiType = DiArgumentType.STRING.getArgumentType();
+        } else if ("bool".equals(mainType)) {
+            targetDiType = DiArgumentType.BOOLEAN.getArgumentType();
+        } else if (PhpLangUtil.isFqn(mainType)) {
+            targetDiType = DiArgumentType.OBJECT.getArgumentType();
+        } else if ("array".equals(mainType)) {
+            targetDiType = DiArgumentType.ARRAY.getArgumentType();
+        }
+
+        if (targetDiType.isEmpty()) {
+            return;
+        }
+
+        for (int i = 0; i < argumentType.getItemCount(); i++) {
+            if (targetDiType.equals(argumentType.getItemAt(i).getKey())) {
+                argumentType.setSelectedIndex(i);
+                break;
+            }
+        }
+    }
+
     private DiArgumentData getDialogDataObject() {
         if (targetArea.getSelectedItem() == null) {
             showErrorMessage(new ValidatorBundle().message(NotEmptyRule.MESSAGE, TARGET_AREA));

src/com/magento/idea/magento2plugin/util/php/PhpTypeMetadataParserUtil.java

@@ -135,7 +135,12 @@ public static List<Method> getMethodsByNames(
      *
      * @return String
      */
-    @SuppressWarnings({"PMD.CyclomaticComplexity", "PMD.NPathComplexity", "PMD.ConfusingTernary"})
+    @SuppressWarnings({
+            "PMD.CyclomaticComplexity",
+            "PMD.CognitiveComplexity",
+            "PMD.NPathComplexity",
+            "PMD.ConfusingTernary"
+    })
     public static String getMethodDefinitionForInterface(
             final @NotNull Method method,
             final String defaultMethodDescription
@@ -269,6 +274,29 @@ public static List<String> getMethodParametersTypes(final @NotNull Method method
         return types;
     }
 
+    /**
+     * Get main type for the specified parameter (?int -> main type is int).
+     *
+     * @param parameter Parameter
+     *
+     * @return String
+     */
+    public static String getMainType(final @NotNull Parameter parameter) {
+        final List<String> types = extractMultipleTypesFromString(
+                parameter.getDeclaredType().toString()
+        );
+
+        for (final String type : types) {
+            if (PhpLangUtil.isFqn(type)) {
+                return type;
+            } else if (PhpLangUtil.isParameterTypeHint(type, parameter.getProject())) {
+                return type;
+            }
+        }
+
+        return null;
+    }
+
     /**
      * Get method return type.
      *
@@ -309,6 +337,7 @@ public static String getMethodReturnType(final @NotNull Method method) {
      *
      * @return List[String]
      */
+    @SuppressWarnings("PMD.CognitiveComplexity")
     public static List<String> getMethodExceptionsTypes(final @NotNull Method method) {
         final List<String> types = new ArrayList<>();