Fixed PMD issues

Author: drpayyne

src/com/magento/idea/magento2plugin/reference/xml/PolyVariantReferenceBase.java

@@ -18,30 +18,33 @@ public class PolyVariantReferenceBase extends PsiPolyVariantReferenceBase<PsiEle
     /**
      * Target elements.
      */
-    private Collection<? extends PsiElement> targets;
+    private final Collection<? extends PsiElement> targets;
 
-    public PolyVariantReferenceBase(PsiElement element, Collection<? extends PsiElement> targets) {
+    public PolyVariantReferenceBase(
+            final PsiElement element,
+            final Collection<? extends PsiElement> targets
+    ) {
         super(element);
         this.targets = targets;
     }
 
     public PolyVariantReferenceBase(
-            PsiElement element,
-            TextRange range,
-            Collection<? extends PsiElement> targets
+            final PsiElement element,
+            final TextRange range,
+            final Collection<? extends PsiElement> targets
     ) {
         super(element, range);
         this.targets = targets;
     }
 
     @NotNull
     @Override
-    public ResolveResult[] multiResolve(boolean incompleteCode) {
+    public ResolveResult[] multiResolve(final boolean incompleteCode) {
         ResolveResult[] resolveResults = new ResolveResult[targets.size()];
 
-        int i = 0;
-        for (PsiElement target : targets) {
-            resolveResults[i++] = new PsiElementResolveResult(target);
+        int index = 0;
+        for (final PsiElement target : targets) {
+            resolveResults[index++] = new PsiElementResolveResult(target);//NOPMD
         }
         return resolveResults;
     }

tests/com/magento/idea/magento2plugin/reference/BaseReferenceTestCase.java

@@ -168,12 +168,16 @@ protected void assertHasReferencetoConstructorParameter(
             fail(referenceNotFound);
         }
 
-        String parameterClassFqn = ((Parameter) reference.resolve())
+        final String parameterClassFqn = ((Parameter) reference.resolve())
                 .getLocalType().toStringResolved();
-        String parameterName = ((Parameter) reference.resolve()).getName();
-
-        assertEquals(parameterClassFqn, argumentClassFqn);
-        assertEquals(parameterName, argumentName);
+        final String parameterName = ((Parameter) reference.resolve()).getName();
+
+        assertEquals("Class name in argument equals class name in parameter",
+                parameterClassFqn,
+                argumentClassFqn);
+        assertEquals("Variable name in argument equals variable name in parameter",
+                parameterName,
+                argumentName);
     }
 
     protected void assertEmptyReference() {