Skip to content

Commit 0f8f13c

Browse files
committed
Fixed PHP Class validation
1 parent 5c49d0f commit 0f8f13c

File tree

3 files changed

+5
-8
lines changed

3 files changed

+5
-8
lines changed

src/com/magento/idea/magento2plugin/actions/generation/dialog/CreateAPluginDialog.java

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -13,13 +13,11 @@
1313
import com.magento.idea.magento2plugin.actions.generation.data.PluginFileData;
1414
import com.magento.idea.magento2plugin.actions.generation.dialog.validator.annotation.FieldValidation;
1515
import com.magento.idea.magento2plugin.actions.generation.dialog.validator.annotation.RuleRegistry;
16-
import com.magento.idea.magento2plugin.actions.generation.dialog.validator.rule.AlphanumericRule;
1716
import com.magento.idea.magento2plugin.actions.generation.dialog.validator.rule.DirectoryRule;
1817
import com.magento.idea.magento2plugin.actions.generation.dialog.validator.rule.IdentifierRule;
1918
import com.magento.idea.magento2plugin.actions.generation.dialog.validator.rule.NotEmptyRule;
2019
import com.magento.idea.magento2plugin.actions.generation.dialog.validator.rule.NumericRule;
2120
import com.magento.idea.magento2plugin.actions.generation.dialog.validator.rule.PhpClassRule;
22-
import com.magento.idea.magento2plugin.actions.generation.dialog.validator.rule.StartWithNumberOrCapitalLetterRule;
2321
import com.magento.idea.magento2plugin.actions.generation.generator.PluginClassGenerator;
2422
import com.magento.idea.magento2plugin.actions.generation.generator.PluginDiXmlGenerator;
2523
import com.magento.idea.magento2plugin.indexes.ModuleIndex;
@@ -73,10 +71,6 @@ public class CreateAPluginDialog extends AbstractDialog {
7371
message = {NotEmptyRule.MESSAGE, CLASS_NAME})
7472
@FieldValidation(rule = RuleRegistry.PHP_CLASS,
7573
message = {PhpClassRule.MESSAGE, CLASS_NAME})
76-
@FieldValidation(rule = RuleRegistry.ALPHANUMERIC,
77-
message = {AlphanumericRule.MESSAGE, CLASS_NAME})
78-
@FieldValidation(rule = RuleRegistry.START_WITH_NUMBER_OR_CAPITAL_LETTER,
79-
message = {StartWithNumberOrCapitalLetterRule.MESSAGE, CLASS_NAME})
8074
private JTextField pluginClassName;
8175

8276
@FieldValidation(rule = RuleRegistry.NOT_EMPTY,

src/com/magento/idea/magento2plugin/actions/generation/dialog/validator/rule/PhpClassRule.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,15 +5,15 @@
55

66
package com.magento.idea.magento2plugin.actions.generation.dialog.validator.rule;
77

8-
import com.jetbrains.php.refactoring.PhpNameUtil;
8+
import com.magento.idea.magento2plugin.util.RegExUtil;
99

1010
public class PhpClassRule implements ValidationRule {
1111
public static final String MESSAGE = "validator.class.isNotValid";
1212
private static final ValidationRule INSTANCE = new PhpClassRule();
1313

1414
@Override
1515
public boolean check(final String value) {
16-
return PhpNameUtil.isValidClassName(value);
16+
return value.matches(RegExUtil.Magento.PHP_CLASS);
1717
}
1818

1919
public static ValidationRule getInstance() {

src/com/magento/idea/magento2plugin/util/RegExUtil.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,9 @@ public class RegExUtil {
3232
= "(\\d+)\\.(\\d+)\\.(\\d+)[a-zA-Z0-9_\\-]*";
3333

3434
public static class Magento {
35+
public static final String PHP_CLASS
36+
= "[A-Z][a-zA-Z0-9]+";
37+
3538
public static final String MODULE_NAME
3639
= "[A-Z][a-zA-Z0-9]+_[A-Z][a-zA-Z0-9]+";
3740

0 commit comments

Comments
 (0)