Static fixes

Author: Vitaliy Boyko

tests/com/magento/idea/magento2plugin/actions/generation/generator/BaseGeneratorTestCase.java

@@ -2,6 +2,7 @@
  * Copyright © Magento, Inc. All rights reserved.
  * See COPYING.txt for license details.
  */
+
 package com.magento.idea.magento2plugin.actions.generation.generator;
 
 import com.intellij.psi.PsiDirectory;
@@ -10,43 +11,48 @@
 import com.magento.idea.magento2plugin.BaseProjectTestCase;
 import com.magento.idea.magento2plugin.magento.packages.File;
 import com.magento.idea.magento2plugin.project.util.GetProjectBasePath;
+import org.junit.After;
 import org.junit.Before;
 
-abstract public class BaseGeneratorTestCase extends BaseProjectTestCase {
-    private static final String testDataFolderPath = "testData" + File.separator + "actions" + File.separator;
-    private static final String fixturesFolderPath = "generation" + File.separator + "generator" + File.separator;
+public abstract class BaseGeneratorTestCase extends BaseProjectTestCase {
+    private static final String TEST_DATA_FOLDER_PATH = "testData" + File.separator
+            + "actions" + File.separator;
+    private static final String FIXTURES_FOLDER_PATH = "generation" + File.separator
+            + "generator" + File.separator;
 
     @Override
     @Before
     protected void setUp() throws Exception {
         super.setUp();
-        myFixture.setTestDataPath(testDataFolderPath);
+        myFixture.setTestDataPath(TEST_DATA_FOLDER_PATH);
     }
 
     @Override
+    @After
     protected void tearDown() throws Exception {
         super.tearDown();
         LightPlatformTestCase.closeAndDeleteProject();
     }
 
-    protected String getFixturePath(String fileName) {
-        return prepareFixturePath(fileName, fixturesFolderPath);
+    protected String getFixturePath(final String fileName) {
+        return prepareFixturePath(fileName, FIXTURES_FOLDER_PATH);
     }
 
+    @SuppressWarnings({"PMD.JUnitAssertionsShouldIncludeMessage"})
     protected void assertGeneratedFileIsCorrect(
-        PsiFile expectedFile,
-        String expectedDirectory,
-        PsiFile resultFile) {
-
+            final PsiFile expectedFile,
+            final String expectedDirectory,
+            final PsiFile resultFile
+    ) {
         assertTrue(resultFile.getContainingDirectory().getVirtualFile().getPath()
-            .endsWith(expectedDirectory));
+                .endsWith(expectedDirectory));
         assertEquals(expectedFile.getText(), resultFile.getText());
         assertEquals(expectedFile.getName(), resultFile.getName());
     }
 
     protected PsiDirectory getProjectDirectory() {
         return myFixture.getPsiManager().findDirectory(
-            GetProjectBasePath.execute(myFixture.getProject())
+                GetProjectBasePath.execute(myFixture.getProject())
         );
     }
 }

tests/com/magento/idea/magento2plugin/actions/generation/generator/ModuleRegistrationPhpGeneratorTest.java

@@ -2,6 +2,7 @@
  * Copyright © Magento, Inc. All rights reserved.
  * See COPYING.txt for license details.
  */
+
 package com.magento.idea.magento2plugin.actions.generation.generator;
 
 import com.intellij.openapi.project.Project;
@@ -12,6 +13,9 @@
 
 public class ModuleRegistrationPhpGeneratorTest extends BaseGeneratorTestCase {
 
+    /**
+     * Test for generation of registration.php file.
+     */
     public void testGenerateRegistrationPhpFile() {
         final String filePath = this.getFixturePath(RegistrationPhp.FILE_NAME);
         final PsiFile expectedFile = myFixture.configureByFile(filePath);
@@ -23,9 +27,10 @@ public void testGenerateRegistrationPhpFile() {
                 projectDir,
                 true
         );
-        final ModuleRegistrationPhpGenerator moduleRegistrationPhpGenerator = new ModuleRegistrationPhpGenerator(
-                moduleRegistrationPhpData,
-                project
+        final ModuleRegistrationPhpGenerator moduleRegistrationPhpGenerator
+                = new ModuleRegistrationPhpGenerator(
+                    moduleRegistrationPhpData,
+                    project
         );
         final PsiFile registrationPhp = moduleRegistrationPhpGenerator.generate("test");
         assertGeneratedFileIsCorrect(
@@ -35,8 +40,10 @@ public void testGenerateRegistrationPhpFile() {
         );
     }
 
-    public void testGenerateRegistrationPhpFileInRoot()
-    {
+    /**
+     * Test for generation of registration.php file for a module project.
+     */
+    public void testGenerateRegistrationPhpFileInRoot() {
         final String filePath = this.getFixturePath(RegistrationPhp.FILE_NAME);
         final PsiFile expectedFile = myFixture.configureByFile(filePath);
         final Project project = myFixture.getProject();
@@ -47,9 +54,10 @@ public void testGenerateRegistrationPhpFileInRoot()
                 projectDir,
                 false
         );
-        final ModuleRegistrationPhpGenerator moduleRegistrationPhpGenerator = new ModuleRegistrationPhpGenerator(
-                moduleRegistrationPhpData,
-                project
+        final ModuleRegistrationPhpGenerator moduleRegistrationPhpGenerator
+                = new ModuleRegistrationPhpGenerator(
+                    moduleRegistrationPhpData,
+                    project
         );
         final PsiFile registrationPhp = moduleRegistrationPhpGenerator.generate("test");
         assertGeneratedFileIsCorrect(