2880: static fixes 6

Author: VitaliyBoyko

src/main/java/com/magento/idea/magento2plugin/actions/generation/dialog/NewCustomerEavAttributeDialog.java

@@ -50,7 +50,8 @@
         "PMD.TooManyFields",
         "PMD.ExcessiveImports",
         "PMD.TooManyMethods",
-        "PMD.UnusedPrivateField"
+        "PMD.UnusedPrivateField",
+        "PMD.GodClass"
 })
 public class NewCustomerEavAttributeDialog extends AbstractDialog {
 
@@ -173,6 +174,7 @@ protected void initDialogState() {
     /**
      * Fill attribute type combo box.
      */
+    @SuppressWarnings("PMD.AvoidInstantiatingObjectsInLoops")
     protected void fillAttributeTypeComboBox() {
         if (typeComboBox == null) {
             return;
@@ -188,6 +190,7 @@ protected void fillAttributeTypeComboBox() {
     /**
      * Fill attribute input combo box.
      */
+    @SuppressWarnings("PMD.AvoidInstantiatingObjectsInLoops")
     protected void fillAttributeInputComboBox() {
         if (inputComboBox == null) {
             return;
@@ -540,7 +543,11 @@ protected void generateExtraFilesBeforeDataPatchGeneration() {
      */
     protected void generateExtraFilesAfterDataPatchGeneration(
             final EavEntityDataInterface eavEntityDataInterface
-    ) {}
+    ) {
+        // This method is intentionally left empty.
+        // No additional files need to be generated after the data patch for customer EAV attributes.
+        // Subclasses may override this method to provide specific implementation if needed.
+    }
 
     /**
      * Create center panel.

src/main/java/com/magento/idea/magento2plugin/actions/generation/dialog/NewProductEavAttributeDialog.java

@@ -56,7 +56,8 @@
         "PMD.TooManyFields",
         "PMD.ExcessiveImports",
         "PMD.TooManyMethods",
-        "PMD.UnusedPrivateField"
+        "PMD.UnusedPrivateField",
+        "PMD.GodClass"
 })
 public class NewProductEavAttributeDialog extends AbstractDialog {
 
@@ -189,6 +190,7 @@ protected void initDialogState() {
     /**
      * Fill attribute type combo box.
      */
+    @SuppressWarnings("PMD.AvoidInstantiatingObjectsInLoops")
     protected void fillAttributeTypeComboBox() {
         if (typeComboBox == null) {
             return;
@@ -204,6 +206,7 @@ protected void fillAttributeTypeComboBox() {
     /**
      * Fill attribute input combo box.
      */
+    @SuppressWarnings("PMD.AvoidInstantiatingObjectsInLoops")
     protected void fillAttributeInputComboBox() {
         if (inputComboBox == null) {
             return;
@@ -587,7 +590,11 @@ protected void generateExtraFilesBeforeDataPatchGeneration() {
      */
     protected void generateExtraFilesAfterDataPatchGeneration(
             final EavEntityDataInterface eavEntityDataInterface
-    ) {}
+    ) {
+        // This method is intentionally left empty.
+        // No additional files need to be generated after the data patch for product EAV attributes.
+        // Subclasses may override this method to provide specific implementation if needed.
+    }
 
     /**
      * Create center panel.