Merge pull request #498 from magento/MQE-1870

MFTF 2.5.3 + MQE-1870

Author: KevinBKozan

CHANGELOG.md

@@ -1,5 +1,11 @@
 Magento Functional Testing Framework Changelog
 ================================================
+2.5.3
+-----
+
+### Fixes
+* Fixed an issue where `createData` actions would cause an exception when used in `<suite>` hooks.
+
 2.5.2
 -----
 

bin/mftf

@@ -29,7 +29,7 @@ try {
 try {
     $application = new Symfony\Component\Console\Application();
     $application->setName('Magento Functional Testing Framework CLI');
-    $application->setVersion('2.5.2');
+    $application->setVersion('2.5.3');
     /** @var \Magento\FunctionalTestingFramework\Console\CommandListInterface $commandList */
     $commandList = new \Magento\FunctionalTestingFramework\Console\CommandList;
     foreach ($commandList->getCommands() as $command) {

composer.json

@@ -2,7 +2,7 @@
     "name": "magento/magento2-functional-testing-framework",
     "description": "Magento2 Functional Testing Framework",
     "type": "library",
-    "version": "2.5.2",
+    "version": "2.5.3",
     "license": "AGPL-3.0",
     "keywords": ["magento", "automation", "functional", "testing"],
     "config": {

composer.lock

@@ -34,6 +34,11 @@ public static function addAttachmentToLastStep($data, $caption)
         $rootStep = Allure::lifecycle()->getStepStorage()->getLast();
         $trueLastStep = array_last($rootStep->getSteps());
 
+        if ($trueLastStep == null) {
+            // Nothing to attach to; do not fire off allure event
+            return;
+        }
+
         $attachmentEvent = new AddAttachmentEvent($data, $caption);
         $attachmentEvent->process($trueLastStep);
     }

src/Magento/FunctionalTestingFramework/Allure/AllureHelper.php

@@ -66,7 +66,7 @@ class TestDependencyCheck implements StaticCheckInterface
      * Array containing all errors found after running the execute() function.
      * @var array
      */
-    private $errors;
+    private $errors = [];
 
     /**
      * String representing the output summary found after running the execute() function.