MQE-610:[PHPMD] Reduce Cyclomatic Complexity in Problem Methods

fixed as per review comments

Author: soumyau

src/Magento/FunctionalTestingFramework/Config/FileResolver/Module.php

@@ -26,7 +26,6 @@ class Module implements FileResolverInterface
      * Module constructor.
      * @param ModuleResolver|null $moduleResolver
      * @SuppressWarnings(PHPMD.UnusedFormalParameter)
-     * @TODO ported magento code - to be refactored later
      */
     public function __construct(ModuleResolver $moduleResolver = null)
     {

src/Magento/FunctionalTestingFramework/DataGenerator/Objects/EntityDataObject.php

@@ -9,6 +9,7 @@
 use Magento\FunctionalTestingFramework\Config\MftfApplicationConfig;
 use Magento\FunctionalTestingFramework\DataGenerator\Util\GenerationDataReferenceResolver;
 use Magento\FunctionalTestingFramework\Exceptions\TestFrameworkException;
+use Magento\FunctionalTestingFramework\Exceptions\TestReferenceException;
 use Magento\FunctionalTestingFramework\Util\Logger\LoggingUtil;
 
 /**
@@ -189,7 +190,7 @@ public function getDataByName($name, $uniquenessFormat)
      * @param integer $uniquenessFormat
      * @return string|null
      * @throws TestFrameworkException
-     * @throws \Magento\FunctionalTestingFramework\Exceptions\TestReferenceException
+     * @throws TestReferenceException
      */
     private function resolveDataReferences($name, $uniquenessFormat)
     {

src/Magento/FunctionalTestingFramework/DataGenerator/Persist/OperationDataArrayResolver.php

@@ -13,6 +13,7 @@
 use Magento\FunctionalTestingFramework\DataGenerator\Util\OperationElementExtractor;
 use Magento\FunctionalTestingFramework\DataGenerator\Util\RuntimeDataReferenceResolver;
 use Magento\FunctionalTestingFramework\Exceptions\TestFrameworkException;
+use Magento\FunctionalTestingFramework\Exceptions\TestReferenceException;
 
 class OperationDataArrayResolver
 {
@@ -126,9 +127,9 @@ public function resolveOperationDataArray($entityObject, $operationMetadata, $op
      * Resolve data references at run time.
      * @param array            $operationDataArray
      * @param EntityDataObject $entityObject
-     * @return mixed
+     * @return array
      * @throws TestFrameworkException
-     * @throws \Magento\FunctionalTestingFramework\Exceptions\TestReferenceException
+     * @throws TestReferenceException
      */
     private function resolveRunTimeDataReferences($operationDataArray, $entityObject)
     {

src/Magento/FunctionalTestingFramework/ObjectManager/Config/Config.php

@@ -207,20 +207,19 @@ protected function mergeConfiguration(array $configuration)
                     break;
 
                 default:
-                    $this->setArguments($key, $curConfig);
-                    break;
+                    $this->setConfiguration($key, $curConfig);
             }
         }
     }
 
     /**
-     * Set arguments
+     * Set configuration
      *
      * @param string $key
      * @param array  $config
      * @return void
      */
-    private function setArguments($key, $config)
+    private function setConfiguration($key, $config)
     {
         $key = ltrim($key, '\\');
         if (isset($config['type'])) {

src/Magento/FunctionalTestingFramework/ObjectManager/Config/Mapper/Dom.php

@@ -80,8 +80,7 @@ public function convert($config)
                             $typeData['type'] = $attributeType->nodeValue;
                         }
                     }
-                    $typeArguments = $this->parseTypeArguments($node);
-                    $typeData['arguments'] = $typeArguments;
+                    $typeData['arguments'] = $this->setTypeArguments($node);
                     $output[$typeNodeAttributes->getNamedItem('name')->nodeValue] = $typeData;
                     break;
                 default:
@@ -93,12 +92,14 @@ public function convert($config)
     }
 
     /** Read typeChildNodes and set typeArguments
-     * @param $node
+     * @param DOMNode $node
      * @return mixed
      * @throws \Exception
      */
-    private function parseTypeArguments($node)
+    private function setTypeArguments($node)
     {
+        $typeArguments = [];
+
         foreach ($node->childNodes as $typeChildNode) {
             /** @var \DOMNode $typeChildNode */
             if ($typeChildNode->nodeType != XML_ELEMENT_NODE) {
@@ -117,13 +118,14 @@ private function parseTypeArguments($node)
                             $argumentData
                         );
                     }
-                    return $typeArguments;
+                    break;
 
                 default:
                     throw new \Exception(
                         "Invalid application config. Unknown node: {$typeChildNode->nodeName}."
                     );
             }
         }
+        return $typeArguments;
     }
 }

src/Magento/FunctionalTestingFramework/StaticCheck/TestDependencyCheck.php

@@ -186,7 +186,7 @@ private function findErrorsInFileSet($files)
             $this->resolveEntityReferences($extendReferences[1]);
 
             // Find violating references and set error output
-            $violatingReferences = $this->findViolatingReferences($filePath);
+            $violatingReferences = $this->findViolatingReferences($moduleFullName);
             $testErrors = $this->setErrorOutput($violatingReferences, $filePath);
         }
         return $testErrors;