add exception assert

Author: glo00108

dev/tests/unit/Magento/FunctionalTestFramework/DataGenerator/Handlers/SecretStorage/FileStorageTest.php

@@ -8,27 +8,30 @@
 namespace tests\unit\Magento\FunctionalTestFramework\DataGenerator\Handlers\SecretStorage;
 
 use Magento\FunctionalTestingFramework\DataGenerator\Handlers\SecretStorage\FileStorage;
+use Magento\FunctionalTestingFramework\Exceptions\TestFrameworkException;
 use ReflectionClass;
+use ReflectionException;
 use tests\unit\Util\MagentoTestCase;
 
 class FileStorageTest extends MagentoTestCase
 {
     /**
      * Test basic encryption/decryption functionality in FileStorage class.
+     * @throws TestFrameworkException|ReflectionException
      */
     public function testBasicEncryptDecrypt(): void
     {
         $testKey = 'magento/myKey';
         $testValue = 'myValue';
-        $creds = ["$testKey=$testValue"];
+        $cred = ["$testKey=$testValue"];
 
         $fileStorage = new FileStorage();
         $reflection = new ReflectionClass(FileStorage::class);
 
         // Emulate initialize() function result with the test credentials
         $reflectionMethod = $reflection->getMethod('encryptCredFileContents');
         $reflectionMethod->setAccessible(true);
-        $secretData = $reflectionMethod->invokeArgs($fileStorage, [$creds]);
+        $secretData = $reflectionMethod->invokeArgs($fileStorage, [$cred]);
 
         // Set encrypted test credentials to the private 'secretData' property
         $reflectionProperty = $reflection->getProperty('secretData');
@@ -48,34 +51,29 @@ public function testBasicEncryptDecrypt(): void
 
     /**
      * Test empty value encryption/decryption functionality in FileStorage class.
+     * @return void
+     * @throws TestFrameworkException|ReflectionException
      */
     public function testEmptyValueEncryptDecrypt(): void
     {
-      $testKey = 'magento/myKey';
-      $testValue = '';
-      $creds = ["$testKey"];
+        $this->expectException(TestFrameworkException::class);
 
-      $fileStorage = new FileStorage();
-      $reflection = new ReflectionClass(FileStorage::class);
-
-      // Emulate initialize() function result with the test credentials
-      $reflectionMethod = $reflection->getMethod('encryptCredFileContents');
-      $reflectionMethod->setAccessible(true);
-      $secretData = $reflectionMethod->invokeArgs($fileStorage, [$creds]);
-
-      // Set encrypted test credentials to the private 'secretData' property
-      $reflectionProperty = $reflection->getProperty('secretData');
-      $reflectionProperty->setAccessible(true);
-      $reflectionProperty->setValue($fileStorage, $secretData);
+        $testKey = 'magento/myKey';
+        $cred = ["$testKey"];
 
-      $encryptedCred = $fileStorage->getEncryptedValue($testKey);
+        $fileStorage = new FileStorage();
+        $reflection = new ReflectionClass(FileStorage::class);
 
-      // assert the value we've gotten is in fact not identical to our test value
-      $this->assertNotEquals($testValue, $encryptedCred);
+        // Emulate initialize() function result with the test credentials
+        $reflectionMethod = $reflection->getMethod('encryptCredFileContents');
+        $reflectionMethod->setAccessible(true);
+        $secretData = $reflectionMethod->invokeArgs($fileStorage, [$cred]);
 
-      $actualValue = $fileStorage->getDecryptedValue($encryptedCred);
+        // Set encrypted test credentials to the private 'secretData' property
+        $reflectionProperty = $reflection->getProperty('secretData');
+        $reflectionProperty->setAccessible(true);
+        $reflectionProperty->setValue($fileStorage, $secretData);
 
-      // assert that we are able to successfully decrypt our secret value
-      $this->assertEquals($testValue, $actualValue);
+        $fileStorage->getEncryptedValue($testKey);
     }
 }