MQE-1884: MFTF - <after> failures override other failures

bumped up codeception version to 2.4.5 to be inline with magento version. Removed method runAfterBlock, 2.4.5 runs _after hook implicitly.

Author: soumyau

composer.json

@@ -12,7 +12,7 @@
         "php": "7.0.2||7.0.4||~7.0.6||~7.1.0||~7.2.0||~7.3.0",
         "ext-curl": "*",
         "allure-framework/allure-codeception": "~1.3.0",
-        "codeception/codeception": "~2.3.4 || ~2.4.0 ",
+        "codeception/codeception": "~2.4.5",
         "composer/composer": "^1.6",
         "consolidation/robo": "^1.0.0",
         "csharpru/vault-php": "~3.5.3",

composer.lock

@@ -18,7 +18,6 @@
 class TestContextExtension extends BaseExtension
 {
     const TEST_PHASE_AFTER = "_after";
-    const CODECEPT_AFTER_VERSION = "2.3.9";
     const TEST_FAILED_FILE = 'failed';
 
     /**
@@ -64,15 +63,8 @@ public function testStart()
      */
     public function testFail(\Codeception\Event\FailEvent $e)
     {
-        $cest = $e->getTest();
         //log suppressed exception in case of _after hook failure
         $this->logPreviousException($e->getFail());
-        $context = $this->extractContext($e->getFail()->getTrace(), $cest->getTestMethod());
-        // Do not attempt to run _after if failure was in the _after block
-        // Try to run _after but catch exceptions to prevent them from overwriting original failure.
-        if ($context != TestContextExtension::TEST_PHASE_AFTER) {
-            $this->runAfterBlock($e, $cest);
-        }
     }
 
     /**
@@ -98,13 +90,6 @@ function () use ($cest) {
                 if ($error->failedTest()->getTestMethod() == $cest->getName()) {
                     //log suppressed exception in case of _after hook failure
                     $this->logPreviousException($error->thrownException());
-                    $stack = $error->thrownException()->getTrace();
-                    $context = $this->extractContext($stack, $cest->getTestMethod());
-                    // Do not attempt to run _after if failure was in the _after block
-                    // Try to run _after but catch exceptions to prevent them from overwriting original failure.
-                    if ($context != TestContextExtension::TEST_PHASE_AFTER) {
-                        $this->runAfterBlock($e, $cest);
-                    }
                     continue;
                 }
             }
@@ -113,31 +98,6 @@ function () use ($cest) {
         $this->getDriver()->_runAfter($e->getTest());
     }
 
-    /**
-     * Runs cest's after block, if necessary.
-     * @param \Symfony\Component\EventDispatcher\Event $e
-     * @param \Codeception\TestInterface               $cest
-     * @return void
-     */
-    private function runAfterBlock($e, $cest)
-    {
-        try {
-            $actorClass = $e->getTest()->getMetadata()->getCurrent('actor');
-            $I = new $actorClass($cest->getScenario());
-            if (version_compare(\Codeception\Codecept::VERSION, TestContextExtension::CODECEPT_AFTER_VERSION, "<=")) {
-                call_user_func(\Closure::bind(
-                    function () use ($cest, $I) {
-                        $cest->executeHook($I, 'after');
-                    },
-                    null,
-                    $cest
-                ));
-            }
-        } catch (\Exception $e) {
-            // Do not rethrow Exception
-        }
-    }
-
     /**
      * Extracts hook method from trace, looking specifically for the cest class given.
      * @param array  $trace
@@ -170,10 +130,6 @@ public function logPreviousException(\Exception $exception)
             }
         };
         $firstException = $change->call($exception);
-        $bind = function () use ($firstException) {
-            $exception = $firstException;
-        };
-        $bind->call($exception);
         if ($firstException !== null) {
             AllureHelper::addAttachmentToCurrentStep($firstException, 'Exception');
         }