MQE-1606: Mftf static check script should return error exit code when check fails

Author: tomreece

src/Magento/FunctionalTestingFramework/Console/StaticChecksCommand.php

@@ -47,10 +47,20 @@ protected function configure()
     protected function execute(InputInterface $input, OutputInterface $output)
     {
         $staticCheckObjects = $this->staticChecksList->getStaticChecks();
+
+        $errors = [];
+
         foreach ($staticCheckObjects as $staticCheck) {
             $staticOutput = $staticCheck->execute($input);
             LoggingUtil::getInstance()->getLogger(get_class($staticCheck))->info($staticOutput);
             $output->writeln($staticOutput);
+            $errors += $staticCheck->getErrors();
+        }
+
+        if (empty($errors)) {
+            return 0;
+        } else {
+            return 1;
         }
     }
 }

src/Magento/FunctionalTestingFramework/StaticCheck/StaticCheckInterface.php

@@ -19,4 +19,10 @@ interface StaticCheckInterface
      * @return string
      */
     public function execute(InputInterface $input);
+
+    /**
+     * Return array containing all errors found after running the execute() function.
+     * @return array
+     */
+    public function getErrors();
 }

src/Magento/FunctionalTestingFramework/StaticCheck/TestDependencyCheck.php

@@ -62,6 +62,12 @@ class TestDependencyCheck implements StaticCheckInterface
      */
     private $alreadyExtractedDependencies;
 
+    /**
+     * Array containing all errors found after running the execute() function.
+     * @var array
+     */
+    private $errors;
+
     /**
      * Checks test dependencies, determined by references in tests versus the dependencies listed in the Magento module
      *
@@ -98,13 +104,22 @@ public function execute(InputInterface $input)
         $actionGroupXmlFiles = $this->buildFileList($allModules, $filePaths[1]);
         $dataXmlFiles= $this->buildFileList($allModules, $filePaths[2]);
 
-        $testErrors = [];
-        $testErrors += $this->findErrorsInFileSet($testXmlFiles);
-        $testErrors += $this->findErrorsInFileSet($actionGroupXmlFiles);
-        $testErrors += $this->findErrorsInFileSet($dataXmlFiles);
+        $this->errors = [];
+        $this->errors += $this->findErrorsInFileSet($testXmlFiles);
+        $this->errors += $this->findErrorsInFileSet($actionGroupXmlFiles);
+        $this->errors += $this->findErrorsInFileSet($dataXmlFiles);
 
         //print all errors to file
-        return $this->printErrorsToFile($testErrors);
+        return $this->printErrorsToFile($this->getErrors());
+    }
+
+    /**
+     * Return array containing all errors found after running the execute() function.
+     * @return array
+     */
+    public function getErrors()
+    {
+        return $this->errors;
     }
 
     /**