Skip to content

Commit cbff68a

Browse files
manjusha729Manjusha.SKevinBKozan
authored
MQE-3300 : Show credentials in allure report for suite (#186)
* MQE-3300 : Show credentials in allure report for suite * MQE-3300 : Show credentials in allure report for suite * fixed verification test failure * fixed verification test failure * fixed verification test failure * added deleted line back * remove new line space from creds * get credentials for hook actions * fix psr * MQE-3300 : Show credentials in allure report for suite - Small change to secret message Co-authored-by: Manjusha.S <manjusha.s@BLR1-LMC-N71373.local> Co-authored-by: Kevin Kozan <kkozan@magento.com> Co-authored-by: Kevin Kozan <kkozan@adobe.com>
1 parent 499fe9a commit cbff68a

File tree

7 files changed

+211
-60
lines changed

7 files changed

+211
-60
lines changed

‎dev/tests/unit/Magento/FunctionalTestFramework/Test/Objects/ActionGroupObjectTest.php‎

Lines changed: 94 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ public function testGetStepsWithDefaultCase(): void
4949
$this->setEntityObjectHandlerReturn($entity);
5050
$actionGroupUnderTest = (new ActionGroupObjectBuilder())->build();
5151
$steps = $actionGroupUnderTest->getSteps(null, self::ACTION_GROUP_MERGE_KEY);
52-
$this->assertOnMergeKeyAndActionValue($steps, ['userInput' => 'literal']);
52+
$this->assertOnMergeKeyAndActionValue($steps, ['userInput' => 'literal', 'requiredCredentials' => '']);
5353
}
5454

5555
/**
@@ -67,30 +67,48 @@ public function testGetStepsWithCustomArgs(): void
6767
});
6868

6969
$actionGroupUnderTest = (new ActionGroupObjectBuilder())
70-
->withActionObjects([new ActionObject('action1', 'testAction', ['userInput' => '{{arg1.field2}}'])])
71-
->withArguments([new ArgumentObject('arg1', null, 'entity')])
72-
->build();
70+
->withActionObjects([new ActionObject(
71+
'action1',
72+
'testAction',
73+
[
74+
'userInput' => '{{arg1.field2}}','requiredCredentials' => ''
75+
]
76+
)])
77+
->withArguments([new ArgumentObject('arg1', null, 'entity')])
78+
->build();
7379

7480
$steps = $actionGroupUnderTest->getSteps(['arg1' => 'data2'], self::ACTION_GROUP_MERGE_KEY);
75-
$this->assertOnMergeKeyAndActionValue($steps, ['userInput' => 'testValue2']);
81+
$this->assertOnMergeKeyAndActionValue($steps, ['userInput' => 'testValue2','requiredCredentials' => '']);
7682

7783
// entity.field as argument
7884
$actionGroupUnderTest = (new ActionGroupObjectBuilder())
79-
->withActionObjects([new ActionObject('action1', 'testAction', ['userInput' => '{{arg1}}'])])
85+
->withActionObjects([new ActionObject(
86+
'action1',
87+
'testAction',
88+
['userInput' => '{{arg1}}',
89+
'requiredCredentials' => ''
90+
]
91+
)])
8092
->withArguments([new ArgumentObject('arg1', null, 'entity')])
8193
->build();
8294

8395
$steps = $actionGroupUnderTest->getSteps(['arg1' => 'data2.field2'], self::ACTION_GROUP_MERGE_KEY);
84-
$this->assertOnMergeKeyAndActionValue($steps, ['userInput' => 'testValue2']);
96+
$this->assertOnMergeKeyAndActionValue($steps, ['userInput' => 'testValue2', 'requiredCredentials' => '']);
8597

8698
// String Data
8799
$actionGroupUnderTest = (new ActionGroupObjectBuilder())
88-
->withActionObjects([new ActionObject('action1', 'testAction', ['userInput' => '{{simple}}'])])
100+
->withActionObjects([new ActionObject(
101+
'action1',
102+
'testAction',
103+
['userInput' => '{{simple}}',
104+
'requiredCredentials' => ''
105+
]
106+
)])
89107
->withArguments([new ArgumentObject('simple', null, 'string')])
90108
->build();
91109

92110
$steps = $actionGroupUnderTest->getSteps(['simple' => 'override'], self::ACTION_GROUP_MERGE_KEY);
93-
$this->assertOnMergeKeyAndActionValue($steps, ['userInput' => 'override']);
111+
$this->assertOnMergeKeyAndActionValue($steps, ['userInput' => 'override', 'requiredCredentials' => '']);
94112
}
95113

96114
/**
@@ -102,21 +120,32 @@ public function testGetStepsWithCustomArgs(): void
102120
public function testGetStepsWithPersistedArgs(): void
103121
{
104122
$actionGroupUnderTest = (new ActionGroupObjectBuilder())
105-
->withActionObjects([new ActionObject('action1', 'testAction', ['userInput' => '{{arg1.field2}}'])])
123+
->withActionObjects([new ActionObject(
124+
'action1',
125+
'testAction',
126+
['userInput' => '{{arg1.field2}}',
127+
'requiredCredentials' => '']
128+
)])
106129
->withArguments([new ArgumentObject('arg1', null, 'entity')])
107130
->build();
108131

109132
$steps = $actionGroupUnderTest->getSteps(['arg1' => '$data3$'], self::ACTION_GROUP_MERGE_KEY);
110-
$this->assertOnMergeKeyAndActionValue($steps, ['userInput' => '$data3.field2$']);
133+
$this->assertOnMergeKeyAndActionValue($steps, ['userInput' => '$data3.field2$','requiredCredentials' => '']);
111134

112135
// Simple Data
113136
$actionGroupUnderTest = (new ActionGroupObjectBuilder())
114-
->withActionObjects([new ActionObject('action1', 'testAction', ['userInput' => '{{simple}}'])])
137+
->withActionObjects([new ActionObject(
138+
'action1',
139+
'testAction',
140+
['userInput' => '{{simple}}',
141+
'requiredCredentials' => ''
142+
]
143+
)])
115144
->withArguments([new ArgumentObject('simple', null, 'string')])
116145
->build();
117146

118147
$steps = $actionGroupUnderTest->getSteps(['simple' => '$data3.field2$'], self::ACTION_GROUP_MERGE_KEY);
119-
$this->assertOnMergeKeyAndActionValue($steps, ['userInput' => '$data3.field2$']);
148+
$this->assertOnMergeKeyAndActionValue($steps, ['userInput' => '$data3.field2$','requiredCredentials' => '']);
120149
}
121150

122151
/**
@@ -134,12 +163,18 @@ public function testGetStepsWithNoFieldArg(): void
134163
});
135164

136165
$actionGroupUnderTest = (new ActionGroupObjectBuilder())
137-
->withActionObjects([new ActionObject('action1', 'testAction', ['userInput' => '{{arg1}}'])])
166+
->withActionObjects([new ActionObject(
167+
'action1',
168+
'testAction',
169+
['userInput' => '{{arg1}}',
170+
'requiredCredentials' => ''
171+
]
172+
)])
138173
->withArguments([new ArgumentObject('arg1', null, 'entity')])
139174
->build();
140175

141176
$steps = $actionGroupUnderTest->getSteps(['arg1' => 'data2.field2'], self::ACTION_GROUP_MERGE_KEY);
142-
$this->assertOnMergeKeyAndActionValue($steps, ['userInput' => 'testValue2']);
177+
$this->assertOnMergeKeyAndActionValue($steps, ['userInput' => 'testValue2','requiredCredentials' => '']);
143178
}
144179

145180
/**
@@ -157,11 +192,17 @@ public function testGetStepsWithNoArgs(): void
157192
});
158193

159194
$actionGroupUnderTest = (new ActionGroupObjectBuilder())
160-
->withActionObjects([new ActionObject('action1', 'testAction', ['userInput' => '{{data1.field1}}'])])
195+
->withActionObjects([new ActionObject(
196+
'action1',
197+
'testAction',
198+
['userInput' => '{{data1.field1}}',
199+
'requiredCredentials' => ''
200+
]
201+
)])
161202
->build();
162203

163204
$steps = $actionGroupUnderTest->getSteps(null, self::ACTION_GROUP_MERGE_KEY);
164-
$this->assertOnMergeKeyAndActionValue($steps, ['userInput' => 'testValue']);
205+
$this->assertOnMergeKeyAndActionValue($steps, ['userInput' => 'testValue','requiredCredentials' => '']);
165206
}
166207

167208
/**
@@ -199,11 +240,22 @@ public function testGetStepsWithParameterizedArg(): void
199240

200241
// XML Data
201242
$steps = $actionGroupUnderTest->getSteps(['arg1' => 'data2'], self::ACTION_GROUP_MERGE_KEY);
202-
$this->assertOnMergeKeyAndActionValue($steps, ['selector' => '.selector testValue2']);
243+
$this->assertOnMergeKeyAndActionValue($steps, [
244+
'selector' => '.selector testValue2',
245+
'requiredCredentials' => ''
246+
]);
203247

204248
// Persisted Data
205-
$steps = $actionGroupUnderTest->getSteps(['arg1' => '$data2$'], self::ACTION_GROUP_MERGE_KEY);
206-
$this->assertOnMergeKeyAndActionValue($steps, ['selector' => '.selector $data2.field2$']);
249+
$steps = $actionGroupUnderTest->getSteps(
250+
['arg1' => '$data2$'],
251+
self::ACTION_GROUP_MERGE_KEY
252+
);
253+
$this->assertOnMergeKeyAndActionValue(
254+
$steps,
255+
['selector' => '.selector $data2.field2$',
256+
'requiredCredentials' => ''
257+
]
258+
);
207259
}
208260

209261
/**
@@ -242,15 +294,28 @@ public function testGetStepsWithParameterizedSimpleArg(): void
242294

243295
// String Literal
244296
$steps = $actionGroupUnderTest->getSteps(['simple' => 'stringLiteral'], self::ACTION_GROUP_MERGE_KEY);
245-
$this->assertOnMergeKeyAndActionValue($steps, ['selector' => '.selector stringLiteral']);
297+
$this->assertOnMergeKeyAndActionValue($steps, [
298+
'selector' => '.selector stringLiteral',
299+
'requiredCredentials' => ''
300+
]);
246301

247302
// String Literal w/ data-like structure
248303
$steps = $actionGroupUnderTest->getSteps(['simple' => 'data2.field2'], self::ACTION_GROUP_MERGE_KEY);
249-
$this->assertOnMergeKeyAndActionValue($steps, ['selector' => '.selector data2.field2']);
304+
$this->assertOnMergeKeyAndActionValue(
305+
$steps,
306+
['selector' => '.selector data2.field2',
307+
'requiredCredentials' => ''
308+
]
309+
);
250310

251311
// Persisted Data
252312
$steps = $actionGroupUnderTest->getSteps(['simple' => '$someData.field1$'], self::ACTION_GROUP_MERGE_KEY);
253-
$this->assertOnMergeKeyAndActionValue($steps, ['selector' => '.selector $someData.field1$']);
313+
$this->assertOnMergeKeyAndActionValue(
314+
$steps,
315+
['selector' => '.selector $someData.field1$',
316+
'requiredCredentials' => ''
317+
]
318+
);
254319
}
255320

256321
/**
@@ -267,7 +332,12 @@ public function testGetStepsWithOuterScopePersistence(): void
267332
->build();
268333

269334
$steps = $actionGroupUnderTest->getSteps(['arg1' => '$$someData$$'], self::ACTION_GROUP_MERGE_KEY);
270-
$this->assertOnMergeKeyAndActionValue($steps, ['userInput' => '$$someData.field1$$']);
335+
$this->assertOnMergeKeyAndActionValue(
336+
$steps,
337+
['userInput' => '$$someData.field1$$',
338+
'requiredCredentials' => ''
339+
]
340+
);
271341
}
272342

273343
/**

‎dev/tests/unit/Magento/FunctionalTestFramework/Test/Objects/ActionObjectTest.php‎

Lines changed: 34 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,8 @@ public function testResolveElementInSelector(): void
7171
// Set up mocks
7272
$actionObject = new ActionObject('merge123', 'fillField', [
7373
'selector' => '{{SectionObject.elementObject}}',
74-
'userInput' => 'Hello world'
74+
'userInput' => 'Hello world',
75+
'requiredCredentials' => ''
7576
]);
7677
$elementObject = new ElementObject('elementObject', 'button', '#replacementSelector', null, '42', false);
7778
$this->mockSectionHandlerWithElement($elementObject);
@@ -82,7 +83,8 @@ public function testResolveElementInSelector(): void
8283
// Verify
8384
$expected = [
8485
'selector' => '#replacementSelector',
85-
'userInput' => 'Hello world'
86+
'userInput' => 'Hello world',
87+
'requiredCredentials' => ''
8688
];
8789
$this->assertEquals($expected, $actionObject->getCustomActionAttributes());
8890
}
@@ -98,7 +100,8 @@ public function testResolveSelectorWithOneStringLiteral(): void
98100
{
99101
$actionObject = new ActionObject('key123', 'fillField', [
100102
'selector' => "{{SectionObject.elementObject('stringliteral')}}",
101-
'userInput' => 'Input'
103+
'userInput' => 'Input',
104+
'requiredCredentials' => ''
102105
]);
103106
$elementObject = new ElementObject('elementObject', 'button', '#{{var1}}', null, '42', true);
104107
$this->mockSectionHandlerWithElement($elementObject);
@@ -109,7 +112,8 @@ public function testResolveSelectorWithOneStringLiteral(): void
109112
// Verify
110113
$expected = [
111114
'selector' => '#stringliteral',
112-
'userInput' => 'Input'
115+
'userInput' => 'Input',
116+
'requiredCredentials' => ''
113117
];
114118
$this->assertEquals($expected, $actionObject->getCustomActionAttributes());
115119
}
@@ -125,7 +129,8 @@ public function testResolveSelectorWithOneDataReference(): void
125129
{
126130
$actionObject = new ActionObject('key123', 'fillField', [
127131
'selector' => "{{SectionObject.elementObject(dataObject.key)}}",
128-
'userInput' => 'Input'
132+
'userInput' => 'Input',
133+
'requiredCredentials' => ''
129134
]);
130135

131136
// Mock SectionHandler
@@ -142,7 +147,8 @@ public function testResolveSelectorWithOneDataReference(): void
142147
// Verify
143148
$expected = [
144149
'selector' => '#myValue',
145-
'userInput' => 'Input'
150+
'userInput' => 'Input',
151+
'requiredCredentials' => ''
146152
];
147153
$this->assertEquals($expected, $actionObject->getCustomActionAttributes());
148154
}
@@ -158,7 +164,8 @@ public function testResolveSelectorWithOnePersistedReference(): void
158164
{
159165
$actionObject = new ActionObject('key123', 'fillField', [
160166
'selector' => '{{SectionObject.elementObject($data.key$)}}',
161-
'userInput' => 'Input'
167+
'userInput' => 'Input',
168+
'requiredCredentials' => ''
162169
]);
163170

164171
// Mock SectionHandler
@@ -171,7 +178,8 @@ public function testResolveSelectorWithOnePersistedReference(): void
171178
// Verify
172179
$expected = [
173180
'selector' => '#$data.key$',
174-
'userInput' => 'Input'
181+
'userInput' => 'Input',
182+
'requiredCredentials' => ''
175183
];
176184
$this->assertEquals($expected, $actionObject->getCustomActionAttributes());
177185
}
@@ -204,7 +212,8 @@ public function testResolveSelectorWithManyParams(): void
204212
// Verify
205213
$expected = [
206214
'selector' => '#stringLiteral[myValue,$data.key$]',
207-
'userInput' => 'Input'
215+
'userInput' => 'Input',
216+
'requiredCredentials' => ''
208217
];
209218
$this->assertEquals($expected, $actionObject->getCustomActionAttributes());
210219
}
@@ -260,7 +269,7 @@ public function testResolveUrl(): void
260269

261270
// Verify
262271
$expected = [
263-
'url' => '/replacement/url.html'
272+
'url' => '/replacement/url.html','requiredCredentials' => ''
264273
];
265274
$this->assertEquals($expected, $actionObject->getCustomActionAttributes());
266275
}
@@ -330,7 +339,8 @@ public function testResolveDataInUserInput(): void
330339
// Set up mocks
331340
$actionObject = new ActionObject('merge123', 'fillField', [
332341
'selector' => '#selector',
333-
'userInput' => '{{EntityDataObject.key}}'
342+
'userInput' => '{{EntityDataObject.key}}',
343+
'requiredCredentials' => ''
334344
]);
335345
$entityDataObject = new EntityDataObject('EntityDataObject', 'test', [
336346
'key' => 'replacementData'
@@ -343,7 +353,8 @@ public function testResolveDataInUserInput(): void
343353
// Verify
344354
$expected = [
345355
'selector' => '#selector',
346-
'userInput' => 'replacementData'
356+
'userInput' => 'replacementData',
357+
'requiredCredentials' => ''
347358
];
348359
$this->assertEquals($expected, $actionObject->getCustomActionAttributes());
349360
}
@@ -360,7 +371,8 @@ public function testResolveArrayData(): void
360371
// Set up mocks
361372
$actionObject = new ActionObject('merge123', 'fillField', [
362373
'selector' => '#selector',
363-
'userInput' => '{{EntityDataObject.values}}'
374+
'userInput' => '{{EntityDataObject.values}}',
375+
'requiredCredentials' => ''
364376
]);
365377
$entityDataObject = new EntityDataObject('EntityDataObject', 'test', [
366378
'values' => [
@@ -373,11 +385,11 @@ public function testResolveArrayData(): void
373385

374386
// Call the method under test
375387
$actionObject->resolveReferences();
376-
377-
// Verify
388+
//Verify
378389
$expected = [
379390
'selector' => '#selector',
380-
'userInput' => '["value1","value2","\"My\" Value"]'
391+
'userInput' => '["value1","value2","\"My\" Value"]',
392+
'requiredCredentials' => ''
381393
];
382394
$this->assertEquals($expected, $actionObject->getCustomActionAttributes());
383395
}
@@ -395,7 +407,8 @@ public function testTooFewArgumentException(): void
395407

396408
$actionObject = new ActionObject('key123', 'fillField', [
397409
'selector' => "{{SectionObject.elementObject('arg1')}}",
398-
'userInput' => 'Input'
410+
'userInput' => 'Input',
411+
'requiredCredentials' => ''
399412
]);
400413
$elementObject = new ElementObject('elementObject', 'button', '#{{var1}} {{var2}}', null, '42', true);
401414
$this->mockSectionHandlerWithElement($elementObject);
@@ -417,7 +430,8 @@ public function testTooManyArgumentException(): void
417430

418431
$actionObject = new ActionObject('key123', 'fillField', [
419432
'selector' => "{{SectionObject.elementObject('arg1', 'arg2', 'arg3')}}",
420-
'userInput' => 'Input'
433+
'userInput' => 'Input',
434+
'requiredCredentials' => ''
421435
]);
422436
$elementObject = new ElementObject('elementObject', 'button', '#{{var1}}', null, '42', true);
423437
$this->mockSectionHandlerWithElement($elementObject);
@@ -438,7 +452,8 @@ public function testInvalidTimezoneException(): void
438452
$this->expectException(TestReferenceException::class);
439453

440454
$actionObject = new ActionObject('key123', 'generateDate', [
441-
'timezone' => "INVALID_TIMEZONE"
455+
'timezone' => "INVALID_TIMEZONE",
456+
'requiredCredentials' => ''
442457
]);
443458

444459
// Call the method under test

0 commit comments

Comments
 (0)