MQE-1520: Consolidate WAIT_TIMEOUT in .env and pageload_timeout in config

- changed functional.suite.dist to use wait timeout
- added default setters in bootstrap files (will always be defined)
- removed default in actionObject

Author: KevinBKozan

dev/tests/functional/standalone_bootstrap.php

@@ -49,7 +49,10 @@
 
     defined('DEFAULT_TIMEZONE') || define('DEFAULT_TIMEZONE', 'America/Los_Angeles');
     $env->setEnvironmentVariable('DEFAULT_TIMEZONE', DEFAULT_TIMEZONE);
-    
+
+    defined('WAIT_TIMEOUT') || define('WAIT_TIMEOUT', 10);
+    $env->setEnvironmentVariable('WAIT_TIMEOUT', 10);
+
     try {
         new DateTimeZone(DEFAULT_TIMEZONE);
     } catch (\Exception $e) {

etc/config/functional.suite.dist.yml

@@ -27,7 +27,7 @@ modules:
             window_size: 1280x1024
             username: "%MAGENTO_ADMIN_USERNAME%"
             password: "%MAGENTO_ADMIN_PASSWORD%"
-            pageload_timeout: 30
+            pageload_timeout: "%WAIT_TIMEOUT%"
             host: "%SELENIUM_HOST%"
             port: "%SELENIUM_PORT%"
             protocol: "%SELENIUM_PROTOCOL%"

src/Magento/FunctionalTestingFramework/Test/Objects/ActionObject.php

@@ -71,7 +71,6 @@ class ActionObject
     const ACTION_ATTRIBUTE_VARIABLE_REGEX_PARAMETER = '/\(.+\)/';
     const ACTION_ATTRIBUTE_VARIABLE_REGEX_PATTERN = '/({{[\w]+\.[\w\[\]]+}})|({{[\w]+\.[\w]+\((?(?!}}).)+\)}})/';
     const STRING_PARAMETER_REGEX = "/'[^']+'/";
-    const DEFAULT_WAIT_TIMEOUT = 10;
     const ACTION_ATTRIBUTE_USERINPUT = 'userInput';
     const ACTION_TYPE_COMMENT = 'comment';
 
@@ -167,7 +166,7 @@ public function __construct(
      */
     public static function getDefaultWaitTimeout()
     {
-        return getenv('WAIT_TIMEOUT') ?: self::DEFAULT_WAIT_TIMEOUT;
+        return getenv('WAIT_TIMEOUT');
     }
 
     /**

src/Magento/FunctionalTestingFramework/_bootstrap.php

@@ -50,6 +50,9 @@
     defined('DEFAULT_TIMEZONE') || define('DEFAULT_TIMEZONE', 'America/Los_Angeles');
     $env->setEnvironmentVariable('DEFAULT_TIMEZONE', DEFAULT_TIMEZONE);
 
+    defined('WAIT_TIMEOUT') || define('WAIT_TIMEOUT', 10);
+    $env->setEnvironmentVariable('WAIT_TIMEOUT', 10);
+
     try {
         new DateTimeZone(DEFAULT_TIMEZONE);
     } catch (\Exception $e) {