MQE-1161: Extended Tests With No Parents Are Skipped (#204)

* MQE-1161: Extended Tests With No Parents Are Skipped

- Tests are not generated if they are skipped
- Modified verification test to reflect change

* MQE-1161: Extended Tests With No Parents Are Skipped

- Updated skip flagging to use new skip annotation

* MQE-1161: Extended Tests With No Parents Are Skipped

- Updated conditional to check for parent test existence
- Added console information in addition to the log

* MQE-1161: Extended Tests With No Parents Are Skipped

- Updated message to be more explicit

Author: aljcalandra

dev/tests/verification/Tests/ExtendedGenerationTest.php

@@ -5,6 +5,8 @@
  */
 namespace tests\verification\Tests;
 
+use Magento\FunctionalTestingFramework\Test\Handlers\TestObjectHandler;
+use Magento\FunctionalTestingFramework\Util\TestGenerator;
 use tests\util\MftfTestCase;
 
 class ExtendedGenerationTest extends MftfTestCase
@@ -87,14 +89,23 @@ public function testExtendedTestGenerationRemoveHookAction()
     }
 
     /**
-     * Tests generation of test that attemps to extend a test that doesn't exist
+     * Tests to ensure extended tests with no parents are not generated
      *
      * @throws \Exception
      * @throws \Magento\FunctionalTestingFramework\Exceptions\TestReferenceException
      */
     public function testExtendedTestGenerationNoParent()
     {
-        $this->generateAndCompareTest('ChildExtendedTestNoParent');
+        $testObject = TestObjectHandler::getInstance()->getObject('ChildExtendedTestNoParent');
+        $test = TestGenerator::getInstance(null, [$testObject]);
+        $test->createAllTestFiles();
+
+        $cestFile = $test->getExportDir() .
+            DIRECTORY_SEPARATOR .
+            $testObject->getCodeceptionName() .
+            ".php";
+
+        $this->assertFalse(file_exists($cestFile));
     }
 
     /**

src/Magento/FunctionalTestingFramework/Test/Util/ObjectExtensionUtil.php

@@ -210,10 +210,10 @@ public function skipTest($testObject)
         $annotations = $testObject->getAnnotations();
 
         // Add skip to the group array if it doesn't already exist
-        if (array_key_exists('group', $annotations) && !in_array('skip', $annotations['group'])) {
-            array_push($annotations['group'], 'skip');
-        } elseif (!array_key_exists('group', $annotations)) {
-            $annotations['group'] = ['skip'];
+        if (array_key_exists('skip', $annotations)) {
+            return $testObject;
+        } elseif (!array_key_exists('skip', $annotations)) {
+            $annotations['skip'] = ['issueId' => "ParentTestDoesNotExist"];
         }
 
         $skippedTest = new TestObject(

src/Magento/FunctionalTestingFramework/Util/TestGenerator.php

@@ -244,6 +244,16 @@ private function assembleAllTestPhp($testManifest, array $testsToIgnore)
         $cestPhpArray = [];
 
         foreach ($testObjects as $test) {
+            // Do not generate test if it is an extended test and parent does not exist
+            if ($test->isSkipped() && !empty($test->getParentName())) {
+                try {
+                    TestObjectHandler::getInstance()->getObject($test->getParentName());
+                } catch (TestReferenceException $e) {
+                    print("{$test->getName()} will not be generated. Parent {$e->getMessage()} \n");
+                    continue;
+                }
+            }
+
             $this->debug("<comment>Start creating test: " . $test->getCodeceptionName() . "</comment>");
             $php = $this->assembleTestPhp($test);
             $cestPhpArray[] = [$test->getCodeceptionName(), $php];