MQE-1582: Enable Testers To Run Skipped Tests

- Unit/Static check fixes

Author: KevinBKozan

dev/tests/_bootstrap.php

@@ -32,7 +32,8 @@
     true,
     \Magento\FunctionalTestingFramework\Config\MftfApplicationConfig::UNIT_TEST_PHASE,
     true,
-    \Magento\FunctionalTestingFramework\Config\MftfApplicationConfig::LEVEL_NONE
+    \Magento\FunctionalTestingFramework\Config\MftfApplicationConfig::LEVEL_NONE,
+    false
 );
 
 // Load needed framework env params

src/Magento/FunctionalTestingFramework/Config/MftfApplicationConfig.php

@@ -55,7 +55,7 @@ class MftfApplicationConfig
 
     /**
      * Boolean which allows MFTF to fully generate skipped tests
-     * @var bool
+     * @var boolean
      */
     private $allowSkipped;
 
@@ -108,9 +108,9 @@ private function __construct(
      * returns void and is only run once during the lifetime of the application.
      *
      * @param boolean $forceGenerate
-     * @param string $phase
+     * @param string  $phase
      * @param boolean $verboseEnabled
-     * @param string $debugLevel
+     * @param string  $debugLevel
      * @param boolean $allowSkipped
      * @return void
      * @throws TestFrameworkException

src/Magento/FunctionalTestingFramework/Console/BaseGenerateCommand.php

@@ -38,6 +38,13 @@ protected function configure()
             'a',
             InputOption::VALUE_NONE,
             'Allows MFTF to generate and run skipped tests.'
+        )->addOption(
+            'debug',
+            'd',
+            InputOption::VALUE_OPTIONAL,
+            'Run extra validation when running tests. Use option \'none\' to turn off debugging -- 
+             added for backward compatibility, will be removed in the next MAJOR release',
+            MftfApplicationConfig::LEVEL_DEFAULT
         );
     }
 

src/Magento/FunctionalTestingFramework/Console/GenerateTestsCommand.php

@@ -46,13 +46,6 @@ protected function configure()
                 't',
                 InputOption::VALUE_REQUIRED,
                 'A parameter accepting a JSON string used to determine the test configuration'
-            )->addOption(
-                'debug',
-                'd',
-                InputOption::VALUE_OPTIONAL,
-                'Run extra validation when generating tests. Use option \'none\' to turn off debugging -- 
-                 added for backward compatibility, will be removed in the next MAJOR release',
-                MftfApplicationConfig::LEVEL_DEFAULT
             );
 
         parent::configure();
@@ -129,8 +122,14 @@ protected function execute(InputInterface $input, OutputInterface $output)
      * @throws \Magento\FunctionalTestingFramework\Exceptions\TestReferenceException
      * @throws \Magento\FunctionalTestingFramework\Exceptions\XmlException
      */
-    private function createTestConfiguration($json, array $tests, bool $force, $debug, bool $verbose, bool $allowSkipped)
-    {
+    private function createTestConfiguration(
+        $json,
+        array $tests,
+        bool $force,
+        $debug,
+        bool $verbose,
+        bool $allowSkipped
+    ) {
         // set our application configuration so we can references the user options in our framework
         MftfApplicationConfig::create(
             $force,

src/Magento/FunctionalTestingFramework/Console/RunTestCommand.php

@@ -31,15 +31,7 @@ protected function configure()
                 'name',
                 InputArgument::REQUIRED | InputArgument::IS_ARRAY,
                 "name of tests to generate and execute"
-            )->addOption('skip-generate', 'k', InputOption::VALUE_NONE, "skip generation and execute existing test")
-            ->addOption(
-                'debug',
-                'd',
-                InputOption::VALUE_OPTIONAL,
-                'Run extra validation when running tests. Use option \'none\' to turn off debugging -- 
-                 added for backward compatibility, will be removed in the next MAJOR release',
-                MftfApplicationConfig::LEVEL_DEFAULT
-            );
+            )->addOption('skip-generate', 'k', InputOption::VALUE_NONE, "skip generation and execute existing test");
 
         parent::configure();
     }
@@ -63,7 +55,6 @@ protected function execute(InputInterface $input, OutputInterface $output): int
         $debug = $input->getOption('debug') ?? MftfApplicationConfig::LEVEL_DEVELOPER; // for backward compatibility
         $allowSkipped = $input->getOption('allowSkipped');
 
-
         if ($skipGeneration and $remove) {
             // "skip-generate" and "remove" options cannot be used at the same time
             throw new TestFrameworkException(

src/Magento/FunctionalTestingFramework/Console/RunTestGroupCommand.php

@@ -34,13 +34,6 @@ protected function configure()
                 'k',
                 InputOption::VALUE_NONE,
                 "only execute a group of tests without generating from source xml"
-            )->addOption(
-                'debug',
-                'd',
-                InputOption::VALUE_OPTIONAL,
-                'Run extra validation when running tests. Use option \'none\' to turn off debugging -- 
-                 added for backward compatibility, will be removed in the next MAJOR release',
-                MftfApplicationConfig::LEVEL_DEFAULT
             )->addArgument(
                 'groups',
                 InputArgument::IS_ARRAY | InputArgument::REQUIRED,

src/Magento/FunctionalTestingFramework/DataGenerator/Objects/EntityDataObject.php

@@ -206,7 +206,7 @@ public function getDataByName($name, $uniquenessFormat)
             }
             return $this->formatUniqueData($name_lower, $uniquenessData, $uniquenessFormat);
         } elseif (array_key_exists($name, $this->data)) {
-            if (is_array($this->data[$name_lower])) {
+            if (is_array($this->data[$name])) {
                 return $this->data[$name];
             }
             $this->data[$name] = $dataReferenceResolver->getDataReference(