Merge pull request #600 from magento/MQE-1997

Mqe 1997: Type float is wrongly treated as integer in assert actions

Author: okolesnyk

CHANGELOG.md

@@ -1,6 +1,12 @@
 Magento Functional Testing Framework Changelog
 ================================================
 
+2.6.2
+-----
+
+### Fixes
+* Fixed float conversion error in test generation
+
 2.6.1
 -----
 

composer.json

@@ -2,7 +2,7 @@
     "name": "magento/magento2-functional-testing-framework",
     "description": "Magento2 Functional Testing Framework",
     "type": "library",
-    "version": "2.6.1",
+    "version": "2.6.2",
     "license": "AGPL-3.0",
     "keywords": ["magento", "automation", "functional", "testing"],
     "config": {

composer.lock

@@ -49,6 +49,7 @@ class AssertTestCest
 		$I->assertEmpty([], "pass"); // stepKey: assertEmpty
 		$I->assertEquals($text, "Copyright © 2013-2017 Magento, Inc. All rights reserved.", "pass"); // stepKey: assertEquals1
 		$I->assertEquals("Copyright © 2013-2017 Magento, Inc. All rights reserved.", $text, "pass"); // stepKey: assertEquals2
+		$I->assertEquals(1.5, $text, "pass"); // stepKey: assertFloatTypeIsCorrect
 		$I->assertFalse(false, "pass"); // stepKey: assertFalse1
 		$I->assertFileNotExists("/out.txt", "pass"); // stepKey: assertFileNotExists1
 		$I->assertFileNotExists($text, "pass"); // stepKey: assertFileNotExists2

dev/tests/verification/Resources/AssertTest.txt

@@ -54,6 +54,10 @@
             <expectedResult type="string">Copyright © 2013-2017 Magento, Inc. All rights reserved.</expectedResult>
             <actualResult type="variable">text</actualResult>
         </assertEquals>
+        <assertEquals stepKey="assertFloatTypeIsCorrect" message="pass">
+            <expectedResult type="float">1.5</expectedResult>
+            <actualResult type="variable">text</actualResult>
+        </assertEquals>
         <assertFalse stepKey="assertFalse1" message="pass">
             <actualResult type="bool">0</actualResult>
         </assertFalse>

dev/tests/verification/TestModule/Test/AssertTest.xml

@@ -2194,6 +2194,6 @@ private function wrapParameterArray(string $value): string
      */
     private function hasDecimalPoint(string $outStr)
     {
-        return strpos($outStr, localeconv()['decimal_point']) === false;
+        return strpos($outStr, localeconv()['decimal_point']) !== false;
     }
 }