MFTF-33582: Eliminated AspectMock remnants

Author: bohdan-harniuk

dev/tests/_bootstrap.php

@@ -15,23 +15,6 @@
 require_once $mftfTestCasePath;
 require_once $mftfStaticTestCasePath;
 
-// Set up AspectMock
-$kernel = \AspectMock\Kernel::getInstance();
-$kernel->init([
-    'debug' => true,
-    'includePaths' => [
-        PROJECT_ROOT . DIRECTORY_SEPARATOR . 'src',
-        PROJECT_ROOT . DIRECTORY_SEPARATOR . 'vendor' . DIRECTORY_SEPARATOR . 'allure-framework'
-    ],
-    'cacheDir' => PROJECT_ROOT .
-        DIRECTORY_SEPARATOR .
-        'dev' .
-        DIRECTORY_SEPARATOR .
-        'tests' .
-        DIRECTORY_SEPARATOR .
-        '.cache'
-]);
-
 // set mftf appplication context
 \Magento\FunctionalTestingFramework\Config\MftfApplicationConfig::create(
     true,

dev/tests/verification/TestModule/Test/testFile.xml

@@ -0,0 +1 @@
+<tests><test name='testName'><annotations>a</annotations></test></tests>

dev/tests/verification/Tests/SchemaValidationTest.php

@@ -6,8 +6,8 @@
 namespace tests\verification\Tests;
 
 use Magento\FunctionalTestingFramework\Config\MftfApplicationConfig;
+use ReflectionProperty;
 use tests\util\MftfTestCase;
-use AspectMock\Test as AspectMock;
 
 class SchemaValidationTest extends MftfTestCase
 {
@@ -19,7 +19,10 @@ class SchemaValidationTest extends MftfTestCase
      */
     public function testInvalidTestSchema()
     {
-        AspectMock::double(MftfApplicationConfig::class, ['getDebugLevel' => MftfApplicationConfig::LEVEL_DEVELOPER]);
+        $property = new ReflectionProperty(MftfApplicationConfig::class, 'debugLevel');
+        $property->setAccessible(true);
+        $property->setValue(MftfApplicationConfig::LEVEL_DEVELOPER);
+
         $testFile = ['testFile.xml' => "<tests><test name='testName'><annotations>a</annotations></test></tests>"];
         $expectedError = TESTS_MODULE_PATH .
             DIRECTORY_SEPARATOR .
@@ -32,11 +35,12 @@ public function testInvalidTestSchema()
     }
 
     /**
-     * After method functionality
-     * @return void
+     * @inheritdoc
      */
     protected function tearDown(): void
     {
-        AspectMock::clean();
+        $property = new ReflectionProperty(MftfApplicationConfig::class, 'debugLevel');
+        $property->setAccessible(true);
+        $property->setValue(null);
     }
 }

dev/tests/verification/Tests/StaticCheck/DeprecationStaticCheckTest.php

@@ -5,9 +5,9 @@
  */
 namespace tests\verification\Tests;
 
-use AspectMock\Test as AspectMock;
 use Magento\FunctionalTestingFramework\StaticCheck\DeprecatedEntityUsageCheck;
 use Magento\FunctionalTestingFramework\StaticCheck\StaticChecksList;
+use ReflectionProperty;
 use Symfony\Component\Console\Input\InputInterface;
 use tests\util\MftfStaticTestCase;
 
@@ -33,7 +33,9 @@ public function testDeprecatedEntityUsageCheck()
         $staticCheck = new DeprecatedEntityUsageCheck();
 
         $input = $this->mockInputInterface(self::TEST_MODULE_PATH);
-        AspectMock::double(StaticChecksList::class, ['getErrorFilesPath' => self::STATIC_RESULTS_DIR]);
+        $property = new ReflectionProperty(StaticChecksList::class, 'errorFilesPath');
+        $property->setAccessible(true);
+        $property->setValue(self::STATIC_RESULTS_DIR);
 
         /** @var InputInterface $input */
         $staticCheck->execute($input);
@@ -47,4 +49,14 @@ public function testDeprecatedEntityUsageCheck()
             self::LOG_FILE
         );
     }
+
+    /**
+     * @inheritdoc
+     */
+    public function tearDown(): void
+    {
+        $property = new ReflectionProperty(StaticChecksList::class, 'errorFilesPath');
+        $property->setAccessible(true);
+        $property->setValue(null);
+    }
 }

dev/tests/verification/Tests/StaticCheck/PauseActionStaticCheckTest.php

@@ -5,11 +5,11 @@
  */
 namespace tests\verification\Tests;
 
-use AspectMock\Test as AspectMock;
+use Exception;
 use Magento\FunctionalTestingFramework\StaticCheck\PauseActionUsageCheck;
 use Magento\FunctionalTestingFramework\StaticCheck\StaticChecksList;
+use ReflectionProperty;
 use Symfony\Component\Console\Input\InputInterface;
-
 use tests\util\MftfStaticTestCase;
 
 class PauseActionStaticCheckTest extends MftfStaticTestCase
@@ -27,14 +27,17 @@ class PauseActionStaticCheckTest extends MftfStaticTestCase
     /**
      * test static-check PauseActionUsageCheck.
      *
-     * @throws \Exception
+     * @throws Exception
      */
     public function testPauseActionUsageCheck()
     {
         $staticCheck = new PauseActionUsageCheck();
 
         $input = $this->mockInputInterface(self::TEST_MODULE_PATH);
-        AspectMock::double(StaticChecksList::class, ['getErrorFilesPath' => self::STATIC_RESULTS_DIR]);
+
+        $property = new ReflectionProperty(StaticChecksList::class, 'errorFilesPath');
+        $property->setAccessible(true);
+        $property->setValue(self::STATIC_RESULTS_DIR);
 
         /** @var InputInterface $input */
         $staticCheck->execute($input);
@@ -48,4 +51,14 @@ public function testPauseActionUsageCheck()
             self::LOG_FILE
         );
     }
+
+    /**
+     * @inheritdoc
+     */
+    public static function tearDownAfterClass(): void
+    {
+        $property = new ReflectionProperty(StaticChecksList::class, 'errorFilesPath');
+        $property->setAccessible(true);
+        $property->setValue(null);
+    }
 }