MQE-567: System env var collision with .env file causes codeception run to fail

- add validate method to ConfigSanitizerUtil
- refactor url based sanitization to use single method with params

Author: imeron2433

src/Magento/FunctionalTestingFramework/Module/MagentoRestDriver.php

@@ -108,7 +108,8 @@ public function _beforeSuite($settings = [])
         if (empty($this->config['url']) || empty($this->config['username']) || empty($this->config['password'])) {
             return;
         }
-        $this->config['url'] = ConfigSanitizerUtil::sanitizeUrl($this->config['url']);
+
+        $this->config = ConfigSanitizerUtil::sanitizeWebDriverConfig($this->config, ['url']);
 
         $this->haveHttpHeader('Content-Type', 'application/json');
         $this->sendPOST(

src/Magento/FunctionalTestingFramework/Util/ConfigSanitizerUtil.php

@@ -12,14 +12,23 @@
 class ConfigSanitizerUtil
 {
     /**
-     * Sanitizes the given Webdriver Config's url and selenium env params.
+     * Sanitizes the given Webdriver Config's url and selenium env params, can be selective based on second argument.
      * @param array $config
+     * @param String[] $params
      * @return array
      */
-    public static function sanitizeWebDriverConfig($config)
+    public static function sanitizeWebDriverConfig($config, $params = ['url', 'selenium'])
     {
-        $config['url'] = self::sanitizeUrl($config['url']);
-        $config = self::sanitizeSeleniumEnvs($config);
+        self::validateConfigBasedVars($config);
+
+        if (array_key_exists('url', array_flip($params))) {
+            $config['url'] = self::sanitizeUrl($config['url']);
+        }
+
+        if (array_key_exists('selenium', array_flip($params))) {
+            $config = self::sanitizeSeleniumEnvs($config);
+        }
+
         return $config;
     }
 
@@ -45,12 +54,37 @@ private static function sanitizeSeleniumEnvs($config)
         return $config;
     }
 
+    /**
+     * Method which validates env vars have been properly read into the config. Method implemented as part of
+     * bug MQE-567
+     *
+     * @param array $config
+     * @return void
+     */
+    private static function validateConfigBasedVars($config)
+    {
+        $configStrings = array_filter($config, function ($value) {
+            return is_string($value);
+        });
+
+        foreach ($configStrings as $configKey => $configValue) {
+            $var = trim((String)$configValue, '%');
+            if (array_key_exists($var, $_ENV)) {
+                trigger_error(
+                    "Issue with setting configuration for test runs. Please make sure '{$var}' is "
+                    . "not duplicated as a system level variable",
+                    E_USER_ERROR
+                );
+            }
+        }
+    }
+
     /**
      * Sanitizes and returns given URL.
      * @param string $url
      * @return string
      */
-    public static function sanitizeUrl($url)
+    private static function sanitizeUrl($url)
     {
         if ($url === "") {
             trigger_error("MAGENTO_BASE_URL must be defined in .env", E_USER_ERROR);