MQE-942: MFTF Annotation Static Check

Author: tomreece

.gitignore

@@ -19,3 +19,4 @@ dev/tests/mftf.log
 dev/tests/docs/*
 dev/tests/_output
 dev/tests/functional.suite.yml
+mftf-annotations-static-check.txt

src/Magento/FunctionalTestingFramework/StaticCheck/AnnotationsCheck.php

@@ -71,6 +71,7 @@ public function execute(InputInterface $input)
 
         foreach ($allTests as $test) {
             $this->validateRequiredAnnotations($test);
+            $this->validateSkipIssueId($test);
             $this->aggregateStoriesTitlePairs($test);
             $this->aggregateTestCaseIdTitlePairs($test);
         }
@@ -145,6 +146,25 @@ private function validateRequiredAnnotations($test)
         }
     }
 
+    /**
+     * Validates that if the test is skipped, that it has an issueId value.
+     *
+     * @param TestObject $test
+     * @return void
+     */
+    private function validateSkipIssueId($test)
+    {
+        $annotations = $test->getAnnotations();
+
+        $skip = $annotations['skip'] ?? null;
+        if ($skip !== null) {
+            $issueId = $skip[0] ?? null;
+            if ($issueId === null || strlen($issueId) == 0) {
+                $this->errors[][] = "Test {$test->getName()} is skipped but the issueId is empty.";
+            }
+        }
+    }
+
     /**
      * Add the key = "stories appended to title", value = test name, to the class variable.
      *