MQE-1513: createData throws a useless error message during runtime when the entity does not exist

Author: soumyau

dev/tests/unit/Magento/FunctionalTestFramework/Util/TestGeneratorTest.php

@@ -14,6 +14,7 @@
 use Magento\FunctionalTestingFramework\Util\MagentoTestCase;
 use Magento\FunctionalTestingFramework\Util\TestGenerator;
 use Magento\FunctionalTestingFramework\Config\MftfApplicationConfig;
+use Magento\FunctionalTestingFramework\Exceptions\TestReferenceException;
 
 class TestGeneratorTest extends MagentoTestCase
 {
@@ -41,11 +42,36 @@ public function testEntityException()
         $testGeneratorObject->createAllTestFiles(null, []);
     }
 
+    /**
+     * Test to check exceptions for createData on referencing non-existent entity
+     *
+     * @throws TestReferenceException
+     */
+
+    public function testCreateDataException()
+    {
+        $actionObject = new ActionObject('fakeAction', 'createData', [
+            'entity' => 'invalidEntity'
+        ]);
+
+        $testObject = new TestObject("sampleTest", ["merge123" => $actionObject], [], [], "filename");
+
+        $testGeneratorObject = TestGenerator::getInstance("", ["sampleTest" => $testObject]);
+
+        AspectMock::double(TestGenerator::class, ['loadAllTestObjects' => ["sampleTest" => $testObject]]);
+
+        $this->expectExceptionMessage("Entity \"invalidEntity\" does not exist." .
+            "\nException occurred parsing action at StepKey \"fakeAction\" in Test \"sampleTest\"");
+
+        $testGeneratorObject->createAllTestFiles(null, []);
+    }
+
     /**
      * Tests that skipped tests do not have a fully generated body
      *
      * @throws \Magento\FunctionalTestingFramework\Exceptions\TestReferenceException
      */
+
     public function testSkippedNoGeneration()
     {
         $actionInput = 'fakeInput';

src/Magento/FunctionalTestingFramework/Util/TestGenerator.php

@@ -731,6 +731,13 @@ public function generateStepsPhp($actionObjects, $generationScope = TestGenerato
                 case "createData":
                     $entity = $customActionAttributes['entity'];
 
+                    if(DataObjectHandler::getInstance()->getObject($entity) === null) {
+                        throw new TestReferenceException(
+                            "Entity \"" . $entity . "\" does not exist." .
+                            "\nException occurred parsing action at StepKey \"" . $stepKey . "\""
+                        );
+                    }
+
                     //TODO refactor entity field override to not be individual actionObjects
                     $customEntityFields =
                         $customActionAttributes[ActionObjectExtractor::ACTION_OBJECT_PERSISTENCE_FIELDS] ?? [];